From: <firstname.lastname@example.org> To: "'Sibi Sankar'" <email@example.com>, "'Viresh Kumar'" <firstname.lastname@example.org> Cc: <email@example.com>, <firstname.lastname@example.org>, "'Sudeep Holla'" <email@example.com>, "'Rafael J. Wysocki'" <firstname.lastname@example.org>, "'Rob Herring'" <email@example.com>, <firstname.lastname@example.org>, <email@example.com>, <firstname.lastname@example.org> Subject: R: R: [RFC PATCH v3 0/2] Add Krait Cache Scaling support Date: Thu, 3 Sep 2020 13:00:27 +0200 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> > -----Messaggio originale----- > Da: email@example.com > <firstname.lastname@example.org> Per conto di Sibi Sankar > Inviato: giovedì 3 settembre 2020 09:13 > A: Viresh Kumar <email@example.com> > Cc: firstname.lastname@example.org; email@example.com; > firstname.lastname@example.org; 'Sudeep Holla' <email@example.com>; 'Rafael J. > Wysocki' <firstname.lastname@example.org>; 'Rob Herring' <email@example.com>; linux- > firstname.lastname@example.org; email@example.com; linux- > firstname.lastname@example.org > Oggetto: Re: R: [RFC PATCH v3 0/2] Add Krait Cache Scaling support > > On 2020-09-03 12:23, Viresh Kumar wrote: > > On 31-08-20, 09:41, email@example.com wrote: > >> On 31-08-20, Sibi wrote: > >> > On 2020-08-24 16:10, Viresh Kumar wrote: > >> > > +Vincent/Saravana/Sibi > >> > > > >> > > On 21-08-20, 16:00, Ansuel Smith wrote: > >> > >> This adds Krait Cache scaling support using the cpufreq notifier. > >> > >> I have some doubt about where this should be actually placed (clk > or > >> > >> cpufreq)? > >> > >> Also the original idea was to create a dedicated cpufreq driver (like > >> > >> it's done in > >> > >> the codeaurora qcom repo) by copying the cpufreq-dt driver and > adding > >> > >> the cache > >> > >> scaling logic but i still don't know what is better. Have a very > >> > >> similar driver or > >> > >> add a dedicated driver only for the cache using the cpufreq notifier > >> > >> and do the > >> > >> scale on every freq transition. > >> > >> Thanks to everyone who will review or answer these questions. > >> > > > >> > > Saravana was doing something with devfreq to solve such issues if I > >> > > wasn't mistaken. > >> > > > >> > > Sibi ? > >> > > >> > IIRC the final plan was to create a devfreq device > >> > and devfreq-cpufreq based governor to scale them, this > >> > way one can switch to a different governor if required. > >> > >> So in this case I should convert this patch to a devfreq driver- > > > > I think this should happen nevertheless. You are doing DVFS for a > > device which isn't a CPU and devfreq looks to be the right place of > > doing so. > > > >> Isn't overkill to use a governor for such a task? > >> (3 range based on the cpufreq?) > > > > I am not sure about the governor part here, maybe it won't be required > > ? > > Yeah I don't see it being needed in ^^ > case as well. I just mentioned them as > an advantage in case you wanted to switch > to a different governor in the future. > > https://lore.kernel.org/lkml/d0bc8877-6d41-f54e-1c4c- > firstname.lastname@example.org/ > > A devfreq governor tracking cpufreq was > generally accepted but using a cpufreq > notifier to achieve that was discouraged. > I read the patch discussion and it looks like at the very end they lost interest in pushing it. That would very fit what I need here so I'm asking how should I proceed? Keep the cpufreq notifier? Introduce a dedicated governor? Ask them to resume the pushing or try to include the changes to the passive governor by myself? > -- > Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, > a Linux Foundation Collaborative Project.
prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-21 14:00 Ansuel Smith 2020-08-21 14:00 ` [RFC PATCH v3 1/2] cpufreq: qcom: " Ansuel Smith 2020-08-21 14:00 ` [RFC PATCH v3 2/2] dt-bindings: cpufreq: Document Krait CPU Cache scaling Ansuel Smith 2020-08-24 17:28 ` Rob Herring 2020-08-24 10:40 ` [RFC PATCH v3 0/2] Add Krait Cache Scaling support Viresh Kumar 2020-08-31 5:45 ` Sibi Sankar 2020-08-31 7:41 ` R: " ansuelsmth 2020-09-03 6:53 ` Viresh Kumar 2020-09-03 7:13 ` Sibi Sankar 2020-09-03 11:00 ` ansuelsmth [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ email@example.com public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git