From: Sibi Sankar <sibis@codeaurora.org>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: sboyd@kernel.org, georgi.djakov@linaro.org, nm@ti.com,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, saravanak@google.com, mka@chromium.org,
smasetty@codeaurora.org, linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH] OPP: Check for bandwidth values before creating icc paths
Date: Fri, 29 May 2020 19:47:18 +0530 [thread overview]
Message-ID: <0205034b0ece173a7152a43b016985a7@codeaurora.org> (raw)
In-Reply-To: <20200529052031.n2nvzxdsifwmthfv@vireshk-i7>
On 2020-05-29 10:50, Viresh Kumar wrote:
> On 28-05-20, 00:54, Sibi Sankar wrote:
>> Prevent the core from creating and voting on icc paths when the
>> opp-table does not have the bandwidth values populated. Currently
>> this check is performed on the first OPP node.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> drivers/opp/of.c | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
>> index 61fce1284f012..95cf6f1312765 100644
>> --- a/drivers/opp/of.c
>> +++ b/drivers/opp/of.c
>> @@ -338,6 +338,21 @@ int dev_pm_opp_of_find_icc_paths(struct device
>> *dev,
>> struct device_node *np;
>> int ret = 0, i, count, num_paths;
>> struct icc_path **paths;
>> + struct property *prop;
>> +
>> + /* Check for bandwidth values on the first OPP node */
>> + if (opp_table && opp_table->np) {
>> + np = of_get_next_available_child(opp_table->np, NULL);
>> + if (!np) {
>> + dev_err(dev, "Empty OPP table\n");
>> + return 0;
>> + }
>> +
>> + prop = of_find_property(np, "opp-peak-kBps", NULL);
>> + of_node_put(np);
>> + if (!prop || !prop->length)
>> + return 0;
>> + }
>
> This doesn't support the call made from cpufreq-dt driver. Pushed
> this, please give this a try:
Viresh,
Thanks for the patch!
>
> From: Sibi Sankar <sibis@codeaurora.org>
> Date: Thu, 28 May 2020 00:54:18 +0530
> Subject: [PATCH] opp: Don't parse icc paths unnecessarily
>
> The DT node of the device may contain interconnect paths while the OPP
> table doesn't have the bandwidth values. There is no need to parse the
> paths in such cases.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> [ Viresh: Support the case of !opp_table and massaged changelog ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/opp/of.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 44 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 61fce1284f01..8c1bf01f0e50 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -332,13 +332,56 @@ static int _of_opp_alloc_required_opps(struct
> opp_table *opp_table,
> return ret;
> }
>
> +static int _bandwidth_supported(struct device *dev, struct opp_table
> *opp_table)
> +{
> + struct device_node *np, *opp_np;
> + struct property *prop;
> +
> + if (!opp_table) {
> + np = of_node_get(dev->of_node);
> + if (!np)
> + return -ENODEV;
> +
> + opp_np = _opp_of_get_opp_desc_node(np, 0);
> + of_node_put(np);
> +
> + /* Lets not fail in case we are parsing opp-v1 bindings */
> + if (!opp_np)
> + return 0;
> + } else {
> + opp_np = of_node_get(opp_table->np);
opp_np needs to be subjected
to NULL check as well. Lets
move "if (!opp_np)" to outside
the if/else. With the above
change in place:
Tested-by: Sibi Sankar <sibis@codeaurora.org>
Reviewed-by: Sibi Sankar <sibis@codeaurora.org>
> + }
> +
> + /* Checking only first OPP is sufficient */
> + np = of_get_next_available_child(opp_np, NULL);
> + if (!np) {
> + dev_err(dev, "OPP table empty\n");
> + return -EINVAL;
> + }
> + of_node_put(opp_np);
> +
> + prop = of_find_property(np, "opp-peak-kBps", NULL);
> + of_node_put(np);
> +
> + if (!prop || !prop->length)
> + return 0;
> +
> + return 1;
> +}
> +
> int dev_pm_opp_of_find_icc_paths(struct device *dev,
> struct opp_table *opp_table)
> {
> struct device_node *np;
> - int ret = 0, i, count, num_paths;
> + int ret, i, count, num_paths;
> struct icc_path **paths;
>
> + ret = _bandwidth_supported(dev, opp_table);
> + if (ret <= 0)
> + return ret;
> +
> + ret = 0;
> +
> np = of_node_get(dev->of_node);
> if (!np)
> return 0;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-05-29 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 19:24 [PATCH] OPP: Check for bandwidth values before creating icc paths Sibi Sankar
2020-05-29 5:20 ` Viresh Kumar
2020-05-29 14:17 ` Sibi Sankar [this message]
2020-06-01 4:07 ` Viresh Kumar
2020-06-01 6:39 ` Sibi Sankar
2020-06-01 7:13 ` Viresh Kumar
2020-06-01 10:00 ` Sibi Sankar
2020-06-01 10:15 ` Viresh Kumar
2020-06-01 10:24 ` Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0205034b0ece173a7152a43b016985a7@codeaurora.org \
--to=sibis@codeaurora.org \
--cc=georgi.djakov@linaro.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=nm@ti.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=smasetty@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).