From: Marc Zyngier <maz@kernel.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-kernel@vger.kernel.org,
Nianyao Tang <tangnianyao@huawei.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] irqchip/gic-v4: Fix non-stick page size error for setup GITS_BASER
Date: Fri, 13 Mar 2020 12:35:10 +0000 [thread overview]
Message-ID: <02159eb7ba2667e3ddea658ff4b3cb92@kernel.org> (raw)
In-Reply-To: <9a00642020fe660e005045913b57fd20@kernel.org>
On 2020-03-13 12:00, Marc Zyngier wrote:
[...]
The astute reader will have noticed that I've sent the wrong patch:
> +static int its_probe_baser_psz(struct its_node *its, struct its_baser
> *baser)
> +{
> + u64 psz = SZ_64K;
> +
> + while (psz) {
> + u64 val, gpsz;
> +
> + val = its_read_baser(its, baser);
> + val &= ~GITS_BASER_PAGE_SIZE_MASK;
> +
> + switch (psz) {
> + case SZ_64K:
> + gpsz = GITS_BASER_PAGE_SIZE_64K;
> + break;
> + case SZ_16K:
> + gpsz = GITS_BASER_PAGE_SIZE_16K;
> + break;
> + case SZ_4K:
> + default:
> + gpsz = GITS_BASER_PAGE_SIZE_4K;
> + break;
> + }
> +
> + gpz >>= GITS_BASER_PAGE_SIZE_SHIFT;
s/gpz/gpsz/
Sorry for the noise,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2020-03-13 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 8:46 [PATCH] irqchip/gic-v4: Fix non-stick page size error for setup GITS_BASER Shaokun Zhang
2020-03-13 12:00 ` Marc Zyngier
2020-03-13 12:35 ` Marc Zyngier [this message]
[not found] ` <fd58dac2-ec20-14b7-53c5-96d798f4ffed@hisilicon.com>
2020-03-16 8:47 ` Marc Zyngier
2020-03-29 20:26 ` [tip: irq/core] irqchip/gic-v3-its: Probe ITS page size for all GITS_BASERn registers tip-bot2 for Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02159eb7ba2667e3ddea658ff4b3cb92@kernel.org \
--to=maz@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangnianyao@huawei.com \
--cc=tglx@linutronix.de \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).