From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33FD7C49EA3 for ; Mon, 14 Jun 2021 11:50:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19BA261105 for ; Mon, 14 Jun 2021 11:50:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236237AbhFNLwO (ORCPT ); Mon, 14 Jun 2021 07:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235745AbhFNLvR (ORCPT ); Mon, 14 Jun 2021 07:51:17 -0400 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [IPv6:2001:4b7a:2000:18::169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7825C061787 for ; Mon, 14 Jun 2021 04:49:14 -0700 (PDT) Received: from [192.168.1.101] (83.6.168.161.neoplus.adsl.tpnet.pl [83.6.168.161]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 2E2233EE2F; Mon, 14 Jun 2021 13:49:09 +0200 (CEST) Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: Added xo clock for eMMC and Sd card To: sbhanu@codeaurora.org Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, robh+dt@kernel.org, asutoshd@codeaurora.org, stummala@codeaurora.org, vbadigan@codeaurora.org, rampraka@codeaurora.org, sayalil@codeaurora.org, sartgarg@codeaurora.org, rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org, sibis@codeaurora.org, okukatla@codeaurora.org, djakov@kernel.org, cang@codeaurora.org, pragalla@codeaurora.org, nitirawa@codeaurora.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, bjorn.andersson@linaro.org References: <1623309107-27833-1-git-send-email-sbhanu@codeaurora.org> From: Konrad Dybcio Message-ID: <0218984d-3cf9-1fc4-9f11-81a4e7df956d@somainline.org> Date: Mon, 14 Jun 2021 13:49:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14.06.2021 13:44, sbhanu@codeaurora.org wrote: > On 2021-06-10 13:24, Konrad Dybcio wrote: >> Hi, >> >> >>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >>> @@ -701,8 +701,9 @@ >>>              interrupt-names = "hc_irq", "pwr_irq"; >>> >>>              clocks = <&gcc GCC_SDCC1_APPS_CLK>, >>> -                    <&gcc GCC_SDCC1_AHB_CLK>; >>> -            clock-names = "core", "iface"; >>> +                    <&gcc GCC_SDCC1_AHB_CLK>, >>> +                    <&rpmhcc RPMH_CXO_CLK>; >> >> Don't these clocks fit in 100 chars? > These two clocks can fit in 100 chars but we have 3 clocks they don't fit in 100 chars. You're right. With the space before xo, Reviewed-by: Konrad Dybcio Konrad