From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbdGEEGl (ORCPT ); Wed, 5 Jul 2017 00:06:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:53904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750758AbdGEEGj (ORCPT ); Wed, 5 Jul 2017 00:06:39 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6252322B56 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=chao@kernel.org Subject: Re: [PATCH 2/2] f2fs: reuse original mount option in ->remount_fs To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu References: <20170629152046.2610-1-chao@kernel.org> <20170629152046.2610-2-chao@kernel.org> <20170701074804.GB85052@jaegeuk-macbookpro.roam.corp.google.com> From: Chao Yu Message-ID: <0240e2cb-b266-37cf-e14a-053c91ea6b0d@kernel.org> Date: Wed, 5 Jul 2017 12:05:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170701074804.GB85052@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/7/1 15:48, Jaegeuk Kim wrote: > On 06/29, Chao Yu wrote: >> From: Chao Yu >> >> Don't clear old mount option before parse new option during ->remount_fs >> like other generic filesystems. > > So, what happened on your original patch? > > commit 26666c8a4366debae30ae37d0688b2bec92d196a > f2fs: fix to clean previous mount option when remount_fs I think that patch is wrong, since the manual doesn't describe kernel logic, so I'd like revert that patch, then f2fs ->remount_fs logic is more like generic filesystem. Thanks, > > I think we need to rever the original patch tho.> > Thanks, > >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/super.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c >> index f27c141cd8aa..af472f7968d0 100644 >> --- a/fs/f2fs/super.c >> +++ b/fs/f2fs/super.c >> @@ -846,7 +846,6 @@ static int f2fs_remount(struct super_block *sb, int *flags, char *data) >> clear_sbi_flag(sbi, SBI_NEED_SB_WRITE); >> } >> >> - sbi->mount_opt.opt = 0; >> default_options(sbi); >> >> /* parse mount options */ >> -- >> 2.13.0.90.g1eb437020