From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754275AbcITLNj (ORCPT ); Tue, 20 Sep 2016 07:13:39 -0400 Received: from mout.web.de ([212.227.17.12]:61170 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752898AbcITLNh (ORCPT ); Tue, 20 Sep 2016 07:13:37 -0400 Subject: Re: GPU-DRM-GMA500: One error message less for a GCT revision mismatch in mid_get_vbt_data() To: Dan Carpenter References: <566ABCD9.1060404@users.sourceforge.net> <3c9785ef-4553-2e3d-2cb2-5cf6d1f31ccd@users.sourceforge.net> <287833f5-f1ad-b7f0-c614-d4c903b1c890@users.sourceforge.net> <87shsulw9k.fsf@intel.com> <20160920104855.GJ13620@mwanda> Cc: Jani Nikula , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Patrik Jakobsson , Julia Lawall , kernel-janitors@vger.kernel.org, LKML From: SF Markus Elfring Message-ID: <0248eabf-9b9e-e43d-0ea4-63d1cad626c0@users.sourceforge.net> Date: Tue, 20 Sep 2016 13:03:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160920104855.GJ13620@mwanda> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:CKIBuiaZ4Jk4rp2icdjiKF0zaru+YKbqDsviMi6TniNqOHpNNY0 MRJvwonZUfTkEXFIu3p9TtvfsrGUJ43wSAWCd5AgGPOvANBX9orBGjnvaOOhGv+fAaBgKw3 zORk7PUTqOfdVPtY3//UZIGQ2pLVasBnCO+Vo/PmR3iC8nSgXfpYEXlwahP+ulcrgrpIl7k IJ+GmZZNJUwOwVesHTlYA== X-UI-Out-Filterresults: notjunk:1;V01:K0:cwz0oXe5anc=:fxc4LfvTzbYN9bKn9MzihJ JyVMtfh6+j04dkde4vj4LHSuSUrBGztu69ApUjQFh9pAxDmgaTQeDq65EAfxqaiNUghGsgOaQ 8/Qhp9biUBBHNyAnIX127edcFFrkj8BbAKu3UKSB8kDXB5UZmyL88JH5+F+wPay2rl6GHcw7c z5CKEO4k9Bwts0U0jdbV5Al+wGO57UOOANsBr2RiD2HfjqC18zUMkcb2pAhKX1FFdSYTJvF6F p9ZjP4ovtmRHc8Zl1vm2aPpas4tfJxhIv6uuEZkhscbUHxwEQMhTdjP1Wvk4qsMZHzs2Vn2MS +bmM1H8VAQlbTPglEaMOf9F2AXqsmDlHqmmjogaRvHjpDnPuEk1+DM26zmYt98wrvLf20WLzS XBFLwr4mC8dOJU/U1LYcV2uv/5MwFt7xV7KO7k9esr2nbkpDYQOr8tdoc1L/MsIGM6G+V+HhQ T5P2yeG24Y8yF2kPyi/to3YnXXbGfeMejSvvtS2mt4C/kpZIy59zyAUnNpCxGTUFlIUrYSq0k O/0SyQLCduhOtywhOaXp6Tq3Pd7GA/F9shNUAIqTH6nKTFmFSKC4xSG9TzrYDNepgKiGuBsMw ZuNFvPP//Gz5SIhLvNTaDdGUz287aMJNFQnQ9Q+Ai+P7L0kpmI3bgDYfdgJVcGq3PU2mY+EgV gd7Gm07r6xb8F3owm6go2cVnZqlwWNrxzfNTuIiDo2+LSccpQ/UdV+b8UDjd/Pmpmm1tOsSY9 9F5iw6CL0MPp8t2SnLeqkozPeaOPsvVNYmr0i4O4FBIAegzXV6AWdTuHW1zNhyBP4Zr7etPL7 JQ+Ihlo Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> A single error message should be sufficient to inform about >>> the detection of an unknown GCT revision at the end. >>> Thus return after the logging call in this case directly. >> >> Did you test this? >> > > Don't be a dummy... This is easy to review an it fixes a bug. Thanks for this kind of constructive feedback. > I'm fine with you NAKing all these patches based on who they are from. Would you like to clarify such an information a bit more? > I mostly just delete these without responding because the guy has > history of introducing bugs and never listens to feedback. I admit that I'll stumble on programming mistakes again occasionally as another ordinary free software developer who is struggling various open issues. I am listening to various feedback. My responses might not be pleasing enough for you. Are you looking for any special information to improve a corresponding discussion? Regards, Markus