From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A68C43217 for ; Sat, 12 Nov 2022 16:29:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234955AbiKLQ3s (ORCPT ); Sat, 12 Nov 2022 11:29:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231534AbiKLQ3q (ORCPT ); Sat, 12 Nov 2022 11:29:46 -0500 Received: from smtp.domeneshop.no (smtp.domeneshop.no [IPv6:2a01:5b40:0:3005::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64948DF16 for ; Sat, 12 Nov 2022 08:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tronnes.org ; s=ds202112; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ItdrEzd/ypbcqe2BCw66feMX7m17nPXFSJOaI27/nkQ=; b=rFsBBXpR5kW0ZTIRro+NqvImhk EhsHq7xGOjgbT5Q0JMV7Rup1oo8niXkDANAAgbHovP46Tc9i2Z0T0+LN9Z0LT7Wf4O0AyERaC7N4I sCC0JKdGDK/DiO/FJfBpqhXQkn3Cg72/KQIBKNoHojAbWzpjvqUNB1Z2Ks94AACK4uc2EI2mDnrLv UAKzvHVCTJwswnGU08vwygQY6vCNXKkQDiHrzyAOVaK52Myy4vxamy7VUC0onDOJmUgsGo/nAgNeV yBGpPCv6RuENflkIaDgPHpx4IAYutqo4ui1Fv38RPkkHgqG/nO2Q3qtS5LJe646/zMqtjDhA2brFp 2x15nfjg==; Received: from [2a01:799:95a:cb00:9d29:d4c4:45a0:777e] (port=49700) by smtp.domeneshop.no with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ottO1-0006e5-Er; Sat, 12 Nov 2022 17:29:41 +0100 Message-ID: <02747a6a-567a-5a70-4ab5-735eda8ac179@tronnes.org> Date: Sat, 12 Nov 2022 17:29:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v8 14/24] drm/modes: Properly generate a drm_display_mode from a named mode To: Maxime Ripard , Maarten Lankhorst , Chen-Yu Tsai , Maxime Ripard , Jernej Skrabec , Karol Herbst , Jani Nikula , Daniel Vetter , Lyude Paul , Samuel Holland , Joonas Lahtinen , Thomas Zimmermann , Emma Anholt , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Ben Skeggs Cc: nouveau@lists.freedesktop.org, Dom Cobley , intel-gfx@lists.freedesktop.org, Phil Elwell , linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , Hans de Goede , linux-kernel@vger.kernel.org, Dave Stevenson , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= References: <20220728-rpi-analog-tv-properties-v8-0-09ce1466967c@cerno.tech> <20220728-rpi-analog-tv-properties-v8-14-09ce1466967c@cerno.tech> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= In-Reply-To: <20220728-rpi-analog-tv-properties-v8-14-09ce1466967c@cerno.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 10.11.2022 12.07, skrev Maxime Ripard: > The framework will get the drm_display_mode from the drm_cmdline_mode it > got by parsing the video command line argument by calling > drm_connector_pick_cmdline_mode(). > > The heavy lifting will then be done by the drm_mode_create_from_cmdline_mode() > function. > > In the case of the named modes though, there's no real code to make that > translation and we rely on the drivers to guess which actual display mode > we meant. > > Let's modify drm_mode_create_from_cmdline_mode() to properly generate the > drm_display_mode we mean when passing a named mode. > > Tested-by: Mateusz Kwiatkowski > Signed-off-by: Maxime Ripard > > --- Reviewed-by: Noralf Trønnes