From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6411C432BE for ; Tue, 3 Aug 2021 15:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD9F860F9C for ; Tue, 3 Aug 2021 15:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237003AbhHCPpE (ORCPT ); Tue, 3 Aug 2021 11:45:04 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:56657 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236745AbhHCPpD (ORCPT ); Tue, 3 Aug 2021 11:45:03 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R821e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UhtcbfK_1628005489; Received: from 30.39.225.192(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0UhtcbfK_1628005489) by smtp.aliyun-inc.com(127.0.0.1); Tue, 03 Aug 2021 23:44:50 +0800 Subject: Re: [PATCH] mm: memcontrol: Set the correct memcg swappiness restriction To: Vlastimil Babka , Michal Hocko Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6e6570d2-44a2-1da1-6c2a-38766786c40c@suse.cz> From: Baolin Wang Message-ID: <02826fde-43a8-e20d-37f5-55416ba0c773@linux.alibaba.com> Date: Tue, 3 Aug 2021 23:45:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <6e6570d2-44a2-1da1-6c2a-38766786c40c@suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/8/3 23:20, Vlastimil Babka wrote: > On 7/30/21 8:39 AM, Michal Hocko wrote: >> On Fri 30-07-21 14:26:35, Baolin Wang wrote: >>> Since commit c843966c556d ("mm: allow swappiness that prefers reclaiming >>> anon over the file workingset") has expended the swappiness value to >>> make swap to be preferred in some systems. We should also change the >>> memcg swappiness restriction to allow memcg swap-preferred. >>> >>> Signed-off-by: Baolin Wang >> >> Yes, this looks like an omission. It doesn't really make sense to have >> two different constrains on the value. >> >> Acked-by: Michal Hocko > > So, also Fixes: c843966c556d ("mm: allow swappiness that prefers reclaiming anon > over the file workingset") > ? Sure. Andrew, do I need resend it with adding fixes tag, or you can help to add it? Thanks.