From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbbDBAHE (ORCPT ); Wed, 1 Apr 2015 20:07:04 -0400 Received: from mga09.intel.com ([134.134.136.24]:10842 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751764AbbDBAG6 convert rfc822-to-8bit (ORCPT ); Wed, 1 Apr 2015 20:06:58 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,507,1422950400"; d="scan'208";a="549855088" From: "Keller, Jacob E" To: Richard Cochran , "netdev@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , Amir Vadai , Ariel Elior , Arnd Bergmann , Baolin Wang , Ben Hutchings , "Allan, Bruce W" , "Wyborny, Carolyn" , Chris Metcalf , David Miller , Frank Li , Giuseppe Cavallaro , "Kirsher, Jeffrey T" , John Stultz , "Luwei Zhou" , "Vick, Matthew" , Michael Chan , Prashant Sreedharan , Rayagond K , Shradha Shah , Solarflare linux maintainers , Sonic Zhang , =?iso-8859-1?Q?Stefan_S=F8rensen?= , Thomas Gleixner , Tom Lendacky Subject: RE: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit get/set time methods. Thread-Topic: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit get/set time methods. Thread-Index: AQHQamUkU6Kg6VkyD0+tXZQJ1WT2n503mr6AgAFCBnA= Date: Thu, 2 Apr 2015 00:06:56 +0000 Message-ID: <02874ECE860811409154E81DA85FBB58574FB888@ORSMSX115.amr.corp.intel.com> References: <67fa71b28f96b222c8027b49efee4144b3754bf7.1427662907.git.richardcochran@gmail.com> <20150331215317.GA9339@localhost.localdomain> In-Reply-To: <20150331215317.GA9339@localhost.localdomain> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Richard Cochran [mailto:richardcochran@gmail.com] > Sent: Tuesday, March 31, 2015 2:53 PM > To: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Amir Vadai; Ariel Elior; Arnd Bergmann; > Baolin Wang; Ben Hutchings; Allan, Bruce W; Wyborny, Carolyn; Chris > Metcalf; David Miller; Frank Li; Giuseppe Cavallaro; Keller, Jacob E; Kirsher, > Jeffrey T; John Stultz; Luwei Zhou; Vick, Matthew; Michael Chan; Prashant > Sreedharan; Rayagond K; Shradha Shah; Solarflare linux maintainers; Sonic > Zhang; Stefan Sørensen; Thomas Gleixner; Tom Lendacky > Subject: Re: [PATCH net-next V3 13/23] ptp: igb: convert to the 64 bit > get/set time methods. > > On Sun, Mar 29, 2015 at 11:12:03PM +0200, Richard Cochran wrote: > > > @@ -627,11 +628,11 @@ static void igb_ptp_overflow_check(struct > work_struct *work) > > { > > struct igb_adapter *igb = > > container_of(work, struct igb_adapter, > ptp_overflow_work.work); > > - struct timespec ts; > > + struct timespec64 ts; > > > > - igb->ptp_caps.gettime(&igb->ptp_caps, &ts); > > + igb->ptp_caps.gettime64(&igb->ptp_caps, &ts); > > > > - pr_debug("igb overflow check at %ld.%09lu\n", ts.tv_sec, > ts.tv_nsec); > > + pr_debug("igb overflow check at %lld.%09lu\n", ts.tv_sec, > ts.tv_nsec); > > For a 64 bit build, this produces the same warning as e1000e. > > What is the best way to deal with this warning? > > Thanks, > Richard I don't know how kernel would fix this. Usually macros like PRI64d are used but I am not sure those are defined for the kernel builds Regards, Jake