From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Doug Anderson'" <dianders@chromium.org>,
"'Wolfram Sang'" <wsa@the-dreams.de>
Cc: "'Tomasz Figa'" <tomasz.figa@gmail.com>,
javier.martinez@collabora.co.uk, ch.naveen@samsung.com,
jg1.han@samsung.com, jdelvare@suse.de, sjg@google.com,
paul.gortmaker@windriver.com, standby24x7@gmail.com,
sachin.kamat@linaro.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: RE: [PATCH v2] i2c: exynos5: Properly use the "noirq" variants of suspend/resume
Date: Wed, 25 Jun 2014 20:13:10 +0900 [thread overview]
Message-ID: <02e701cf9066$7332b280$59981780$@samsung.com> (raw)
In-Reply-To: <1403654093-24134-1-git-send-email-dianders@chromium.org>
Doug Anderson wrote:
>
> The original code for the exynos i2c controller registered for the
> "noirq" variants. However during review feedback it was moved to
> SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no
> longer actually "noirq" (despite functions named
> exynos5_i2c_suspend_noirq and exynos5_i2c_resume_noirq).
>
> i2c controllers that might have wakeup sources on them seem to need to
> resume at noirq time so that the individual drivers can actually read
> the i2c bus to handle their wakeup.
>
> NOTE: I took the original review feedback from Wolfram and added
> poweroff, thaw, freeze, restore.
>
Yeah I'm not sure except .suspend_noirq and .resume_noirq but I'm fine if
Wolfram suggested ;-)
> This patch has only been compile-tested since I don't have all the
> patches needed to make my machine using this i2c driver actually
> suspend/resume.
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
> Changes in v2:
> - Added missing CONFIG_PM_SLEEP
>
> drivers/i2c/busses/i2c-exynos5.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-
> exynos5.c
> index 63d2292..348b1cd 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -789,8 +789,16 @@ static int exynos5_i2c_resume_noirq(struct device *dev)
> }
> #endif
>
> -static SIMPLE_DEV_PM_OPS(exynos5_i2c_dev_pm_ops, exynos5_i2c_suspend_noirq,
> - exynos5_i2c_resume_noirq);
> +const struct dev_pm_ops exynos5_i2c_dev_pm_ops = {
Maybe static const struct...?
> +#ifdef CONFIG_PM_SLEEP
> + .suspend_noirq = exynos5_i2c_suspend_noirq,
> + .resume_noirq = exynos5_i2c_resume_noirq,
> + .freeze_noirq = exynos5_i2c_suspend_noirq,
> + .thaw_noirq = exynos5_i2c_resume_noirq,
> + .poweroff_noirq = exynos5_i2c_suspend_noirq,
> + .restore_noirq = exynos5_i2c_resume_noirq,
> +#endif
> +};
>
> static struct platform_driver exynos5_i2c_driver = {
> .probe = exynos5_i2c_probe,
> --
> 2.0.0.526.g5318336
Others look good to me,
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thanks,
Kukjin
next prev parent reply other threads:[~2014-06-25 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 23:54 [PATCH v2] i2c: exynos5: Properly use the "noirq" variants of suspend/resume Doug Anderson
2014-06-25 11:13 ` Kukjin Kim [this message]
2014-06-25 16:33 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02e701cf9066$7332b280$59981780$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=jdelvare@suse.de \
--cc=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=sachin.kamat@linaro.org \
--cc=sjg@google.com \
--cc=standby24x7@gmail.com \
--cc=tomasz.figa@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).