From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33472C33CAE for ; Mon, 13 Jan 2020 14:02:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 09CAD20678 for ; Mon, 13 Jan 2020 14:02:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728957AbgAMOCn (ORCPT ); Mon, 13 Jan 2020 09:02:43 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:46417 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728831AbgAMOCm (ORCPT ); Mon, 13 Jan 2020 09:02:42 -0500 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ir0Ig-000461-CS; Mon, 13 Jan 2020 15:02:38 +0100 Message-ID: <02f6d17a410114ea9b3bea6e9c43d3aa4bc2dffe.camel@pengutronix.de> Subject: Re: [PATCH] mdio_bus: Simplify reset handling and extend to non-DT systems From: Philipp Zabel To: Geert Uytterhoeven , Andrew Lunn , Florian Fainelli , Heiner Kallweit Cc: "David S . Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 13 Jan 2020 15:02:36 +0100 In-Reply-To: <20200113130529.15372-1-geert+renesas@glider.be> References: <20200113130529.15372-1-geert+renesas@glider.be> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-01-13 at 14:05 +0100, Geert Uytterhoeven wrote: > Convert mdiobus_register_reset() from open-coded DT-only optional reset > handling to reset_control_get_optional_exclusive(). This not only > simplifies the code, but also adds support for lookup-based resets on > non-DT systems. > > Signed-off-by: Geert Uytterhoeven > --- > Only tested on systems without PHY resets, with and without > CONFIG_RESET_CONTROLLER=y. > > drivers/net/phy/mdio_bus.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c > index 229e480179ff1de4..8d753bb07227e561 100644 > --- a/drivers/net/phy/mdio_bus.c > +++ b/drivers/net/phy/mdio_bus.c > @@ -59,17 +59,11 @@ static int mdiobus_register_gpiod(struct mdio_device *mdiodev) > > static int mdiobus_register_reset(struct mdio_device *mdiodev) > { > - struct reset_control *reset = NULL; > - > - if (mdiodev->dev.of_node) > - reset = of_reset_control_get_exclusive(mdiodev->dev.of_node, > - "phy"); > - if (IS_ERR(reset)) { > - if (PTR_ERR(reset) == -ENOENT || PTR_ERR(reset) == -ENOTSUPP) > - reset = NULL; > - else > - return PTR_ERR(reset); > - } > + struct reset_control *reset; > + > + reset = reset_control_get_optional_exclusive(&mdiodev->dev, "phy"); > + if (IS_ERR(reset)) > + return PTR_ERR(reset); Reviewed-by: Philipp Zabel regards Philipp