From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Vivek Gautam'" <gautam.vivek@samsung.com>,
linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
stern@rowland.harvard.edu, kishon@ti.com, k.debski@samsung.com,
jg1.han@samsung.com
Subject: RE: [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420
Date: Mon, 19 May 2014 18:28:55 +0900 [thread overview]
Message-ID: <02fe01cf7344$c19d36f0$44d7a4d0$@samsung.com> (raw)
In-Reply-To: <1399641784-10833-2-git-send-email-gautam.vivek@samsung.com>
Vivek Gautam wrote:
>
> This patch adds sysreg-syscon node to exynos5250 and exynos5420 device
> tree, to access System Register's registers using syscon driver.
>
> Signed-off-by: Kamil Debski <k.debski@samsung.com>
> [gautam.vivek@samsung.com: Split this syreg-syscon dts entry from
> dts: Add usb2phy to Exynos 5250 patch]
> [gautam.vivek@samsung.com: added similar syscon entry for exynos5420]
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
>
Vivek,
See my comment below.
And please don't version each patch in series...it's really not a good way.
It cause very big confusing...
> Changes since v7:
> None
>
> arch/arm/boot/dts/exynos5250.dtsi | 5 +++++
> arch/arm/boot/dts/exynos5420.dtsi | 5 +++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 3742331..70f0cd5 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -175,6 +175,11 @@
> reg = <0x10040000 0x5000>;
> };
>
> + sysreg_system_controller: syscon@10050000 {
> + compatible = "samsung,exynos5250-sys", "syscon";
Maybe exynos5250-sysreg?
And need to add/modify binding doc?
- Kukjin
> + reg = <0x10050000 0x5000>;
> + };
> +
> watchdog@101D0000 {
> compatible = "samsung,exynos5250-wdt";
> reg = <0x101D0000 0x100>;
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
> b/arch/arm/boot/dts/exynos5420.dtsi
> index a802f74..5d5d6e3 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -682,6 +682,11 @@
> reg = <0x10040000 0x5000>;
> };
>
> + sysreg_system_controller: syscon@10050000 {
> + compatible = "samsung,exynos5420-sys", "syscon";
> + reg = <0x10050000 0x5000>;
> + };
> +
> tmu_cpu0: tmu@10060000 {
> compatible = "samsung,exynos5420-tmu";
> reg = <0x10060000 0x100>;
> --
> 1.7.10.4
next prev parent reply other threads:[~2014-05-19 9:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 13:23 [PATCH v2 0/4] dts: Add usb2phy to Exynos 5250/5420 Vivek Gautam
2014-05-09 13:23 ` [PATCH v9 1/4] ARM: dts: Add sysreg sytem controller node to exynos5250 and exynos5420 Vivek Gautam
2014-05-19 9:28 ` Kukjin Kim [this message]
2014-05-09 13:23 ` [PATCH v9 2/4] ARM: dts: Add usb2phy to Exynos 5250 Vivek Gautam
2014-05-09 13:23 ` [PATCH v2 3/4] ARM: dts: Add usb2phy support on exynos5420 Vivek Gautam
2014-05-09 13:23 ` [PATCH v2 4/4] ARM: dts: Add usb 2.0 " Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02fe01cf7344$c19d36f0$44d7a4d0$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gautam.vivek@samsung.com \
--cc=jg1.han@samsung.com \
--cc=k.debski@samsung.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).