From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933841AbcJZQhJ (ORCPT ); Wed, 26 Oct 2016 12:37:09 -0400 Received: from vern.gendns.com ([206.190.152.46]:43664 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932275AbcJZQhF (ORCPT ); Wed, 26 Oct 2016 12:37:05 -0400 Subject: Re: [PATCH v6 1/5] ARM: davinci: da8xx: add usb phy clocks To: Sekhar Nori , Kevin Hilman , Rob Herring , Mark Rutland References: <1477451211-31979-1-git-send-email-david@lechnology.com> <1477451211-31979-2-git-send-email-david@lechnology.com> <6bcc1ac1-446c-6191-1c63-e37ccfaf9556@ti.com> Cc: Axel Haslam , Sergei Shtylyov , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: David Lechner Message-ID: <0302c410-4b05-3a5b-3801-5ab73089a9e2@lechnology.com> Date: Wed, 26 Oct 2016 11:37:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <6bcc1ac1-446c-6191-1c63-e37ccfaf9556@ti.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2016 02:59 AM, Sekhar Nori wrote: > On Wednesday 26 October 2016 08:36 AM, David Lechner wrote: >> Up to this point, the USB phy clock configuration was handled manually in >> the board files and in the usb drivers. This adds proper clocks so that >> the usb drivers can use clk_get and clk_enable and not have to worry about >> the details. Also, the related code is removed from the board files and >> replaced with the new clock registration functions. >> >> Signed-off-by: David Lechner >> Signed-off-by: Axel Haslam >> --- >> >> I have added "ARM: davinci: da8xx: Enable the usb20 "per" clk on phy_clk_enable" >> from Axel Haslam to this patch. >> >> In the review of Axel's patch, Sekhar said: >> >>> We should not be using a NULL device pointer here. Can you pass the musb >>> device pointer available in the same file? Also, da850_clks[] in da850.c >>> needs to be fixed to add the matching device name. >> >> However, the musb device may not be registered. The usb20_clk can be used to >> supply a 48MHz clock to USB 1.1 (ohci) without using the musb device. So, I am >> inclined to leave this as NULL. > > But clock look-up has nothing to do with device being registered AFAICT. > It is used to identify the clock consumer. Passing NULL there means the > clock is not associated with any device. Which is not correct as we are > specifically looking at MUSB module clock. > > Thanks, > Sekhar > FWIW, clk_get() uses dev_name() to get the device name, which will return NULL until after the platform device is registered. I can add the device references anyway. However, this is complicated by the fact that the musb platform device declaration is inside of an #if IS_ENABLED(CONFIG_USB_MUSB_HDRC). I can either remove the #if or add more #if's. Do you have a preference on this?