From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753624AbcLCOly (ORCPT ); Sat, 3 Dec 2016 09:41:54 -0500 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57201 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753523AbcLCOlv (ORCPT ); Sat, 3 Dec 2016 09:41:51 -0500 Subject: Re: [PATCH] iio: 104-quad-8: Fix off-by-one errors when addressing IOR To: William Breathitt Gray , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler References: <20161128215534.GA27078@sophia> Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org From: Jonathan Cameron Message-ID: <030943be-7e17-17d0-62e8-85e2d2470140@kernel.org> Date: Sat, 3 Dec 2016 10:04:07 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161128215534.GA27078@sophia> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/11/16 21:55, William Breathitt Gray wrote: > The Input/Output Control register (IOR) is offset by 1 from the > respective channel data register. This patch fixes off-by-one errors > when attempting to write to a channel IOR where the base address was not > properly offset. > > Fixes: 28e5d3bb0325 ("iio: 104-quad-8: Add IIO support for the ACCES 104-QUAD-8") > Signed-off-by: William Breathitt Gray Applied to the fixes-togreg-post-rc1 branch and marked for stable. Will push out when I next have a net connection and remember! Jonathan > --- > drivers/iio/counter/104-quad-8.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/counter/104-quad-8.c b/drivers/iio/counter/104-quad-8.c > index 2d2ee35..412d283 100644 > --- a/drivers/iio/counter/104-quad-8.c > +++ b/drivers/iio/counter/104-quad-8.c > @@ -153,7 +153,7 @@ static int quad8_write_raw(struct iio_dev *indio_dev, > ior_cfg = val | priv->preset_enable[chan->channel] << 1; > > /* Load I/O control configuration */ > - outb(0x40 | ior_cfg, base_offset); > + outb(0x40 | ior_cfg, base_offset + 1); > > return 0; > case IIO_CHAN_INFO_SCALE: > @@ -241,7 +241,7 @@ static ssize_t quad8_write_set_to_preset_on_index(struct iio_dev *indio_dev, > size_t len) > { > struct quad8_iio *const priv = iio_priv(indio_dev); > - const int base_offset = priv->base + 2 * chan->channel; > + const int base_offset = priv->base + 2 * chan->channel + 1; > bool preset_enable; > int ret; > unsigned int ior_cfg; >