linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Safonov <dima@arista.com>
To: Petr Mladek <pmladek@suse.com>
Cc: linux-kernel@vger.kernel.org,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	John Ogness <john.ogness@linutronix.de>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v2 2/2] printk: Add printk.console_verbose boot parameter
Date: Mon, 26 Jul 2021 14:37:49 +0100	[thread overview]
Message-ID: <031380c9-2b18-d984-c058-d0733c5d3328@arista.com> (raw)
In-Reply-To: <20210721144621.ddvxouzxpp6sn4ec@pathway.suse.cz>

On 7/21/21 3:46 PM, Petr Mladek wrote:
[..]
>> +	printk.console_verbose=
>> +			Raise console loglevel to highest on oops, panic or
>> +			lockdep-detected issues (only if lock debug is on).
>> +			With an exception to setups with low baudrate on
>> +			serial console, keeping this enabled is a good choice
>> +			in order to provide more debug information.
>> +			Format: <bool>  (1/Y/y=enable, 0/N/n=disable)
>> +			default: enabled
> 
> Hmm, the name suggests that the console should always be verbose.
> It looks like a counterpart to the "quiet" option.
> 
> It actually is a counter part to the existing "quiet" option
> except that it triggers in some situations only.
> 
> Hence, I would call it "no_auto_verbose":
> 
>    + "verbose" follows the simple naming scheme of the existing
>      "quiet" option (no "printk" and no "console" in the name)
> 
>    + "no_auto" suggests that it disables some auto-verbose behavior
>      which is exactly what it does.
> 
> Any better idea?

Yeah, ok. I've tried to avoid negative as a parameter as it sometimes
may be confusing. But I see you have this naming in mind and no hard
feelings from my side - I'll call it "no_auto_verbose" in v3.

[..]
>> @@ -2404,6 +2404,12 @@ module_param_named(console_suspend, console_suspend_enabled,
>>  MODULE_PARM_DESC(console_suspend, "suspend console during suspend"
>>  	" and hibernate operations");
>>  
>> +bool printk_console_verbose = true;
> 
> I would call it "console_auto_verbose".
> 
>> +EXPORT_SYMBOL(printk_console_verbose);
> 
> I would prefer to move console_verbose() into printk.c
> and export the function instead of this variable.

Makes sense, will do in v3.

Thanks,
          Dmitry

  reply	other threads:[~2021-07-26 13:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  1:15 [PATCH v2 0/2] printk: Add printk.console_verbose boot param Dmitry Safonov
2021-07-13  1:15 ` [PATCH v2 1/2] printk: Remove console_silent() Dmitry Safonov
2021-07-21 14:15   ` Petr Mladek
2021-07-13  1:15 ` [PATCH v2 2/2] printk: Add printk.console_verbose boot parameter Dmitry Safonov
2021-07-21 14:46   ` Petr Mladek
2021-07-26 13:37     ` Dmitry Safonov [this message]
2021-07-30 11:00   ` Petr Mladek
2021-07-30 11:01 ` [PATCH v2 0/2] printk: Add printk.console_verbose boot param Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=031380c9-2b18-d984-c058-d0733c5d3328@arista.com \
    --to=dima@arista.com \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --subject='Re: [PATCH v2 2/2] printk: Add printk.console_verbose boot parameter' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).