From: Colin Ian King <colin.king@canonical.com>
To: Florian Westphal <fw@strlen.de>, Mukesh Ojha <mojha@codeaurora.org>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S . Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication"
Date: Tue, 16 Apr 2019 10:18:50 +0100 [thread overview]
Message-ID: <03212014-88b1-44c6-4cc1-562f2664680a@canonical.com> (raw)
In-Reply-To: <20190416091214.vjydcg3xblxtvosk@breakpoint.cc>
On 16/04/2019 10:12, Florian Westphal wrote:
> On 4/15/2019 5:14 PM, Colin King wrote:
>>> diff --git a/net/netfilter/nf_conntrack_h323_types.c b/net/netfilter/nf_conntrack_h323_types.c
>>> index d880f3523c1d..95a0b3d6b24d 100644
>>> --- a/net/netfilter/nf_conntrack_h323_types.c
>>> +++ b/net/netfilter/nf_conntrack_h323_types.c
>>> @@ -1109,7 +1109,7 @@ static const struct field_t _SecurityCapabilities[] = { /* SEQUENCE */
>>> _NonStandardParameter},
>>> {FNAME("encryption") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>>> - {FNAME("authenticaton") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> + {FNAME("authentication") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>>> {FNAME("integrity") CHOICE, 2, 3, 3, SKIP | EXT, 0,
>>> _SecurityServiceMode},
>
> https://www.itu.int/ITU-T/formal-language/itu-t/h/h225-0/2009/H323-MESSAGES.html says:
> ...
> SecurityCapabilities ::= SEQUENCE {
> nonStandard NonStandardParameter OPTIONAL,
> encryption SecurityServiceMode,
> authenticaton SecurityServiceMode,
> integrity SecurityServiceMode,
> ...
> }
>
> so this spelling seems intentional.
>
Ah, thanks for spotting that, my bad.
prev parent reply other threads:[~2019-04-16 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 11:44 [PATCH] [NETFILTER]: nf_conntrack_h323: fix spelling mistake "authenticaton" -> "authentication" Colin King
2019-04-16 6:51 ` Mukesh Ojha
2019-04-16 9:12 ` Florian Westphal
2019-04-16 9:18 ` Colin Ian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03212014-88b1-44c6-4cc1-562f2664680a@canonical.com \
--to=colin.king@canonical.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).