From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935976AbcJ0D1W (ORCPT ); Wed, 26 Oct 2016 23:27:22 -0400 Received: from vern.gendns.com ([206.190.152.46]:46026 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932882AbcJ0D1R (ORCPT ); Wed, 26 Oct 2016 23:27:17 -0400 Subject: Re: [PATCH v2 2/4] usb: musb: core: added helper function for parsing DT To: Alexandre Bailon , khilman@baylibre.com, robh+dt@kernel.org, b-liu@ti.com References: <1477494237-22831-1-git-send-email-abailon@baylibre.com> <1477494237-22831-3-git-send-email-abailon@baylibre.com> Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Petr Kulhavy , linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <0324b2c8-ef22-2ef5-1fcd-d1a0807e549e@lechnology.com> Date: Wed, 26 Oct 2016 22:27:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1477494237-22831-3-git-send-email-abailon@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/26/2016 10:03 AM, Alexandre Bailon wrote: > From: Petr Kulhavy > > This adds the function musb_get_mode() to get the DT property "dr_mode" > > Signed-off-by: Petr Kulhavy > Acked-by: Sergei Shtylyov > Signed-off-by: Alexandre Bailon > --- > drivers/usb/musb/musb_core.c | 19 +++++++++++++++++++ > drivers/usb/musb/musb_core.h | 5 +++++ > 2 files changed, 24 insertions(+) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 27dadc0..bba07e7 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -100,6 +100,7 @@ > #include > #include > #include > +#include > > #include "musb_core.h" > #include "musb_trace.h" > @@ -130,6 +131,24 @@ static inline struct musb *dev_to_musb(struct device *dev) > return dev_get_drvdata(dev); > } > > +enum musb_mode musb_get_mode(struct device *dev) > +{ > + enum usb_dr_mode mode; > + > + mode = usb_get_dr_mode(dev); > + switch (mode) { > + case USB_DR_MODE_HOST: > + return MUSB_HOST; > + case USB_DR_MODE_PERIPHERAL: > + return MUSB_PERIPHERAL; > + case USB_DR_MODE_OTG: > + case USB_DR_MODE_UNKNOWN: > + default: > + return MUSB_OTG; > + } > +} > +EXPORT_SYMBOL_GPL(musb_get_mode); > + > /*-------------------------------------------------------------------------*/ > > #ifndef CONFIG_BLACKFIN > diff --git a/drivers/usb/musb/musb_core.h b/drivers/usb/musb/musb_core.h > index 2cb88a49..a406468 100644 > --- a/drivers/usb/musb/musb_core.h > +++ b/drivers/usb/musb/musb_core.h > @@ -617,4 +617,9 @@ static inline void musb_platform_post_root_reset_end(struct musb *musb) > musb->ops->post_root_reset_end(musb); > } > > +/* gets the "dr_mode" property from DT and converts it into musb_mode > + * if the property is not found or not recognized returns MUSB_OTG > + */ > +extern enum musb_mode musb_get_mode(struct device *dev); > + > #endif /* __MUSB_CORE_H__ */ > Tested working on LEGO MINDSTORMS EV3 using dr_mode = "peripheral" and no vbus-supply. Tested-By: David Lechner