From: John Hubbard <jhubbard@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>, akpm@linux-foundation.org
Cc: alex.sierra@amd.com, willy@infradead.org, hch@lst.de,
Felix.Kuehling@amd.com, apopple@nvidia.com, david@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mm: re-allow pinning of zero pfns (again)
Date: Sat, 27 Aug 2022 17:59:32 -0700 [thread overview]
Message-ID: <033c2e8d-8ba9-3e0b-9dee-7d0973c708fa@nvidia.com> (raw)
In-Reply-To: <166015037385.760108.16881097713975517242.stgit@omen>
On 8/10/22 09:53, Alex Williamson wrote:
> The below referenced commit makes the same error as 1c563432588d ("mm: fix
> is_pinnable_page against a cma page"), re-interpreting the logic to exclude
> pinning of the zero page, which breaks device assignment with vfio.
>
> To avoid further subtle mistakes, split the logic into discrete tests.
>
> Suggested-by: Matthew Wilcox <willy@infradead.org>
> Suggested-by: Felix Kuehling <felix.kuehling@amd.com>
> Link: https://lore.kernel.org/all/165490039431.944052.12458624139225785964.stgit@omen
> Fixes: f25cbb7a95a2 ("mm: add zone device coherent type memory support")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> include/linux/mm.h | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
Hi Alex,
Looks good. I'm suggesting a simpler comment, below, because
even though the VFIO folks are thinking about VFIO, here we
are deep in the mm layer and there are lots of non-VFIO callers
that may pin the zero page.
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> index 18e01474cf6b..835106a9718f 100644
> --- a/include/linux/mm.h
> +++ b/include/linux/mm.h
> @@ -1544,9 +1544,20 @@ static inline bool is_longterm_pinnable_page(struct page *page)
> if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE)
> return false;
> #endif
> - return !(is_device_coherent_page(page) ||
> - is_zone_movable_page(page) ||
> - is_zero_pfn(page_to_pfn(page)));
> + /*
> + * The zero page might reside in a movable zone, however it may not
> + * be migrated and can therefore be pinned. The vfio subsystem pins
> + * user mappings including the zero page for IOMMU translation.
> + */
Those notes are all about (some of) the callers. But it's a simple
answer, really, so how about just this:
/* The zero page is always allowed to be pinned. */
?
> + if (is_zero_pfn(page_to_pfn(page)))
> + return true;
> +
> + /* Coherent device memory must always allow eviction. */
> + if (is_device_coherent_page(page))
> + return false;
> +
> + /* Otherwise, non-movable zone pages can be pinned. */
> + return !is_zone_movable_page(page);
> }
> #else
> static inline bool is_longterm_pinnable_page(struct page *page)
>
>
>
Reviewed-by: John Hubbard <jhubbard@nvidia.com>
thanks,
--
John Hubbard
NVIDIA
next prev parent reply other threads:[~2022-08-28 0:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 16:53 [PATCH v2] mm: re-allow pinning of zero pfns (again) Alex Williamson
2022-08-26 19:01 ` Laba, SlawomirX
2022-08-28 0:59 ` John Hubbard [this message]
2022-08-28 1:40 ` Andrew Morton
2022-08-28 12:37 ` Alex Williamson
2022-08-28 17:16 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=033c2e8d-8ba9-3e0b-9dee-7d0973c708fa@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=Felix.Kuehling@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alex.sierra@amd.com \
--cc=alex.williamson@redhat.com \
--cc=apopple@nvidia.com \
--cc=david@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).