From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753564AbcHQSOC (ORCPT ); Wed, 17 Aug 2016 14:14:02 -0400 Received: from mout.web.de ([212.227.15.3]:57383 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753508AbcHQSOA (ORCPT ); Wed, 17 Aug 2016 14:14:00 -0400 Subject: [PATCH 1/4] KVM-S390: Improve determination of sizes in kvm_s390_import_bp_data() To: kvm@vger.kernel.org, linux-s390@vger.kernel.org, =?UTF-8?Q?Christian_Borntr=c3=a4ger?= , Cornelia Huck , David Hildenbrand , Heiko Carstens , Martin Schwidefsky , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <033d8595-d051-1fa8-95b1-5d2056eb5667@users.sourceforge.net> Date: Wed, 17 Aug 2016 20:06:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <82b84c9c-38a4-4d17-910f-312668dbae01@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:yFyI8v5A23BcCmId4fzO/KVXf5Xh4aXuu0nr2KaI9e2tUFsxrgr Luq7oO1NkVipFSM6ohZveIhkA8+Ur3NnXI6Y2J16qF2SEzkdxI4pkHLjqMOR28yG/WeOZCx TJgIr+Gt7sKM9EZJg4H7aiWElLhUQPqn3UgiisTJyOi9Sjq8iE3gEmX/Sq8xg2jFrfuAVPx 2EKHQhRMHewV1aPrsi+mg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Np+Z7cBCSdQ=:MaNkRphaAcK+T+gXiXvg74 agHW4pXOIejNwSBpH4XuROnjw6+3geRZzZVtUuicOtw144IOT1e8pWyD7yIbLz7eW0Gn0YOTM t7LxFCnUFV1nYO2dRlCFJBc5LcsCAOM3N/EQoF16jTxEdtCYH+yv2Ho/bRChYLTxEDIdwEybo SF+BCDT8H+AM6Vc0Wdy3DRboR9Xk96c0t/rNbOyB+Y/y66RUTiVVx3MJoYrrv+Z24fhixBBup uuO3Ml0QpViY4Jh4bqQzQLeKYZSxijIUQgMwjnx6jJkNDLZ0Izoqs4fOKZvRRME2MlnqpziXr q+O+lMQtX1VC86apKxblZwgbXoUYAYQTU6oBMb4Vg/j+/1y7GM9QZgOenwYjT3RbzmRr//8iC 2CHb3hqOFUvw8pQgwowMfAZoo7pNGeew6zVD4wY3cqWNrkSXhT8QDnpngLRxMvYDVfhIXUzGI PVfGdN81l3HY7snAJuCRLwo/44HHeKq+NoSBXf+ZL++q2IBNgQR/Fad9mg4ulSwbYfWUkbvuR p0CN9QtRFUGkU1O6UeXwJmIwDojlBU7iUxhh3gE3Wz3Pk0asvYpqPHV1yzKWq8juv5yfm9IHA c3AdqqZElvZnDfQ8GUivcj3VFXuHtBHugERMH935WLSaruQynUIAGBAFRdnKT4IkBot0ADXmx ivs+bZgrh/7DsVBhL1aDbZ3yvhPKGDCWBTJzBjwFr4g0v3W2VwoOTRPH4Pp+TDaIo2w518O9T 0qE2Rn+BBFanTCwORu2BuM3bDnCjplmiejQ8xXO7VcDIrcRJMuVOgwx0KEUMw96u8zU9Bcqhh jYQkaX4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 17 Aug 2016 18:29:04 +0200 Replace the specification of data structures by pointer dereferences to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- arch/s390/kvm/guestdbg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c index d1f8241..b68db4b 100644 --- a/arch/s390/kvm/guestdbg.c +++ b/arch/s390/kvm/guestdbg.c @@ -216,7 +216,7 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, else if (dbg->arch.nr_hw_bp > MAX_BP_COUNT) return -EINVAL; - size = dbg->arch.nr_hw_bp * sizeof(struct kvm_hw_breakpoint); + size = dbg->arch.nr_hw_bp * sizeof(*bp_data); bp_data = kmalloc(size, GFP_KERNEL); if (!bp_data) { ret = -ENOMEM; @@ -241,7 +241,7 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, } } - size = nr_wp * sizeof(struct kvm_hw_wp_info_arch); + size = nr_wp * sizeof(*wp_info); if (size > 0) { wp_info = kmalloc(size, GFP_KERNEL); if (!wp_info) { @@ -249,7 +249,7 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, goto error; } } - size = nr_bp * sizeof(struct kvm_hw_bp_info_arch); + size = nr_bp * sizeof(*bp_info); if (size > 0) { bp_info = kmalloc(size, GFP_KERNEL); if (!bp_info) { -- 2.9.3