From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A36C3A5A3 for ; Tue, 27 Aug 2019 16:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62CF321881 for ; Tue, 27 Aug 2019 16:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566922367; bh=TN7/7Rqdl/EiqP0v3ytPDvKZIVZ9HCC/Si2Qhz4gL4g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=HERfyv9NrZl+XgmMPy2XFqa+rqnoA5mG5pKKVqqZ5MGWDJDovp5ao7qeq1i98mihj XYr0keK5S4/kNaS6N0rF8mOly0/xWGQcWDhWR3JrXX+6lE3Lci3Hrk3nS6NOpBR4V5 R+SoTeZfYYJT2nsvoxI4Lcm/b1VIS1g7ncXs3KIw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730203AbfH0QMq (ORCPT ); Tue, 27 Aug 2019 12:12:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:57100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbfH0QMp (ORCPT ); Tue, 27 Aug 2019 12:12:45 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 792622186A; Tue, 27 Aug 2019 16:12:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566922364; bh=TN7/7Rqdl/EiqP0v3ytPDvKZIVZ9HCC/Si2Qhz4gL4g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=AbbbpIEaVTjhsHc15DkggjkUbn224g5fFiQubXXAJ1RzbtYDwBdpHL27PTIcDs1OF pXRTnzD3wiBdPnGRkN75ATj9lybwBmeLagzLo7X4xLjuTOyXSBl7sUQKCNoOUy4mtG eGoTR8rxcs7a+2d90SUCxez6ZjAxzJXQfgbuzAvQ= Subject: Re: linux-next: Tree for Aug 27 (kunit) To: Brendan Higgins , Randy Dunlap Cc: Stephen Rothwell , Linux Next Mailing List , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , shuah References: <20190827190526.6f27e763@canb.auug.org.au> From: shuah Message-ID: <0352fae9-564f-4a97-715a-fabe016259df@kernel.org> Date: Tue, 27 Aug 2019 10:12:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/27/19 10:09 AM, Brendan Higgins wrote: > On Tue, Aug 27, 2019 at 8:29 AM Randy Dunlap wrote: >> >> On 8/27/19 2:05 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20190826: >>> >> >> on i386: >> # CONFIG_PRINTK is not set >> >> >> ../kunit/test.c: In function ‘kunit_vprintk_emit’: >> ../kunit/test.c:21:9: error: implicit declaration of function ‘vprintk_emit’; did you mean ‘vprintk’? [-Werror=implicit-function-declaration] >> return vprintk_emit(0, level, NULL, 0, fmt, args); >> ^~~~~~~~~~~~ >> vprintk > Thanks Randy for catching this. > Ooops, it never occurred to me to test the situation where I wouldn't > be able to see test results :-) > > It seems to me that the right thing to do here is to do what > dev_printk and friends do and to ifdef this out if CONFIG_PRINTK is > unavailable. Does that seem reasonable? > > Also, do you want me to resend my patches with the fix or do you want > me to send a new patch with this fix? (Sorry for the newbie question.) > Brendan, I would like to apply the fix on top of the series. I don't want to revert. thanks, -- Shuah