linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Felipe W Damasio" <felipewd@elipse.com.br>
To: "Jeff Garzik" <jgarzik@pobox.com>, "Kent Yoder" <key@austin.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <tsbogend@alpha.franken.de>
Subject: Re: [PATCH] pcnet32 cable status check
Date: Tue, 1 Oct 2002 14:40:22 -0300	[thread overview]
Message-ID: <035401c26971$9dff4b50$1c00a8c0@elipse.com.br> (raw)
In-Reply-To: 3D99D923.5080200@pobox.com


----- Original Message -----
From: "Jeff Garzik" <jgarzik@pobox.com>
To: "Kent Yoder" <key@austin.ibm.com>
Cc: <linux-kernel@vger.kernel.org>; <tsbogend@alpha.franken.de>
Sent: Tuesday, October 01, 2002 2:19 PM
Subject: Re: [PATCH] pcnet32 cable status check


> Kent Yoder wrote:
> > +static void pcnet32_watchdog(struct net_device *dev)
> > +{
> > +    struct pcnet32_private *lp = dev->priv;
> > +
> > +    /* Print the link status if it has changed */
> > +    if (lp->mii)
> > + mii_check_media (&lp->mii_if, 1, 0);
> > +
> > +    mod_timer (&(lp->watchdog_timer), PCNET32_WATCHDOG_TIMEOUT);
> > +}
>
>
> Looks good ;-)
>
> One small thing -- since you appear to test all cases for (lp->mii)
> before calling mod_timer, I don't think you need to test lp->mii inside
> the timer...
>
> As Felipe mentioned, using the link interrupt instead of a timer is
> preferred -- but my own preference would be to apply your patch with the
> small remove-lp->mii-check fixup, and then investigate the support of
> link interrupts.  The reasoning is that, pcnet32 covers a ton of chips,
> and not all may support a link interrupt.

    Sounds nice.

    When identified which chips support Link Change, a bit indicating so
could be add to the capabilities of the NIC so we could choose link
interrupt instead of timer when appropriate.

    I'll try and investigate some chips soon and let you know.

Felipe


  parent reply	other threads:[~2002-10-01 17:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-30 19:31 [PATCH] pcnet32 cable status check Kent Yoder
2002-09-30 20:21 ` Jeff Garzik
2002-09-30 21:48   ` Oops on 2.5.39 was " Kent Yoder
2002-09-30 21:55     ` Jeff Garzik
2002-10-01 16:34   ` Kent Yoder
2002-10-01 16:50     ` Felipe W Damasio
2002-10-01 17:07       ` Jeff Garzik
2002-10-01 17:19         ` Kent Yoder
2002-10-01 17:19     ` Jeff Garzik
2002-10-01 17:30       ` Kent Yoder
2002-10-01 17:36         ` Jeff Garzik
2002-10-01 19:35           ` Kent Yoder
2002-10-01 17:40       ` Felipe W Damasio [this message]
2002-10-07 15:31       ` Kent Yoder
2002-10-22  1:33     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='035401c26971$9dff4b50$1c00a8c0@elipse.com.br' \
    --to=felipewd@elipse.com.br \
    --cc=jgarzik@pobox.com \
    --cc=key@austin.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).