* RE: [PATCH v10 11/14] exfat: add Kconfig and Makefile
@ 2020-01-17 6:43 Markus Elfring
0 siblings, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2020-01-17 6:43 UTC (permalink / raw)
To: Namjae Jeon, linux-fsdevel
Cc: linux-kernel, Arnd Bergmann, Christoph Hellwig,
Greg Kroah-Hartman, Pali Rohár, Sungjong Seo,
Valdis Klētnieks, linkinjeon
> Could you please review updated description ?
…
> +++ b/fs/exfat/Kconfig
> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
…
> + UTF-16 character that exfat filesystem use. and can be overridden with
I suggest to improve this wording a bit more.
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile
2020-01-17 9:12 ` Pali Rohár
@ 2020-01-17 11:59 ` Namjae Jeon
0 siblings, 0 replies; 6+ messages in thread
From: Namjae Jeon @ 2020-01-17 11:59 UTC (permalink / raw)
To: Pali Rohár
Cc: Namjae Jeon, linux-kernel, linux-fsdevel, gregkh,
valdis.kletnieks, hch, sj1557.seo, arnd
>> Hi Pali,
>>
>> Could you please review updated description ?
>>
>> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
>> index 9eeaa6d06..f2b0cf2c1 100644
>> --- a/fs/exfat/Kconfig
>> +++ b/fs/exfat/Kconfig
>> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
>> default "utf8"
>> depends on EXFAT_FS
>> help
>> - Set this to the default input/output character set you'd
>> - like exFAT to use. It should probably match the character set
>> - that most of your exFAT filesystems use, and can be overridden
>> - with the "iocharset" mount option for exFAT filesystems.
>> + Set this to the default input/output character set to use for
>> + converting between the encoding is used for user visible
>> filename and
>> + UTF-16 character that exfat filesystem use. and can be
>> overridden with
>> + the "iocharset" mount option for exFAT filesystems.
>
> Hello! This is much better. Fine for me.
Thanks for your review!
>
> --
> Pali Rohár
> pali.rohar@gmail.com
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile
2020-01-17 4:22 ` Namjae Jeon
@ 2020-01-17 9:12 ` Pali Rohár
2020-01-17 11:59 ` Namjae Jeon
0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2020-01-17 9:12 UTC (permalink / raw)
To: Namjae Jeon
Cc: linux-kernel, linux-fsdevel, gregkh, valdis.kletnieks, hch,
sj1557.seo, linkinjeon, arnd
On Friday 17 January 2020 13:22:27 Namjae Jeon wrote:
> > > +config EXFAT_DEFAULT_IOCHARSET
> > > + string "Default iocharset for exFAT"
> > > + default "utf8"
> > > + depends on EXFAT_FS
> > > + help
> > > + Set this to the default input/output character set you'd
> > > + like exFAT to use. It should probably match the character set
> > > + that most of your exFAT filesystems use, and can be overridden
> > > + with the "iocharset" mount option for exFAT filesystems.
> >
> > Hello! This description is incorrect. iocharset option specify what
> > character set is expected by VFS layer and not character set used by exFAT
> > filesystem. exFAT filesystem always uses UTF-16 as this is the only
> > allowed by exFAT specification.
> Hi Pali,
>
> Could you please review updated description ?
>
> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
> index 9eeaa6d06..f2b0cf2c1 100644
> --- a/fs/exfat/Kconfig
> +++ b/fs/exfat/Kconfig
> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
> default "utf8"
> depends on EXFAT_FS
> help
> - Set this to the default input/output character set you'd
> - like exFAT to use. It should probably match the character set
> - that most of your exFAT filesystems use, and can be overridden
> - with the "iocharset" mount option for exFAT filesystems.
> + Set this to the default input/output character set to use for
> + converting between the encoding is used for user visible filename and
> + UTF-16 character that exfat filesystem use. and can be overridden with
> + the "iocharset" mount option for exFAT filesystems.
Hello! This is much better. Fine for me.
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v10 11/14] exfat: add Kconfig and Makefile
2020-01-15 9:39 ` Pali Rohár
@ 2020-01-17 4:22 ` Namjae Jeon
2020-01-17 9:12 ` Pali Rohár
0 siblings, 1 reply; 6+ messages in thread
From: Namjae Jeon @ 2020-01-17 4:22 UTC (permalink / raw)
To: 'Pali Rohár'
Cc: linux-kernel, linux-fsdevel, gregkh, valdis.kletnieks, hch,
sj1557.seo, linkinjeon, arnd
> > +config EXFAT_DEFAULT_IOCHARSET
> > + string "Default iocharset for exFAT"
> > + default "utf8"
> > + depends on EXFAT_FS
> > + help
> > + Set this to the default input/output character set you'd
> > + like exFAT to use. It should probably match the character set
> > + that most of your exFAT filesystems use, and can be overridden
> > + with the "iocharset" mount option for exFAT filesystems.
>
> Hello! This description is incorrect. iocharset option specify what
> character set is expected by VFS layer and not character set used by exFAT
> filesystem. exFAT filesystem always uses UTF-16 as this is the only
> allowed by exFAT specification.
Hi Pali,
Could you please review updated description ?
diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
index 9eeaa6d06..f2b0cf2c1 100644
--- a/fs/exfat/Kconfig
+++ b/fs/exfat/Kconfig
@@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET
default "utf8"
depends on EXFAT_FS
help
- Set this to the default input/output character set you'd
- like exFAT to use. It should probably match the character set
- that most of your exFAT filesystems use, and can be overridden
- with the "iocharset" mount option for exFAT filesystems.
+ Set this to the default input/output character set to use for
+ converting between the encoding is used for user visible filename and
+ UTF-16 character that exfat filesystem use. and can be overridden with
+ the "iocharset" mount option for exFAT filesystems.
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile
2020-01-15 8:24 ` [PATCH v10 11/14] exfat: add Kconfig and Makefile Namjae Jeon
@ 2020-01-15 9:39 ` Pali Rohár
2020-01-17 4:22 ` Namjae Jeon
0 siblings, 1 reply; 6+ messages in thread
From: Pali Rohár @ 2020-01-15 9:39 UTC (permalink / raw)
To: Namjae Jeon
Cc: linux-kernel, linux-fsdevel, gregkh, valdis.kletnieks, hch,
sj1557.seo, linkinjeon, arnd
On Wednesday 15 January 2020 17:24:44 Namjae Jeon wrote:
> This adds the Kconfig and Makefile for exfat.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
> ---
> fs/exfat/Kconfig | 21 +++++++++++++++++++++
> fs/exfat/Makefile | 8 ++++++++
> 2 files changed, 29 insertions(+)
> create mode 100644 fs/exfat/Kconfig
> create mode 100644 fs/exfat/Makefile
>
> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
> new file mode 100644
> index 000000000000..9eeaa6d06adf
> --- /dev/null
> +++ b/fs/exfat/Kconfig
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +config EXFAT_FS
> + tristate "exFAT filesystem support"
> + select NLS
> + help
> + This allows you to mount devices formatted with the exFAT file system.
> + exFAT is typically used on SD-Cards or USB sticks.
> +
> + To compile this as a module, choose M here: the module will be called
> + exfat.
> +
> +config EXFAT_DEFAULT_IOCHARSET
> + string "Default iocharset for exFAT"
> + default "utf8"
> + depends on EXFAT_FS
> + help
> + Set this to the default input/output character set you'd
> + like exFAT to use. It should probably match the character set
> + that most of your exFAT filesystems use, and can be overridden
> + with the "iocharset" mount option for exFAT filesystems.
Hello! This description is incorrect. iocharset option specify what
character set is expected by VFS layer and not character set used by
exFAT filesystem. exFAT filesystem always uses UTF-16 as this is the
only allowed by exFAT specification.
> diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile
> new file mode 100644
> index 000000000000..ed51926a4971
> --- /dev/null
> +++ b/fs/exfat/Makefile
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +#
> +# Makefile for the linux exFAT filesystem support.
> +#
> +obj-$(CONFIG_EXFAT_FS) += exfat.o
> +
> +exfat-y := inode.o namei.o dir.o super.o fatent.o cache.o nls.o misc.o \
> + file.o balloc.o
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v10 11/14] exfat: add Kconfig and Makefile
[not found] ` <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com>
@ 2020-01-15 8:24 ` Namjae Jeon
2020-01-15 9:39 ` Pali Rohár
0 siblings, 1 reply; 6+ messages in thread
From: Namjae Jeon @ 2020-01-15 8:24 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel
Cc: gregkh, valdis.kletnieks, hch, sj1557.seo, linkinjeon,
pali.rohar, arnd, Namjae Jeon
This adds the Kconfig and Makefile for exfat.
Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com>
---
fs/exfat/Kconfig | 21 +++++++++++++++++++++
fs/exfat/Makefile | 8 ++++++++
2 files changed, 29 insertions(+)
create mode 100644 fs/exfat/Kconfig
create mode 100644 fs/exfat/Makefile
diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig
new file mode 100644
index 000000000000..9eeaa6d06adf
--- /dev/null
+++ b/fs/exfat/Kconfig
@@ -0,0 +1,21 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+
+config EXFAT_FS
+ tristate "exFAT filesystem support"
+ select NLS
+ help
+ This allows you to mount devices formatted with the exFAT file system.
+ exFAT is typically used on SD-Cards or USB sticks.
+
+ To compile this as a module, choose M here: the module will be called
+ exfat.
+
+config EXFAT_DEFAULT_IOCHARSET
+ string "Default iocharset for exFAT"
+ default "utf8"
+ depends on EXFAT_FS
+ help
+ Set this to the default input/output character set you'd
+ like exFAT to use. It should probably match the character set
+ that most of your exFAT filesystems use, and can be overridden
+ with the "iocharset" mount option for exFAT filesystems.
diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile
new file mode 100644
index 000000000000..ed51926a4971
--- /dev/null
+++ b/fs/exfat/Makefile
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0-or-later
+#
+# Makefile for the linux exFAT filesystem support.
+#
+obj-$(CONFIG_EXFAT_FS) += exfat.o
+
+exfat-y := inode.o namei.o dir.o super.o fatent.o cache.o nls.o misc.o \
+ file.o balloc.o
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-17 11:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-17 6:43 [PATCH v10 11/14] exfat: add Kconfig and Makefile Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-01-15 8:24 [PATCH v10 00/14] add the latest exfat driver Namjae Jeon
[not found] ` <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com>
2020-01-15 8:24 ` [PATCH v10 11/14] exfat: add Kconfig and Makefile Namjae Jeon
2020-01-15 9:39 ` Pali Rohár
2020-01-17 4:22 ` Namjae Jeon
2020-01-17 9:12 ` Pali Rohár
2020-01-17 11:59 ` Namjae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).