* RE: [PATCH v10 11/14] exfat: add Kconfig and Makefile @ 2020-01-17 6:43 Markus Elfring 0 siblings, 0 replies; 6+ messages in thread From: Markus Elfring @ 2020-01-17 6:43 UTC (permalink / raw) To: Namjae Jeon, linux-fsdevel Cc: linux-kernel, Arnd Bergmann, Christoph Hellwig, Greg Kroah-Hartman, Pali Rohár, Sungjong Seo, Valdis Klētnieks, linkinjeon > Could you please review updated description ? … > +++ b/fs/exfat/Kconfig > @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET … > + UTF-16 character that exfat filesystem use. and can be overridden with I suggest to improve this wording a bit more. Regards, Markus ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v10 00/14] add the latest exfat driver @ 2020-01-15 8:24 Namjae Jeon [not found] ` <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com> 0 siblings, 1 reply; 6+ messages in thread From: Namjae Jeon @ 2020-01-15 8:24 UTC (permalink / raw) To: linux-kernel, linux-fsdevel Cc: gregkh, valdis.kletnieks, hch, sj1557.seo, linkinjeon, pali.rohar, arnd, Namjae Jeon This adds the latest Samsung exfat driver to fs/exfat. This is an implementation of the Microsoft exFAT specification. Previous versions of this shipped with millions of Android phones, and a random previous snaphot has been merged in drivers/staging/. Compared to the sdfat driver shipped on the phones the following changes have been made: - the support for vfat has been removed as that is already supported by fs/fat - driver has been renamed to exfat - the code has been refactored and clean up to fully integrate into the upstream Linux version and follow the Linux coding style - metadata operations like create, lookup and readdir have been further optimized - various major and minor bugs have been fixed We plan to treat this version as the future upstream for the code base once merged, and all new features and bug fixes will go upstream first. v10: - Make PBR structures as packed structure. - Fix build error on 32 bit system. - Change L suffix of UNIX_SECS_2108 macro with LL suffix to work on both 32/64bit system. - Rework exfat time handling. - Don't warp exfat specification URLs. - Add _FS suffix to config name. - Remove case_sensitive mount option. - iocharset=utf8 mount option work as utf8 option. - Rename the misleading nls names to corresponding ones. - Fix wrong header guard name of exfat_fs.h. - Remove the unneeded braces of macros in exfat_fs.h. - Move the ondisk values to exfat_raw.h - Put the operators at the previous line in exfat_cluster_to_sector(). - Braces of EXFAT_DELETE macro would outside the ~. - Directly use exfat dentry field name. - Add EXFAT_CLUSTERS_UNTRACKED macro. - Remove both sets of inner braces in exfat_set_vol_flags(). - Replace is_reserved_cluster() with an explicit check for EXFAT_EOF_CLUSTER. - Initialize superblock s_time_gran/max/min. - Clean-up exfat_bmap and exfat_get_block(). - Fix wrong boundlen to avoid potential buffer overflow in exfat_convert_char_to_ucs2(). - Process length value as 1 when conversion is failed. - Replace union exfat_timezone with masking the valid bit. - Change exfat_cmp_uniname() with exfat_uniname_ncmp(). - Remove struct exfat_timestamp. - Add atime update support. - Add time_offset mount option. - Remove unneeded CLUSTER_32 macro. - Process utf16 surroage pair as one character. - Rename MUST_ZERO_LEN to PBR64_RESERVED_LEN. - Simplify is_exfat function by just using memchr_inv(). - Remove __exfat_init_name_hash. - Remove exfat_striptail_len. - Split dentry ops for the utf8 vs non-utf8 cases. v9: - Add support time zone. - Fix data past EOF resulting from fsx testsuite. - Remove obsolete comments in __exfat_resolve_path(). - Remove unused file attributes macros. - Remove unneeded #if BITS_PER_LONG. v8: - Rearrange the function grouping in exfat_fs.h (exfat_count_dir_entries, exfat_get_dentry, exfat_get_dentry_set, exfat_find_location). - Mark exfat_extract_uni_name(), exfat_get_uniname_from_ext_entry() and exfat_mirror_bh() as static. v7: - Add the helpers macros for bitmap and fat entry to improve readability. - Rename exfat_test_bitmap to exfat_find_free_bitmap. - Merge exfat_get_num_entries into exfat_calc_num_entries. - Add EXFAT_DATA_CLUSTERS and EXFAT_RESERVED_CLUSTERS macro. - Add the macros for EXFAT BIOS block(JUMP_BOOT_LEN, OEM_NAME_LEN, MUST_BE_ZERO_LEN). - Add the macros for EXFAT entry type (IS_EXFAT_CRITICAL_PRI, IS_EXFAT_BENIGN_PRI, IS_EXFAT_CRITICAL_SEC). - Add EXFAT_FILE_NAME_LEN macro. - Change the data type of is_dir with bool in __exfat_write_inode(). - Change the data type of sync with bool in exfat_set_vol_flags(). - Merge __exfat_set_vol_flags into exfat_set_vol_flags. - Fix wrong statfs->f_namelen. v6: - Fix always false comparison due to limited range of allow_utime's data type. - Move bh into loop in exfat_find_dir_entry(). - Move entry_uniname and unichar variables into an if "entry_type == TYPE_EXTEND" branch. v5: - Remove a blank line between the message and the error code in exfat_load_upcase_table. - Move brelse to the end of the while loop and rename release_bh label to free_table in exfat_load_upcase_table. - Move an error code assignment after a failed function call. - Rename labels and directly return instead of goto. - Improve the exception handling in exfat_get_dentry_set(). - Remove ->d_time leftover. - fix boolreturn.cocci warnings. v4: - Declare ALLOC_FAT_CHAIN and ALLOC_NO_FAT_CHAIN macros. - Rename labels with proper name. - Remove blank lines. - Remove pointer check for bh. - Move ep into loop in exfat_load_bitmap(). - Replace READ/WRITE_ONCE() with test_and_clear_bit() and set_bit(). - Change exfat_allow_set_time return type with bool. v3: - fix wrong sbi->s_dirt set. v2: - Check the bitmap count up to the total clusters. - Rename goto labels in several places. - Change time mode type with enumeration. - Directly return error instead of goto at first error check. - Combine seq_printf calls into a single one. Namjae Jeon (14): exfat: add in-memory and on-disk structures and headers exfat: add super block operations exfat: add inode operations exfat: add directory operations exfat: add file operations exfat: add fat entry operations exfat: add bitmap operations exfat: add exfat cache exfat: add misc operations exfat: add nls operations exfat: add Kconfig and Makefile exfat: add exfat in fs/Kconfig and fs/Makefile MAINTAINERS: add exfat filesystem staging: exfat: make staging/exfat and fs/exfat mutually exclusive MAINTAINERS | 7 + drivers/staging/exfat/Kconfig | 2 +- fs/Kconfig | 3 +- fs/Makefile | 1 + fs/exfat/Kconfig | 21 + fs/exfat/Makefile | 8 + fs/exfat/balloc.c | 282 +++++++ fs/exfat/cache.c | 325 ++++++++ fs/exfat/dir.c | 1244 ++++++++++++++++++++++++++++ fs/exfat/exfat_fs.h | 520 ++++++++++++ fs/exfat/exfat_raw.h | 184 +++++ fs/exfat/fatent.c | 463 +++++++++++ fs/exfat/file.c | 355 ++++++++ fs/exfat/inode.c | 667 +++++++++++++++ fs/exfat/misc.c | 162 ++++ fs/exfat/namei.c | 1442 +++++++++++++++++++++++++++++++++ fs/exfat/nls.c | 834 +++++++++++++++++++ fs/exfat/super.c | 724 +++++++++++++++++ 18 files changed, 7242 insertions(+), 2 deletions(-) create mode 100644 fs/exfat/Kconfig create mode 100644 fs/exfat/Makefile create mode 100644 fs/exfat/balloc.c create mode 100644 fs/exfat/cache.c create mode 100644 fs/exfat/dir.c create mode 100644 fs/exfat/exfat_fs.h create mode 100644 fs/exfat/exfat_raw.h create mode 100644 fs/exfat/fatent.c create mode 100644 fs/exfat/file.c create mode 100644 fs/exfat/inode.c create mode 100644 fs/exfat/misc.c create mode 100644 fs/exfat/namei.c create mode 100644 fs/exfat/nls.c create mode 100644 fs/exfat/super.c -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com>]
* [PATCH v10 11/14] exfat: add Kconfig and Makefile [not found] ` <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com> @ 2020-01-15 8:24 ` Namjae Jeon 2020-01-15 9:39 ` Pali Rohár 0 siblings, 1 reply; 6+ messages in thread From: Namjae Jeon @ 2020-01-15 8:24 UTC (permalink / raw) To: linux-kernel, linux-fsdevel Cc: gregkh, valdis.kletnieks, hch, sj1557.seo, linkinjeon, pali.rohar, arnd, Namjae Jeon This adds the Kconfig and Makefile for exfat. Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> --- fs/exfat/Kconfig | 21 +++++++++++++++++++++ fs/exfat/Makefile | 8 ++++++++ 2 files changed, 29 insertions(+) create mode 100644 fs/exfat/Kconfig create mode 100644 fs/exfat/Makefile diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig new file mode 100644 index 000000000000..9eeaa6d06adf --- /dev/null +++ b/fs/exfat/Kconfig @@ -0,0 +1,21 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +config EXFAT_FS + tristate "exFAT filesystem support" + select NLS + help + This allows you to mount devices formatted with the exFAT file system. + exFAT is typically used on SD-Cards or USB sticks. + + To compile this as a module, choose M here: the module will be called + exfat. + +config EXFAT_DEFAULT_IOCHARSET + string "Default iocharset for exFAT" + default "utf8" + depends on EXFAT_FS + help + Set this to the default input/output character set you'd + like exFAT to use. It should probably match the character set + that most of your exFAT filesystems use, and can be overridden + with the "iocharset" mount option for exFAT filesystems. diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile new file mode 100644 index 000000000000..ed51926a4971 --- /dev/null +++ b/fs/exfat/Makefile @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# +# Makefile for the linux exFAT filesystem support. +# +obj-$(CONFIG_EXFAT_FS) += exfat.o + +exfat-y := inode.o namei.o dir.o super.o fatent.o cache.o nls.o misc.o \ + file.o balloc.o -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile 2020-01-15 8:24 ` [PATCH v10 11/14] exfat: add Kconfig and Makefile Namjae Jeon @ 2020-01-15 9:39 ` Pali Rohár 2020-01-17 4:22 ` Namjae Jeon 0 siblings, 1 reply; 6+ messages in thread From: Pali Rohár @ 2020-01-15 9:39 UTC (permalink / raw) To: Namjae Jeon Cc: linux-kernel, linux-fsdevel, gregkh, valdis.kletnieks, hch, sj1557.seo, linkinjeon, arnd On Wednesday 15 January 2020 17:24:44 Namjae Jeon wrote: > This adds the Kconfig and Makefile for exfat. > > Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com> > Signed-off-by: Sungjong Seo <sj1557.seo@samsung.com> > --- > fs/exfat/Kconfig | 21 +++++++++++++++++++++ > fs/exfat/Makefile | 8 ++++++++ > 2 files changed, 29 insertions(+) > create mode 100644 fs/exfat/Kconfig > create mode 100644 fs/exfat/Makefile > > diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig > new file mode 100644 > index 000000000000..9eeaa6d06adf > --- /dev/null > +++ b/fs/exfat/Kconfig > @@ -0,0 +1,21 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later > + > +config EXFAT_FS > + tristate "exFAT filesystem support" > + select NLS > + help > + This allows you to mount devices formatted with the exFAT file system. > + exFAT is typically used on SD-Cards or USB sticks. > + > + To compile this as a module, choose M here: the module will be called > + exfat. > + > +config EXFAT_DEFAULT_IOCHARSET > + string "Default iocharset for exFAT" > + default "utf8" > + depends on EXFAT_FS > + help > + Set this to the default input/output character set you'd > + like exFAT to use. It should probably match the character set > + that most of your exFAT filesystems use, and can be overridden > + with the "iocharset" mount option for exFAT filesystems. Hello! This description is incorrect. iocharset option specify what character set is expected by VFS layer and not character set used by exFAT filesystem. exFAT filesystem always uses UTF-16 as this is the only allowed by exFAT specification. > diff --git a/fs/exfat/Makefile b/fs/exfat/Makefile > new file mode 100644 > index 000000000000..ed51926a4971 > --- /dev/null > +++ b/fs/exfat/Makefile > @@ -0,0 +1,8 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later > +# > +# Makefile for the linux exFAT filesystem support. > +# > +obj-$(CONFIG_EXFAT_FS) += exfat.o > + > +exfat-y := inode.o namei.o dir.o super.o fatent.o cache.o nls.o misc.o \ > + file.o balloc.o -- Pali Rohár pali.rohar@gmail.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v10 11/14] exfat: add Kconfig and Makefile 2020-01-15 9:39 ` Pali Rohár @ 2020-01-17 4:22 ` Namjae Jeon 2020-01-17 9:12 ` Pali Rohár 0 siblings, 1 reply; 6+ messages in thread From: Namjae Jeon @ 2020-01-17 4:22 UTC (permalink / raw) To: 'Pali Rohár' Cc: linux-kernel, linux-fsdevel, gregkh, valdis.kletnieks, hch, sj1557.seo, linkinjeon, arnd > > +config EXFAT_DEFAULT_IOCHARSET > > + string "Default iocharset for exFAT" > > + default "utf8" > > + depends on EXFAT_FS > > + help > > + Set this to the default input/output character set you'd > > + like exFAT to use. It should probably match the character set > > + that most of your exFAT filesystems use, and can be overridden > > + with the "iocharset" mount option for exFAT filesystems. > > Hello! This description is incorrect. iocharset option specify what > character set is expected by VFS layer and not character set used by exFAT > filesystem. exFAT filesystem always uses UTF-16 as this is the only > allowed by exFAT specification. Hi Pali, Could you please review updated description ? diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig index 9eeaa6d06..f2b0cf2c1 100644 --- a/fs/exfat/Kconfig +++ b/fs/exfat/Kconfig @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET default "utf8" depends on EXFAT_FS help - Set this to the default input/output character set you'd - like exFAT to use. It should probably match the character set - that most of your exFAT filesystems use, and can be overridden - with the "iocharset" mount option for exFAT filesystems. + Set this to the default input/output character set to use for + converting between the encoding is used for user visible filename and + UTF-16 character that exfat filesystem use. and can be overridden with + the "iocharset" mount option for exFAT filesystems. ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile 2020-01-17 4:22 ` Namjae Jeon @ 2020-01-17 9:12 ` Pali Rohár 2020-01-17 11:59 ` Namjae Jeon 0 siblings, 1 reply; 6+ messages in thread From: Pali Rohár @ 2020-01-17 9:12 UTC (permalink / raw) To: Namjae Jeon Cc: linux-kernel, linux-fsdevel, gregkh, valdis.kletnieks, hch, sj1557.seo, linkinjeon, arnd On Friday 17 January 2020 13:22:27 Namjae Jeon wrote: > > > +config EXFAT_DEFAULT_IOCHARSET > > > + string "Default iocharset for exFAT" > > > + default "utf8" > > > + depends on EXFAT_FS > > > + help > > > + Set this to the default input/output character set you'd > > > + like exFAT to use. It should probably match the character set > > > + that most of your exFAT filesystems use, and can be overridden > > > + with the "iocharset" mount option for exFAT filesystems. > > > > Hello! This description is incorrect. iocharset option specify what > > character set is expected by VFS layer and not character set used by exFAT > > filesystem. exFAT filesystem always uses UTF-16 as this is the only > > allowed by exFAT specification. > Hi Pali, > > Could you please review updated description ? > > diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig > index 9eeaa6d06..f2b0cf2c1 100644 > --- a/fs/exfat/Kconfig > +++ b/fs/exfat/Kconfig > @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET > default "utf8" > depends on EXFAT_FS > help > - Set this to the default input/output character set you'd > - like exFAT to use. It should probably match the character set > - that most of your exFAT filesystems use, and can be overridden > - with the "iocharset" mount option for exFAT filesystems. > + Set this to the default input/output character set to use for > + converting between the encoding is used for user visible filename and > + UTF-16 character that exfat filesystem use. and can be overridden with > + the "iocharset" mount option for exFAT filesystems. Hello! This is much better. Fine for me. -- Pali Rohár pali.rohar@gmail.com ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v10 11/14] exfat: add Kconfig and Makefile 2020-01-17 9:12 ` Pali Rohár @ 2020-01-17 11:59 ` Namjae Jeon 0 siblings, 0 replies; 6+ messages in thread From: Namjae Jeon @ 2020-01-17 11:59 UTC (permalink / raw) To: Pali Rohár Cc: Namjae Jeon, linux-kernel, linux-fsdevel, gregkh, valdis.kletnieks, hch, sj1557.seo, arnd >> Hi Pali, >> >> Could you please review updated description ? >> >> diff --git a/fs/exfat/Kconfig b/fs/exfat/Kconfig >> index 9eeaa6d06..f2b0cf2c1 100644 >> --- a/fs/exfat/Kconfig >> +++ b/fs/exfat/Kconfig >> @@ -15,7 +15,7 @@ config EXFAT_DEFAULT_IOCHARSET >> default "utf8" >> depends on EXFAT_FS >> help >> - Set this to the default input/output character set you'd >> - like exFAT to use. It should probably match the character set >> - that most of your exFAT filesystems use, and can be overridden >> - with the "iocharset" mount option for exFAT filesystems. >> + Set this to the default input/output character set to use for >> + converting between the encoding is used for user visible >> filename and >> + UTF-16 character that exfat filesystem use. and can be >> overridden with >> + the "iocharset" mount option for exFAT filesystems. > > Hello! This is much better. Fine for me. Thanks for your review! > > -- > Pali Rohár > pali.rohar@gmail.com > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-01-17 11:59 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-01-17 6:43 [PATCH v10 11/14] exfat: add Kconfig and Makefile Markus Elfring -- strict thread matches above, loose matches on Subject: below -- 2020-01-15 8:24 [PATCH v10 00/14] add the latest exfat driver Namjae Jeon [not found] ` <CGME20200115082825epcas1p1f22ddca6dbf5d70e65d3b0e3c25c3a59@epcas1p1.samsung.com> 2020-01-15 8:24 ` [PATCH v10 11/14] exfat: add Kconfig and Makefile Namjae Jeon 2020-01-15 9:39 ` Pali Rohár 2020-01-17 4:22 ` Namjae Jeon 2020-01-17 9:12 ` Pali Rohár 2020-01-17 11:59 ` Namjae Jeon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).