linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Randy Dunlap'" <rdunlap@infradead.org>, <robh@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
	<krzk@kernel.org>, <avri.altman@wdc.com>,
	<martin.petersen@oracle.com>, <kwmad.kim@samsung.com>,
	<stanley.chu@mediatek.com>, <cang@codeaurora.org>,
	<linux-samsung-soc@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs
Date: Mon, 11 May 2020 22:33:00 +0530	[thread overview]
Message-ID: <036901d627b6$09da7050$1d8f50f0$@samsung.com> (raw)
In-Reply-To: <80a387eb-2325-caab-6754-6d94daeeabac@infradead.org>

Hi Randy

> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: 11 May 2020 08:43
> To: Alim Akhtar <alim.akhtar@samsung.com>; robh@kernel.org
> Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org; krzk@kernel.org;
> avri.altman@wdc.com; martin.petersen@oracle.com;
> kwmad.kim@samsung.com; stanley.chu@mediatek.com;
> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos
> SoCs
> 
> On 5/10/20 7:00 PM, Alim Akhtar wrote:
> > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index
> > e2005aeddc2d..cc7e29c8c24f 100644
> > --- a/drivers/scsi/ufs/Kconfig
> > +++ b/drivers/scsi/ufs/Kconfig
> > @@ -160,3 +160,15 @@ config SCSI_UFS_BSG
> >
> >  	  Select this if you need a bsg device node for your UFS controller.
> >  	  If unsure, say N.
> > +
> > +config SCSI_UFS_EXYNOS
> > +	bool "EXYNOS specific hooks to UFS controller platform driver"
> > +	depends on SCSI_UFSHCD_PLATFORM && ARCH_EXYNOS ||
> COMPILE_TEST
> 
> Since && has higher precedence than ||, I am thinking that this should be
> 
> 	depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS ||
> COMPILE_TEST)
> 
Sure, I missed this, will add in next version.

> > +	select PHY_SAMSUNG_UFS
> > +	help
> > +	  This selects the EXYNOS specific additions to UFSHCD platform driver.
> > +	  UFS host on EXYNOS includes HCI and UNIPRO layer, and associates
> with
> > +	  UFS-PHY driver.
> > +
> > +	  Select this if you have UFS host controller on EXYNOS chipset.
> > +	  If unsure, say N.
> 
> 
> --
> ~Randy



  reply	other threads:[~2020-05-11 17:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200511021347epcas5p2ebef1a4c4aecac26dde73c5d0cc88455@epcas5p2.samsung.com>
2020-05-11  2:00 ` [PATCH v8 00/10] exynos-ufs: Add support for UFS HCI Alim Akhtar
     [not found]   ` <CGME20200511021349epcas5p107f296543fe2c1e13a9e5cbffdab43d3@epcas5p1.samsung.com>
2020-05-11  2:00     ` [PATCH v8 01/10] scsi: ufs: add quirk to fix mishandling utrlclr/utmrlclr Alim Akhtar
     [not found]   ` <CGME20200511021352epcas5p4c6f356db30fbd4905d2c8285ae2aabe6@epcas5p4.samsung.com>
2020-05-11  2:00     ` [PATCH v8 02/10] scsi: ufs: add quirk to disallow reset of interrupt aggregation Alim Akhtar
     [not found]   ` <CGME20200511021354epcas5p1a3f7fe0cf17e7ecc586aaf29eb0d2d7f@epcas5p1.samsung.com>
2020-05-11  2:00     ` [PATCH v8 03/10] scsi: ufs: add quirk to enable host controller without hce Alim Akhtar
     [not found]   ` <CGME20200511021357epcas5p31ca197c25742a50359b076f10d4938cd@epcas5p3.samsung.com>
2020-05-11  2:00     ` [PATCH v8 04/10] scsi: ufs: introduce UFSHCD_QUIRK_PRDT_BYTE_GRAN quirk Alim Akhtar
     [not found]   ` <CGME20200511021359epcas5p24f652fd652a7b55c1ba90d01c03e8336@epcas5p2.samsung.com>
2020-05-11  2:00     ` [PATCH v8 05/10] scsi: ufs: add quirk to fix abnormal ocs fatal error Alim Akhtar
     [not found]   ` <CGME20200511021401epcas5p3b86ec5772ad700736eba6472e1fce8f6@epcas5p3.samsung.com>
2020-05-11  2:00     ` [PATCH v8 06/10] dt-bindings: phy: Document Samsung UFS PHY bindings Alim Akhtar
     [not found]   ` <CGME20200511021404epcas5p1ffee7cc59a191d1ebd81eaaec498821a@epcas5p1.samsung.com>
2020-05-11  2:00     ` [PATCH v8 07/10] phy: samsung-ufs: add UFS PHY driver for samsung SoC Alim Akhtar
     [not found]   ` <CGME20200511021406epcas5p229fb46815d3c29ae06709fa6160e0308@epcas5p2.samsung.com>
2020-05-11  2:00     ` [PATCH v8 08/10] dt-bindings: ufs: Add DT binding documentation for ufs Alim Akhtar
2020-05-11 16:10       ` Rob Herring
     [not found]   ` <CGME20200511021409epcas5p3b78fe59669f13ffae481b57a944da675@epcas5p3.samsung.com>
2020-05-11  2:00     ` [PATCH v8 09/10] scsi: ufs-exynos: add UFS host support for Exynos SoCs Alim Akhtar
2020-05-11  3:13       ` Randy Dunlap
2020-05-11 17:03         ` Alim Akhtar [this message]
     [not found]   ` <CGME20200511021411epcas5p40282690d856ef9d9541506967fd0e764@epcas5p4.samsung.com>
2020-05-11  2:00     ` [PATCH v8 10/10] arm64: dts: Add node for ufs exynos7 Alim Akhtar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='036901d627b6$09da7050$1d8f50f0$@samsung.com' \
    --to=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=cang@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=kwmad.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).