From: Dave Hansen <dave.hansen@intel.com>
To: Pingfan Liu <kernelfans@gmail.com>, x86@kernel.org, linux-mm@kvack.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Mike Rapoport <rppt@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andy Lutomirski <luto@kernel.org>,
Andi Kleen <ak@linux.intel.com>, Petr Tesarik <ptesarik@suse.cz>,
Michal Hocko <mhocko@suse.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Jonathan Corbet <corbet@lwn.net>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Vacek <neelx@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] mm/memblock: make full utilization of numa info
Date: Mon, 25 Feb 2019 07:34:03 -0800 [thread overview]
Message-ID: <0371b80b-3b4c-2377-307f-2001153edd19@intel.com> (raw)
In-Reply-To: <1551011649-30103-3-git-send-email-kernelfans@gmail.com>
On 2/24/19 4:34 AM, Pingfan Liu wrote:
> +/*
> + * build_node_order() relies on cpumask_of_node(), hence arch should
> + * set up cpumask before calling this func.
> + */
Whenever I see comments like this, I wonder what happens if the arch
doesn't do this? Do we just crash in early boot in wonderful new ways?
Or do we get a nice message telling us?
> +void __init memblock_build_node_order(void)
> +{
> + int nid, i;
> + nodemask_t used_mask;
> +
> + node_fallback = memblock_alloc(MAX_NUMNODES * sizeof(int *),
> + sizeof(int *));
> + for_each_online_node(nid) {
> + node_fallback[nid] = memblock_alloc(
> + num_online_nodes() * sizeof(int), sizeof(int));
> + for (i = 0; i < num_online_nodes(); i++)
> + node_fallback[nid][i] = NUMA_NO_NODE;
> + }
> +
> + for_each_online_node(nid) {
> + nodes_clear(used_mask);
> + node_set(nid, used_mask);
> + build_node_order(node_fallback[nid], num_online_nodes(),
> + nid, &used_mask);
> + }
> +}
This doesn't get used until patch 6 as far as I can tell. Was there a
reason to define it here?
next prev parent reply other threads:[~2019-02-25 15:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 12:34 [PATCH 0/6] make memblock allocator utilize the node's fallback info Pingfan Liu
2019-02-24 12:34 ` [PATCH 1/6] mm/numa: extract the code of building node fall back list Pingfan Liu
2019-02-24 12:34 ` [PATCH 2/6] mm/memblock: make full utilization of numa info Pingfan Liu
2019-02-25 7:07 ` kbuild test robot
2019-02-25 7:59 ` kbuild test robot
2019-02-25 15:34 ` Dave Hansen [this message]
2019-02-26 5:40 ` Pingfan Liu
2019-02-26 12:37 ` Dave Hansen
2019-02-26 11:58 ` Mike Rapoport
2019-02-27 9:23 ` Pingfan Liu
2019-02-24 12:34 ` [PATCH 3/6] x86/numa: define numa_init_array() conditional on CONFIG_NUMA Pingfan Liu
2019-02-25 15:23 ` Dave Hansen
2019-02-26 5:40 ` Pingfan Liu
2019-02-24 12:34 ` [PATCH 4/6] x86/numa: concentrate the code of setting cpu to node map Pingfan Liu
2019-02-24 12:34 ` [PATCH 5/6] x86/numa: push forward the setup of node to cpumask map Pingfan Liu
2019-02-25 15:30 ` Dave Hansen
2019-02-26 5:40 ` Pingfan Liu
2019-02-24 12:34 ` [PATCH 6/6] x86/numa: build node fallback info after setting up " Pingfan Liu
2019-02-25 16:03 ` [PATCH 0/6] make memblock allocator utilize the node's fallback info Michal Hocko
2019-02-26 5:47 ` Pingfan Liu
2019-02-26 12:09 ` Michal Hocko
2019-03-05 12:37 ` Pingfan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0371b80b-3b4c-2377-307f-2001153edd19@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kernelfans@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=neelx@redhat.com \
--cc=npiggin@gmail.com \
--cc=ptesarik@suse.cz \
--cc=rppt@linux.vnet.ibm.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).