From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932899AbcLMMUa (ORCPT ); Tue, 13 Dec 2016 07:20:30 -0500 Received: from foss.arm.com ([217.140.101.70]:49778 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932549AbcLMMU2 (ORCPT ); Tue, 13 Dec 2016 07:20:28 -0500 Subject: Re: [PATCH V7 7/8] iommu/arm-smmu: Set privileged attribute to 'default' instead of 'unprivileged' To: Sricharan R , jcrouse@codeaurora.org, pdaly@codeaurora.org, jgebben@codeaurora.org, joro@8bytes.org, linux-kernel@vger.kernel.org, pratikp@codeaurora.org, iommu@lists.linux-foundation.org, tzeng@codeaurora.org, linux-arm-kernel@lists.infradead.org, will.deacon@arm.com, mitchelh@codeaurora.org, vinod.koul@intel.com References: <1481567927-14791-1-git-send-email-sricharan@codeaurora.org> <1481567927-14791-8-git-send-email-sricharan@codeaurora.org> Cc: dan.j.williams@intel.com From: Robin Murphy Message-ID: <03731ccb-dad0-6e0b-577b-4cd8e47717c0@arm.com> Date: Tue, 13 Dec 2016 12:20:24 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1481567927-14791-8-git-send-email-sricharan@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/16 18:38, Sricharan R wrote: > Currently the driver sets all the device transactions privileges > to UNPRIVILEGED, but there are cases where the iommu masters wants > to isolate privileged supervisor and unprivileged user. > So don't override the privileged setting to unprivileged, instead > set it to default as incoming and let it be controlled by the pagetable > settings. > > Acked-by: Will Deacon > Signed-off-by: Sricharan R Since everything else has already got my tags on it: Reviewed-by: Robin Murphy I'd say the whole series looks good to go now, thanks for picking it up. Robin. > --- > drivers/iommu/arm-smmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c > index eaa8f44..8bb0eea 100644 > --- a/drivers/iommu/arm-smmu.c > +++ b/drivers/iommu/arm-smmu.c > @@ -1213,7 +1213,7 @@ static int arm_smmu_domain_add_master(struct arm_smmu_domain *smmu_domain, > continue; > > s2cr[idx].type = type; > - s2cr[idx].privcfg = S2CR_PRIVCFG_UNPRIV; > + s2cr[idx].privcfg = S2CR_PRIVCFG_DEFAULT; > s2cr[idx].cbndx = cbndx; > arm_smmu_write_s2cr(smmu, idx); > } >