From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Jonathan Cameron'" <jic23@kernel.org>,
"'Hartmut Knaack'" <knaack.h@gmx.de>,
"'Lars-Peter Clausen'" <lars@metafoo.de>,
"'Peter Meerwald-Stadler'" <pmeerw@pmeerw.net>,
"'Kukjin Kim'" <kgene@kernel.org>, <linux-iio@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-samsung-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
Date: Mon, 11 May 2020 22:49:28 +0530 [thread overview]
Message-ID: <037501d627b8$56f06870$04d13950$@samsung.com> (raw)
In-Reply-To: <20200511083348.7577-1-krzk@kernel.org>
Hello Krzysztof,
Thanks for the patch.
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 11 May 2020 14:04
> To: Jonathan Cameron <jic23@kernel.org>; Hartmut Knaack
> <knaack.h@gmx.de>; Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-
> Stadler <pmeerw@pmeerw.net>; Kukjin Kim <kgene@kernel.org>; Krzysztof
> Kozlowski <krzk@kernel.org>; linux-iio@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Subject: [PATCH] iio: adc: exynos: Simplify Exynos7-specific init
>
> The Exynos7-specific code bits in ADC driver do not play with PHY:
> the field exynos_adc_data.needs_adc_phy is not set in exynos7_adc_data
> instance. Therefore the initialization code does not have to check if it
is true.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Tested on exynos7-espresso board so,
Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
> ---
>
> Only build tested.
> ---
> drivers/iio/adc/exynos_adc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/adc/exynos_adc.c b/drivers/iio/adc/exynos_adc.c
index
> 22131a677445..219c8eb32d16 100644
> --- a/drivers/iio/adc/exynos_adc.c
> +++ b/drivers/iio/adc/exynos_adc.c
> @@ -449,9 +449,6 @@ static void exynos_adc_exynos7_init_hw(struct
> exynos_adc *info) {
> u32 con1, con2;
>
> - if (info->data->needs_adc_phy)
> - regmap_write(info->pmu_map, info->data->phy_offset, 1);
> -
> con1 = ADC_V2_CON1_SOFT_RESET;
> writel(con1, ADC_V2_CON1(info->regs));
>
> --
> 2.17.1
next prev parent reply other threads:[~2020-05-11 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200511083406epcas5p18e835634e60f362dc408d73886aa5563@epcas5p1.samsung.com>
2020-05-11 8:33 ` [PATCH] iio: adc: exynos: Simplify Exynos7-specific init Krzysztof Kozlowski
2020-05-11 17:19 ` Alim Akhtar [this message]
2020-05-16 16:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='037501d627b8$56f06870$04d13950$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=jic23@kernel.org \
--cc=kgene@kernel.org \
--cc=knaack.h@gmx.de \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).