From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C3FCECAAD3 for ; Fri, 9 Sep 2022 09:49:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbiIIJs7 (ORCPT ); Fri, 9 Sep 2022 05:48:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231769AbiIIJsx (ORCPT ); Fri, 9 Sep 2022 05:48:53 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31A75110ABC for ; Fri, 9 Sep 2022 02:48:51 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id bx38so1156246ljb.10 for ; Fri, 09 Sep 2022 02:48:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=WancZI8YP8VSBJAFL6bEJwq5YWTwAf+vMCt1jVIkDpI=; b=c/DmfEX3Jnhh+mQTSH6JbH+SMCc4p+AoYmc3hYG/O7E55Ha0yMLz0LyHjH4BBA9h7P YwSD50JRjdW2rpXjQVFTdSHT+OkvV8DUFPjZrmhMsjyzOpbL6H1XGyo5ookN1wEA7C/A +iI6tKzRSuLL2mO5re+U9nkTNEq5tWIqmMJOfh06fW/yHtBbXTgLrgauEL4OIb+vt94Z C3BheGp56c4OUqj6H2vGytcBKd/QaePsJHYGJllGCgUay3NAANXzJPQGOLsPphaKat39 utwY+/tHIOdD6F38N1H8k76MOvpNA4cqHJwzvEAnhX5j1wugGQKXoJ6meKM9lbfrjpNc qnfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=WancZI8YP8VSBJAFL6bEJwq5YWTwAf+vMCt1jVIkDpI=; b=oIfTzdfUE8nbrrYhGq/6JJhwDZ5DeY8BtNPAmorTPLKYz33UxdpzzrEVvqVDr9RJkS hsfMkSUr/D8Z4SK2Zcl5sud44G6w5z45zVxHFrlj0io8B5K49VcJhm5ZrWyNRPM1mioH olW+NpuqsP7hyrxp2sMwPPAPnfgJH0aA8srcXzcA8ck9ZMtuIphdMU7V0TPtxRdzcF53 PRzA4isNSwS6VCxUMIlAWlGPJEkf+0FN82Upd7x76GG1v4RBeuqz9wHjoqDvoVCuiyi1 NrUL2k/bTSTaYj10MyiIWFzFovaboogpMVIG3fL2qWrRtAsSqxvAzeNCvxJrMxxMHKub nSsA== X-Gm-Message-State: ACgBeo03PjjUo6cnW/3RnDsxwo5VAW3em9oXLJgTihVcFdwQGDtIqoXx /Qaq8g7DUHozggMp8XXJGpg6RQ== X-Google-Smtp-Source: AA6agR5kHxbAlNJlHm7H2K0r9upPb4NqqNY6jgApbJ1GdX2iE/bsEdx4ndsCr2/DKqvXVTOk656snQ== X-Received: by 2002:a05:651c:1a1e:b0:25f:e7bd:6a4e with SMTP id by30-20020a05651c1a1e00b0025fe7bd6a4emr3995212ljb.362.1662716929326; Fri, 09 Sep 2022 02:48:49 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id p21-20020a2eb7d5000000b0026b96b8ecb6sm3814ljo.111.2022.09.09.02.48.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Sep 2022 02:48:49 -0700 (PDT) Message-ID: <03814cce-4b48-0570-7638-a84bd84c6f7a@linaro.org> Date: Fri, 9 Sep 2022 12:48:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 16/16] phy: qcom-qmp-usb: shorten function prefixes Content-Language: en-GB To: Johan Hovold , Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220907110728.19092-1-johan+linaro@kernel.org> <20220907110728.19092-17-johan+linaro@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20220907110728.19092-17-johan+linaro@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/09/2022 14:07, Johan Hovold wrote: > The driver function prefix has gotten unnecessarily long and hurts > readability. > > Shorten "qcom_qmp_phy_" to "qmp_" (which likely stands for "Qualcomm > Multi PHY" or similar anyway). > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +- > drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 121 ++++++++++++------------ > 2 files changed, 60 insertions(+), 64 deletions(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > index b020409b92e0..4d0eee620f37 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c > @@ -1105,8 +1105,7 @@ static const struct phy_ops qcom_qmp_ufs_ops = { > .owner = THIS_MODULE, > }; > > -static > -int qmp_ufs_create(struct device *dev, struct device_node *np, int id, > +static int qmp_ufs_create(struct device *dev, struct device_node *np, int id, > void __iomem *serdes, const struct qmp_phy_cfg *cfg) This likely should go to the previous patch. Otherwise: Reviewed-by: Dmitry Baryshkov > { > struct qcom_qmp *qmp = dev_get_drvdata(dev); > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c > index 08e0799e8832..41635c21e3ca 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp-usb.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp-usb.c -- With best wishes Dmitry