From: Chris Siebenmann <cks@utcc.utoronto.ca>
To: linux-kernel@vger.kernel.org
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>, ralf@linux-mips.org
Subject: drivers/char/rtc.c compile failure in current 2.4 BitKeeper tree:
Date: Mon, 1 Dec 2003 19:01:17 -0500 [thread overview]
Message-ID: <03Dec1.190119est.6025@ugw.utcc.utoronto.ca> (raw)
I'm compiling for SMP x86 and getting:
make[3]: Entering directory `/homes/hawkwind/u0/cks/sys/linux-BK/drivers/char'
gcc -D__KERNEL__ -I/homes/hawkwind/u0/cks/sys/linux-BK/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=i686 -nostdinc -iwithprefix include -DKBUILD_BASENAME=rtc -c -o rtc.o rtc.c
rtc.c: In function `rtc_init':
rtc.c:772: `RTC_IOMAPPED' undeclared (first use in this function)
rtc.c:772: (Each undeclared identifier is reported only once
rtc.c:772: for each function it appears in.)
rtc.c:773: `RTC_IO_EXTENT' undeclared (first use in this function)
rtc.c: In function `rtc_exit':
rtc.c:873: `RTC_IOMAPPED' undeclared (first use in this function)
rtc.c:874: `RTC_IO_EXTENT' undeclared (first use in this function)
make[3]: *** [rtc.o] Error 1
It looks like the MIPS changes require these to be defined in
include/asm-*/mc146818rtc.h (or included files) for all architectures
(previously RTC_IO_EXTENT was defined in rtc.c and RTC_IOMAPPED didn't
exist), but only MIPS has been updated to do this. From looking at the
diffs to rtc.c, it looks like the correct additions are just:
#define RTC_IO_EXTENT 0x10 /* Only really two ports, but... */
#define RTC_IOMAPPED 0
- cks
next reply other threads:[~2003-12-02 0:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-02 0:01 Chris Siebenmann [this message]
2003-12-02 0:09 ` drivers/char/rtc.c compile failure in current 2.4 BitKeeper tree: Ralf Baechle
2003-12-02 13:31 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03Dec1.190119est.6025@ugw.utcc.utoronto.ca \
--to=cks@utcc.utoronto.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).