From: Can Guo <cang@codeaurora.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
kernel-team@android.com, alim.akhtar@samsung.com,
avri.altman@wdc.com, bvanassche@acm.org,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
Jaegeuk Kim <jaegeuk@google.com>
Subject: Re: [PATCH v4 2/2] scsi: ufs: handle LINERESET with correct tm_cmd
Date: Thu, 07 Jan 2021 16:02:42 +0800 [thread overview]
Message-ID: <03a47a3f49914230653bea777e2ee550@codeaurora.org> (raw)
In-Reply-To: <20210107074710.549309-3-jaegeuk@kernel.org>
On 2021-01-07 15:47, Jaegeuk Kim wrote:
> From: Jaegeuk Kim <jaegeuk@google.com>
>
> This fixes a warning caused by wrong reserve tag usage in
> __ufshcd_issue_tm_cmd.
>
> WARNING: CPU: 7 PID: 7 at block/blk-core.c:630
> blk_get_request+0x68/0x70
> WARNING: CPU: 4 PID: 157 at block/blk-mq-tag.c:82
> blk_mq_get_tag+0x438/0x46c
>
> And, in ufshcd_err_handler(), we can avoid to send tm_cmd before
> aborting
> outstanding commands by waiting a bit for IO completion like this.
>
> __ufshcd_issue_tm_cmd: task management cmd 0x80 timed-out
>
> Fixes: 69a6c269c097 ("scsi: ufs: Use blk_{get,put}_request() to
> allocate and free TMFs")
> Fixes: 2355b66ed20c ("scsi: ufs: Handle LINERESET indication in err
> handler")
Hi Jaegeuk,
Sorry, what is wrong with commit 2355b66ed20c? Clearing pending I/O
reqs is a general procedure for handling all non-fatal errors.
Thanks,
Can Guo.
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> drivers/scsi/ufs/ufshcd.c | 35 +++++++++++++++++++++++++++++++----
> 1 file changed, 31 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index e6e7bdf99cd7..340dd5e515dd 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -44,6 +44,9 @@
> /* Query request timeout */
> #define QUERY_REQ_TIMEOUT 1500 /* 1.5 seconds */
>
> +/* LINERESET TIME OUT */
> +#define LINERESET_IO_TIMEOUT_MS (30000) /* 30 sec */
> +
> /* Task management command timeout */
> #define TM_CMD_TIMEOUT 100 /* msecs */
>
> @@ -5826,6 +5829,7 @@ static void ufshcd_err_handler(struct work_struct
> *work)
> int err = 0, pmc_err;
> int tag;
> bool needs_reset = false, needs_restore = false;
> + ktime_t start;
>
> hba = container_of(work, struct ufs_hba, eh_work);
>
> @@ -5911,6 +5915,22 @@ static void ufshcd_err_handler(struct
> work_struct *work)
> }
>
> hba->silence_err_logs = true;
> +
> + /* Wait for IO completion for non-fatal errors to avoid aborting IOs
> */
> + start = ktime_get();
> + while (hba->outstanding_reqs) {
> + ufshcd_complete_requests(hba);
> + spin_unlock_irqrestore(hba->host->host_lock, flags);
> + schedule();
> + spin_lock_irqsave(hba->host->host_lock, flags);
> + if (ktime_to_ms(ktime_sub(ktime_get(), start)) >
> + LINERESET_IO_TIMEOUT_MS) {
> + dev_err(hba->dev, "%s: timeout, outstanding=0x%lx\n",
> + __func__, hba->outstanding_reqs);
> + break;
> + }
> + }
> +
> /* release lock as clear command might sleep */
> spin_unlock_irqrestore(hba->host->host_lock, flags);
> /* Clear pending transfer requests */
> @@ -6302,9 +6322,13 @@ static irqreturn_t ufshcd_intr(int irq, void
> *__hba)
> intr_status = ufshcd_readl(hba, REG_INTERRUPT_STATUS);
> }
>
> - if (enabled_intr_status && retval == IRQ_NONE) {
> - dev_err(hba->dev, "%s: Unhandled interrupt 0x%08x\n",
> - __func__, intr_status);
> + if (enabled_intr_status && retval == IRQ_NONE &&
> + !ufshcd_eh_in_progress(hba)) {
> + dev_err(hba->dev, "%s: Unhandled interrupt 0x%08x (0x%08x,
> 0x%08x)\n",
> + __func__,
> + intr_status,
> + hba->ufs_stats.last_intr_status,
> + enabled_intr_status);
> ufshcd_dump_regs(hba, 0, UFSHCI_REG_SPACE_SIZE, "host_regs: ");
> }
>
> @@ -6348,7 +6372,10 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba
> *hba,
> * Even though we use wait_event() which sleeps indefinitely,
> * the maximum wait time is bounded by %TM_CMD_TIMEOUT.
> */
> - req = blk_get_request(q, REQ_OP_DRV_OUT, BLK_MQ_REQ_RESERVED);
> + req = blk_get_request(q, REQ_OP_DRV_OUT, 0);
> + if (IS_ERR(req))
> + return PTR_ERR(req);
> +
> req->end_io_data = &wait;
> free_slot = req->tag;
> WARN_ON_ONCE(free_slot < 0 || free_slot >= hba->nutmrs);
next prev parent reply other threads:[~2021-01-07 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 7:47 [PATCH v4 0/2] UFS bug fixes Jaegeuk Kim
2021-01-07 7:47 ` [PATCH v4 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns Jaegeuk Kim
2021-01-07 7:58 ` Can Guo
2021-01-07 7:47 ` [PATCH v4 2/2] scsi: ufs: handle LINERESET with correct tm_cmd Jaegeuk Kim
2021-01-07 8:02 ` Can Guo [this message]
2021-01-07 8:07 ` Jaegeuk Kim
2021-01-07 8:17 ` Can Guo
2021-01-07 8:46 ` Jaegeuk Kim
2021-01-07 8:58 ` Can Guo
2021-01-07 9:13 ` Can Guo
2021-01-07 18:55 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03a47a3f49914230653bea777e2ee550@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=jaegeuk@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).