linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Brian Cain" <bcain@codeaurora.org>
To: "'Nathan Chancellor'" <nathan@kernel.org>,
	"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Nick Desaulniers'" <ndesaulniers@google.com>,
	<linux-hexagon@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<clang-built-linux@googlegroups.com>,
	"'Manning, Sid'" <sidneym@quicinc.com>
Subject: RE: [PATCH] Hexagon: Export raw I/O routines for modules
Date: Wed, 28 Jul 2021 10:08:31 -0500	[thread overview]
Message-ID: <03be01d783c2$6e684420$4b38cc60$@codeaurora.org> (raw)
In-Reply-To: <YQCiZSj1gfnF5x/d@Ryzen-9-3900X.localdomain>



> -----Original Message-----
> From: Nathan Chancellor <nathan@kernel.org>
...
> On Thu, Jul 08, 2021 at 04:38:50PM -0700, Nathan Chancellor wrote:
...
> > Export these symbols so that modules can use them without any errors.
> >
> > Fixes: 013bf24c3829 ("Hexagon: Provide basic implementation and/or stubs
> for I/O routines.")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
> >
> > It would be nice if this could get into 5.14 at some point so that we
> > can build ARCH=hexagon allmodconfig in our CI.
> >
> >  arch/hexagon/lib/io.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/hexagon/lib/io.c b/arch/hexagon/lib/io.c
> > index d35d69d6588c..55f75392857b 100644
> > --- a/arch/hexagon/lib/io.c
> > +++ b/arch/hexagon/lib/io.c
> > @@ -27,6 +27,7 @@ void __raw_readsw(const void __iomem *addr, void
> *data, int len)
> >  		*dst++ = *src;
> >
> >  }
> > +EXPORT_SYMBOL(__raw_readsw);
> >
> >  /*
> >   * __raw_writesw - read words a short at a time
> > @@ -47,6 +48,7 @@ void __raw_writesw(void __iomem *addr, const void
> *data, int len)
> >
> >
> >  }
> > +EXPORT_SYMBOL(__raw_writesw);
> >
> >  /*  Pretty sure len is pre-adjusted for the length of the access
already */
> >  void __raw_readsl(const void __iomem *addr, void *data, int len)
> > @@ -62,6 +64,7 @@ void __raw_readsl(const void __iomem *addr, void
> *data, int len)
> >
> >
> >  }
> > +EXPORT_SYMBOL(__raw_readsl);
> >
> >  void __raw_writesl(void __iomem *addr, const void *data, int len)
> >  {
> > @@ -76,3 +79,4 @@ void __raw_writesl(void __iomem *addr, const void
> *data, int len)
> >
> >
> >  }
> > +EXPORT_SYMBOL(__raw_writesl);
> >
> > base-commit: f55966571d5eb2876a11e48e798b4592fa1ffbb7
> > --
> > 2.32.0.93.g670b81a890
> 
> Ping? Brian, if you do not want to carry this, can you give an ack so
> that Andrew can?

Acked-by: Brian Cain <bcain@codeaurora.org>


  reply	other threads:[~2021-07-28 15:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 23:38 Nathan Chancellor
2021-07-28  0:18 ` Nathan Chancellor
2021-07-28 15:08   ` Brian Cain [this message]
2021-08-04 18:26 ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='03be01d783c2$6e684420$4b38cc60$@codeaurora.org' \
    --to=bcain@codeaurora.org \
    --cc=akpm@linux-foundation.org \
    --cc=clang-built-linux@googlegroups.com \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=sidneym@quicinc.com \
    --subject='RE: [PATCH] Hexagon: Export raw I/O routines for modules' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).