From: Thomas-Mich Richter <tmricht@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Kees Cook <keescook@chromium.org>,
acme@redhat.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Hendrik Brueckner <brueckner@linux.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: WARN_ON_ONCE() hit at kernel/events/core.c:330
Date: Mon, 8 Apr 2019 10:47:35 +0200 [thread overview]
Message-ID: <03ef774b-aa6a-e5ea-6eeb-2457d404d3c7@linux.ibm.com> (raw)
In-Reply-To: <20190408082229.GI4038@hirez.programming.kicks-ass.net>
On 4/8/19 10:22 AM, Peter Zijlstra wrote:
> On Mon, Apr 08, 2019 at 09:12:28AM +0200, Thomas-Mich Richter wrote:
>>> Does the below cure things? It's not exactly pretty, but it could just
>>> do the trick.
>>>
>>> ---
>>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>>> index dfc4bab0b02b..d496e6911442 100644
>>> --- a/kernel/events/core.c
>>> +++ b/kernel/events/core.c
>>> @@ -2009,8 +2009,8 @@ event_sched_out(struct perf_event *event,
>>> event->pmu->del(event, 0);
>>> event->oncpu = -1;
>>>
>>> - if (event->pending_disable) {
>>> - event->pending_disable = 0;
>>> + if (event->pending_disable == smp_processor_id()) {
>>> + event->pending_disable = -1;
>>> state = PERF_EVENT_STATE_OFF;
>>> }
>>> perf_event_set_state(event, state);
>>> @@ -2198,7 +2198,7 @@ EXPORT_SYMBOL_GPL(perf_event_disable);
>>>
>>> void perf_event_disable_inatomic(struct perf_event *event)
>>> {
>>> - event->pending_disable = 1;
>>> + event->pending_disable = smp_processor_id();
>>> irq_work_queue(&event->pending);
>>> }
>>>
>>> @@ -5822,8 +5822,8 @@ static void perf_pending_event(struct irq_work *entry)
>>> * and we won't recurse 'further'.
>>> */
>>>
>>> - if (event->pending_disable) {
>>> - event->pending_disable = 0;
>>> + if (event->pending_disable == smp_processor_id()) {
>>> + event->pending_disable = -1;
>>> perf_event_disable_local(event);
>>> }
>>>
>>> @@ -10236,6 +10236,7 @@ perf_event_alloc(struct perf_event_attr *attr, int cpu,
>>>
>>>
>>> init_waitqueue_head(&event->waitq);
>>> + event->pending_disable = -1;
>>> init_irq_work(&event->pending, perf_pending_event);
>>>
>>> mutex_init(&event->mmap_mutex);
>>>
>>
>> Peter,
>>
>> very good news, your fix ran over the weekend without any hit!!!
>>
>> Thanks very much for your help. Do you submit this patch to the kernel mailing list?
>
> Most excellent, let me go write a Changelog.
>
> Could I convince you to implement arch_irq_work_raise() for s390?
>
Yes, I am convinced, however I need to discuss this with the s390 maintainers
Martin Schwidesfky and Heiko Carstens first.
--
Thomas Richter, Dept 3252, IBM s390 Linux Development, Boeblingen, Germany
--
Vorsitzender des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294
next prev parent reply other threads:[~2019-04-08 8:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 9:47 WARN_ON_ONCE() hit at kernel/events/core.c:330 Thomas-Mich Richter
2019-04-03 10:41 ` Peter Zijlstra
2019-04-03 11:26 ` Thomas-Mich Richter
2019-04-04 9:15 ` Thomas-Mich Richter
2019-04-04 11:09 ` Peter Zijlstra
2019-04-04 12:02 ` Peter Zijlstra
2019-04-04 12:13 ` Peter Zijlstra
2019-04-04 13:03 ` Peter Zijlstra
2019-04-04 13:21 ` Thomas-Mich Richter
2019-04-05 10:18 ` Thomas-Mich Richter
2019-04-05 11:46 ` Peter Zijlstra
2019-04-08 7:12 ` Thomas-Mich Richter
2019-04-08 8:22 ` Peter Zijlstra
2019-04-08 8:47 ` Thomas-Mich Richter [this message]
2019-04-08 9:50 ` Peter Zijlstra
2019-04-08 13:28 ` Thomas-Mich Richter
2019-04-09 6:07 ` Thomas-Mich Richter
2019-04-09 8:29 ` Peter Zijlstra
2019-04-09 8:53 ` Mark Rutland
2019-04-10 13:51 ` Thomas-Mich Richter
2019-04-10 14:33 ` Peter Zijlstra
2019-04-11 12:06 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ef774b-aa6a-e5ea-6eeb-2457d404d3c7@linux.ibm.com \
--to=tmricht@linux.ibm.com \
--cc=acme@redhat.com \
--cc=brueckner@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).