From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Christoph Hellwig <hch@infradead.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Russell Currey <ruscur@russell.cc>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] powerpc/mm: Implement STRICT_MODULE_RWX
Date: Wed, 15 May 2019 08:44:50 +0200 [thread overview]
Message-ID: <04044ae8-1cd8-108b-f436-76c606cb3aea@c-s.fr> (raw)
In-Reply-To: <20190515064205.GB15778@infradead.org>
Le 15/05/2019 à 08:42, Christoph Hellwig a écrit :
>> +static int change_page_ro(pte_t *ptep, pgtable_t token, unsigned long addr, void *data)
>
> There are a couple way too long lines like this in the patch.
>
powerpc arch accepts 90 chars per line, see arch/powerpc/tools/checkpatch.pl
Christophe
next prev parent reply other threads:[~2019-05-15 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 6:20 [RFC PATCH] powerpc/mm: Implement STRICT_MODULE_RWX Christophe Leroy
2019-05-15 6:42 ` Christoph Hellwig
2019-05-15 6:44 ` Christophe Leroy [this message]
2019-05-16 0:51 ` Russell Currey
2019-05-21 4:33 ` Russell Currey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04044ae8-1cd8-108b-f436-76c606cb3aea@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=benh@kernel.crashing.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).