Re: [PATCH 0/3] Enable JPEG Encoder on RK3566/RK3568

From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Michael Grzeschik <mgr@pengutronix.de>,
	Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
Cc: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Heiko Stuebner <heiko@sntech.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Geis <pgwipeout@gmail.com>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Liang Chen <cl@rock-chips.com>,
	linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
	Kever Yang <kever.yang@rock-chips.com>,
	Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Subject: Re: [PATCH 0/3] Enable JPEG Encoder on RK3566/RK3568
Date: Mon, 02 May 2022 08:20:50 -0400	[thread overview]
Message-ID: <0414bb0816eef95961fe47de96f97f925d29228f.camel@ndufresne.ca> (raw)
In-Reply-To: <20220429232047.GG7671@pengutronix.de>

Hi Michael,

Le samedi 30 avril 2022 à 01:20 +0200, Michael Grzeschik a écrit :
> Since the RK3568 seems to get more and more of attention at the moment
> I would like to ask if somebody is planning to write support the RKVENC
> in mainline. That is the VEPU540 core refered to in the RK3568 TRM.
> 
> I would start with that in the next weeks, taking the bootlin H1 support
> as an reference to handle the request_api for the encoder part. Which is
> currently completely untouched in mainline AFAIK.

I'm very happy to ear you'd be interest in helping with this. I'm adding Andrzej
in CC, as he started some base work using VP8 encoder on RK3399 (same HW found
on other RK SoC) to make this possible. Note that these are a new type of
encoders and a specification is needed to ensure they all have a coherent work-
flow. The first step was obviously to have working prototype, Bootlin started
with H264 (but never posted anything on the mailing list). I'm under the
impression they have abandoned it. Andrzej have decided to use VP8 as it is
simpler. The prototype should help understand the basic flow of an encoder and
produce a specification for this.

From there, the "easy" part is to make per codec controls, to configure the
encoder. Demonstrating fixed QP, this is about were I believe Bootlin stopped.
And I personally believe some OSS userland (not just tests) that can handle
multiple reference, perhaps more advance GOP pattern and some basic rate control
would help build confidence in the uAPI. Let us know how we can help, we should
avoid doing the same thing, as this is already quite a large project that can
easily take over a year to become mainline ready.

regards,
Nicolas

> 
> Regards,
> Michael
> 