From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61032C433E2 for ; Tue, 15 Sep 2020 05:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F28FC214F1 for ; Tue, 15 Sep 2020 05:04:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="Iwj5XWIy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726122AbgIOFEO (ORCPT ); Tue, 15 Sep 2020 01:04:14 -0400 Received: from linux.microsoft.com ([13.77.154.182]:38718 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726046AbgIOFEN (ORCPT ); Tue, 15 Sep 2020 01:04:13 -0400 Received: from [192.168.0.121] (unknown [209.134.121.133]) by linux.microsoft.com (Postfix) with ESMTPSA id 45C3F209F317; Mon, 14 Sep 2020 22:04:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 45C3F209F317 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1600146252; bh=npcy577ZxUqCs2+tnngCijE6kMnP6yWhvgdFcTGoUoU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Iwj5XWIyffOpY1YLj6C7ibWbSJotcOLYCjz1epzoHcGF3bhatzP/yCOosq6gMdzXS ocQ6CphCNubdvpOiD7NHRSREo7biPUWo0GGuXeyXy9G7fXpV4R7Z1mhH1HXMAIJZub qqg1sVG5btovd/VYQvLSHpzVfcDIxjgs6Hkcn8mc= Subject: Re: [[PATCH]] mm: khugepaged: recalculate min_free_kbytes after memory hotplug as expected by khugepaged To: "Kirill A. Shutemov" Cc: Andrew Morton , Oleg Nesterov , Song Liu , Andrea Arcangeli , Pavel Tatashin , Allen Pais , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <1599770859-14826-1-git-send-email-vijayb@linux.microsoft.com> <20200910220145.5j7iogqulmvg5vr6@black.fi.intel.com> From: Vijay Balakrishna Message-ID: <041b4c73-42b0-5cb1-716f-0a0d466fcdf0@linux.microsoft.com> Date: Mon, 14 Sep 2020 22:04:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200910220145.5j7iogqulmvg5vr6@black.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/10/2020 3:01 PM, Kirill A. Shutemov wrote: > On Thu, Sep 10, 2020 at 01:47:39PM -0700, Vijay Balakrishna wrote: >> When memory is hotplug added or removed the min_free_kbytes must be >> recalculated based on what is expected by khugepaged. Currently >> after hotplug, min_free_kbytes will be set to a lower default and higher >> default set when THP enabled is lost. This leaves the system with small >> min_free_kbytes which isn't suitable for systems especially with network >> intensive loads. Typical failure symptoms include HW WATCHDOG reset, >> soft lockup hang notices, NETDEVICE WATCHDOG timeouts, and OOM process >> kills. >> >> Fixes: f000565adb77 ("thp: set recommended min free kbytes") >> >> Signed-off-by: Vijay Balakrishna >> Cc: stable@vger.kernel.org > > NAK. It would override min_free_kbytes set by user. Hi Kirill, To fix the issue you raised I just submitted https://lore.kernel.org/lkml/1600145748-26518-1-git-send-email-vijayb@linux.microsoft.com/ Thanks, Vijay >