linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drm: unbreak the DRM menu, broken by DRM_EXPORT_FOR_TESTS
@ 2020-03-06  1:26 Randy Dunlap
  2020-03-06 11:04 ` Chris Wilson
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2020-03-06  1:26 UTC (permalink / raw)
  To: LKML, dri-devel, Dave Airlie, Chris Wilson, Daniel Vetter

From: Randy Dunlap <rdunlap@infradead.org>

Unbreak the DRM menu. This Kconfig symbol does not depend on DRM,
so the menu is broken at that point.

Move the symbol to a location in the Kconfig file so that it does
not break the dependency continuity.

Fixes: 6349120ddcbf ("drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
---
 drivers/gpu/drm/Kconfig |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- linux-next-20200305.orig/drivers/gpu/drm/Kconfig
+++ linux-next-20200305/drivers/gpu/drm/Kconfig
@@ -54,9 +54,6 @@ config DRM_DEBUG_MM
 
 	  If in doubt, say "N".
 
-config DRM_EXPORT_FOR_TESTS
-	bool
-
 config DRM_DEBUG_SELFTEST
 	tristate "kselftests for DRM"
 	depends on DRM
@@ -470,6 +467,9 @@ config DRM_SAVAGE
 
 endif # DRM_LEGACY
 
+config DRM_EXPORT_FOR_TESTS
+	bool
+
 # Separate option because drm_panel_orientation_quirks.c is shared with fbdev
 config DRM_PANEL_ORIENTATION_QUIRKS
 	tristate


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] drm: unbreak the DRM menu, broken by DRM_EXPORT_FOR_TESTS
  2020-03-06  1:26 [PATCH] drm: unbreak the DRM menu, broken by DRM_EXPORT_FOR_TESTS Randy Dunlap
@ 2020-03-06 11:04 ` Chris Wilson
  0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2020-03-06 11:04 UTC (permalink / raw)
  To: Daniel Vetter, Dave Airlie, LKML, Randy Dunlap, dri-devel

Quoting Randy Dunlap (2020-03-06 01:26:10)
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Unbreak the DRM menu. This Kconfig symbol does not depend on DRM,
> so the menu is broken at that point.
> 
> Move the symbol to a location in the Kconfig file so that it does
> not break the dependency continuity.

I suspect it was me, thanks for fixing it!
 
> Fixes: 6349120ddcbf ("drm: Move EXPORT_SYMBOL_FOR_TESTS_ONLY under a separate Kconfig")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-03-06 11:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-06  1:26 [PATCH] drm: unbreak the DRM menu, broken by DRM_EXPORT_FOR_TESTS Randy Dunlap
2020-03-06 11:04 ` Chris Wilson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).