From: Dan Murphy <dmurphy@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: <robh+dt@kernel.org>, <jacek.anaszewski@gmail.com>,
<pavel@ucw.cz>, <lee.jones@linaro.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>, Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver
Date: Mon, 25 Mar 2019 11:01:18 -0500 [thread overview]
Message-ID: <044f67e7-e196-a5b9-728b-a7c5f283f56f@ti.com> (raw)
In-Reply-To: <20190325145444.GK19425@atomide.com>
On 3/25/19 9:54 AM, Tony Lindgren wrote:
> * Dan Murphy <dmurphy@ti.com> [190325 12:36]:
>> On 3/22/19 5:16 PM, Tony Lindgren wrote:
>>> I can control the backlight brightness just fine via /sys, and
>>> backlight shows up as the trigger in /sys/class/leds/lm3532:backlight,
>>> but /sys/class/backlight is empty and looks like drm can't find it.
>>>
>>> Do I need to enable some additional driver(s) to get this to work
>>> with the drm driver?
>>>
>>
>> Can you dump or point to the defconfig?
>
> This is just with the omap2plus_defconfig as in the droid4-pending-v5.0
> test branch below [0]. That branch has Sebastian's drm patches. The
> branch also has the older ti-lmu patches that I reverted for testing
> before applying your new series and enabling it in .config.
>
> The drm driver (drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c) just
> does:
>
> backlight = of_parse_phandle(node, "backlight", 0);
> ...
>
> That should still work the same, right?
Yes it should still work the same.
I did not change the node name.
So the DRM driver should find the node.
Dan
>
> Regards,
>
> Tony
>
>
> [0] https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/?h=droid4-pending-v5.0
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2019-03-25 16:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 14:28 [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-21 14:28 ` [PATCH 2/4] ARM: dts: omap4-droid4: Update backlight dt properties Dan Murphy
2019-04-04 0:03 ` Tony Lindgren
2019-04-04 20:12 ` Jacek Anaszewski
2019-04-04 22:00 ` Tony Lindgren
2019-04-07 18:31 ` Jacek Anaszewski
2019-03-21 14:28 ` [PATCH 3/4] mfd: ti-lmu: Remove LM3532 backlight driver references Dan Murphy
2019-03-23 16:47 ` Jacek Anaszewski
2019-03-25 7:53 ` Lee Jones
2019-03-25 21:11 ` Jacek Anaszewski
2019-04-03 7:57 ` Lee Jones
2019-04-03 17:45 ` Jacek Anaszewski
2019-04-04 2:44 ` Lee Jones
2019-04-04 0:04 ` Tony Lindgren
2019-03-21 14:28 ` [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-22 22:16 ` Tony Lindgren
2019-03-25 12:35 ` Dan Murphy
2019-03-25 14:54 ` Tony Lindgren
2019-03-25 16:01 ` Dan Murphy [this message]
2019-03-28 21:04 ` Sebastian Reichel
2019-04-03 20:06 ` Tony Lindgren
2019-04-03 23:55 ` Tony Lindgren
2019-04-04 0:09 ` Tony Lindgren
2019-04-04 18:48 ` Jacek Anaszewski
2019-04-04 19:23 ` Dan Murphy
2019-03-21 14:30 ` [PATCH 1/4] dt: lm3532: Add lm3532 dt doc and update ti_lmu doc Dan Murphy
2019-03-25 7:54 ` Lee Jones
2019-04-04 0:04 ` Tony Lindgren
2019-04-07 19:11 ` Jacek Anaszewski
-- strict thread matches above, loose matches on Subject: below --
2019-03-07 22:09 Dan Murphy
2019-03-07 22:09 ` [PATCH 4/4] leds: lm3532: Introduce the lm3532 LED driver Dan Murphy
2019-03-08 13:28 ` Dan Murphy
2019-03-10 19:49 ` Jacek Anaszewski
2019-03-11 11:36 ` Dan Murphy
2019-03-11 17:22 ` Jacek Anaszewski
2019-03-11 17:24 ` Dan Murphy
2019-03-11 17:30 ` Joe Perches
2019-03-11 17:47 ` Dan Murphy
2019-03-13 15:49 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=044f67e7-e196-a5b9-728b-a7c5f283f56f@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).