From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v11 09/15] perf stat: factor out event handling loop into dispatch_events()
Date: Tue, 14 Jul 2020 12:08:44 +0300 [thread overview]
Message-ID: <04567b7e-2216-4546-b5f8-9af7cb0c0d1b@linux.intel.com> (raw)
In-Reply-To: <037d737f-0ada-a9f0-9686-f7521ca6fbc3@linux.intel.com>
Consolidate event dispatching loops for fork, attach and system
wide monitoring use cases into common dispatch_events() function.
Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
---
tools/perf/builtin-stat.c | 36 ++++++++++++++++++++++++------------
1 file changed, 24 insertions(+), 12 deletions(-)
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 91f31518948e..a5a0f4841003 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -550,6 +550,27 @@ static bool is_target_alive(struct target *_target,
return false;
}
+static int dispatch_events(bool forks, int timeout, int interval, int *times, struct timespec *ts)
+{
+ int child_exited = 0, status = 0;
+
+ while (!done) {
+ if (forks)
+ child_exited = waitpid(child_pid, &status, WNOHANG);
+ else
+ child_exited = !is_target_alive(&target, evsel_list->core.threads) ? 1 : 0;
+
+ if (child_exited)
+ break;
+
+ nanosleep(ts, NULL);
+ if (timeout || handle_interval(interval, times))
+ break;
+ }
+
+ return status;
+}
+
enum counter_recovery {
COUNTER_SKIP,
COUNTER_RETRY,
@@ -789,13 +810,8 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
perf_evlist__start_workload(evsel_list);
enable_counters();
- if (interval || timeout) {
- while (!waitpid(child_pid, &status, WNOHANG)) {
- nanosleep(&ts, NULL);
- if (timeout || handle_interval(interval, ×))
- break;
- }
- }
+ if (interval || timeout)
+ status = dispatch_events(forks, timeout, interval, ×, &ts);
if (child_pid != -1) {
if (timeout)
kill(child_pid, SIGTERM);
@@ -812,11 +828,7 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
psignal(WTERMSIG(status), argv[0]);
} else {
enable_counters();
- while (!done && is_target_alive(&target, evsel_list->core.threads)) {
- nanosleep(&ts, NULL);
- if (timeout || handle_interval(interval, ×))
- break;
- }
+ status = dispatch_events(forks, timeout, interval, ×, &ts);
}
disable_counters();
--
2.24.1
next prev parent reply other threads:[~2020-07-14 9:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 8:37 [PATCH v11 00/15] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-07-14 9:03 ` [PATCH v11 01/15] tools/libperf: avoid internal moving of fdarray fds Alexey Budankov
2020-07-14 9:03 ` [PATCH v11 02/15] tools/libperf: add flags to fdarray fds objects Alexey Budankov
2020-07-14 9:04 ` [PATCH v11 03/15] tools/libperf: avoid counting of nonfilterable fdarray fds Alexey Budankov
2020-07-16 8:34 ` [tools/libperf] 8edd7f4133: perf-sanity-tests.Filter_fds_with_revents_mask_in_a_fdarray.fail kernel test robot
2020-07-16 15:20 ` Arnaldo Carvalho de Melo
2020-07-16 16:09 ` Alexey Budankov
2020-07-16 16:50 ` Arnaldo Carvalho de Melo
2020-07-14 9:05 ` [PATCH v11 04/15] perf evlist: introduce control file descriptors Alexey Budankov
2020-07-14 9:05 ` [PATCH v11 05/15] perf evlist: implement control command handling functions Alexey Budankov
2020-07-14 9:06 ` [PATCH v11 06/15] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-07-14 9:07 ` [PATCH v11 07/15] perf stat: move target check to loop control statement Alexey Budankov
2020-07-14 9:07 ` [PATCH v11 08/15] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-07-14 9:08 ` Alexey Budankov [this message]
2020-07-14 9:09 ` [PATCH v11 10/15] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-07-14 9:09 ` [PATCH v11 11/15] perf stat: implement control commands handling Alexey Budankov
2020-07-14 9:10 ` [PATCH v11 12/15] perf stat: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-07-14 9:11 ` [PATCH v11 13/15] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-07-14 9:11 ` [PATCH v11 14/15] perf record: implement control commands handling Alexey Budankov
2020-07-14 9:12 ` [PATCH v11 15/15] perf record: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-07-14 12:05 ` [PATCH v11 00/15] perf: support enable and disable commands in stat and record modes Namhyung Kim
2020-07-14 15:16 ` Arnaldo Carvalho de Melo
2020-07-14 15:53 ` Alexey Budankov
2020-07-14 16:15 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04567b7e-2216-4546-b5f8-9af7cb0c0d1b@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).