From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yz.Wu@mediatek.com,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Seiya Wang <seiya.wang@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Andrew-CT Chen <andrew-ct.chen@mediatek.com>,
Tzung-Bi Shih <tzungbi@google.com>
Subject: Re: [PATCH v5 2/2] arm64: dts: mt8192: add eFuse support for MT8192 SoC
Date: Fri, 3 Sep 2021 12:06:13 +0200 [thread overview]
Message-ID: <048c7ac6-e91b-14ce-17e7-a291df2763b4@gmail.com> (raw)
In-Reply-To: <1618384669-30070-3-git-send-email-Yz.Wu@mediatek.com>
On 14/04/2021 09:17, Yz.Wu@mediatek.com wrote:
> From: Ryan Wu <Yz.Wu@mediatek.com>
>
> Add eFuse node to read Mediatek eFuse
>
> Signed-off-by: Ryan Wu <Yz.Wu@mediatek.com>
> ---
> This patch dependents on "arm64: dts: Add Mediatek SoC MT8192 and evaluation board dts and Makefile"[1]
>
> mt8192.dtsi file is needed for this patch.
> Please also accept this patch together with [1].
>
> [1]http://lists.infradead.org/pipermail/linux-mediatek/2020-November/019378.html
> ---
> arch/arm64/boot/dts/mediatek/mt8192.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> index 9757138..4d4e4de 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8192.dtsi
> @@ -436,6 +436,11 @@
> status = "disable";
> };
>
> + efuse: efuse@11c10000 {
> + compatible = "mediatek,mt8192-efuse",
> + "mediatek,efuse";
Please fix identation.
Binding description mandates a reg property, please help to make the patch
better by adding that property.
Thanks a lot,
Matthias
> + };
> +
> i2c3: i2c3@11cb0000 {
> compatible = "mediatek,mt8192-i2c";
> reg = <0 0x11cb0000 0 0x1000>,
>
prev parent reply other threads:[~2021-09-03 10:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 7:17 [PATCH v5 0/2] Add Mediatek Efuse Device Node for MT8192 SoC Yz.Wu
2021-04-14 7:17 ` [PATCH v5 1/2] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC Yz.Wu
2021-04-14 7:17 ` [PATCH v5 2/2] arm64: dts: mt8192: add eFuse support for MT8192 SoC Yz.Wu
2021-09-03 10:06 ` Matthias Brugger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=048c7ac6-e91b-14ce-17e7-a291df2763b4@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Yz.Wu@mediatek.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=seiya.wang@mediatek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).