From: Edwin Zimmerman <edwin@211mainstreet.net>
To: Randy Dunlap <rdunlap@infradead.org>,
x86@kernel.org, Matthew Garrett <mjg59@google.com>,
linux-kernel@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Chao Fan <fanc.fnst@cn.fujitsu.com>,
Junichi Nomura <j-nomura@ce.jp.nec.com>,
Erik Schmauss <erik.schmauss@intel.com>,
Zhenzhong Duan <zhenzhong.duan@oracle.com>,
Josh Boyer <jwboyer@redhat.com>
Subject: Re: [PATCH] x86/boot: fix cast to pointer compiler warning
Date: Wed, 8 Jan 2020 01:30:14 -0500 [thread overview]
Message-ID: <049a6ca0-5f0d-0187-85d4-6d5f1e78af55@211mainstreet.net> (raw)
In-Reply-To: <0be4cdcc-a1f8-36a9-69f2-bac02c8f9a9f@infradead.org>
On 1/7/2020 8:18 PM, Randy Dunlap wrote:
> On 1/7/20 9:38 PM, Edwin Zimmerman wrote:
>> Fix cast-to-pointer compiler warning
>>
>> arch/x86/boot/compressed/acpi.c: In function ‘get_acpi_srat_table’:
>> arch/x86/boot/compressed/acpi.c:316:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>> rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
>> ^
>> Fixes: 41fa1ee9c6d6 ("acpi: Ignore acpi_rsdp kernel param when the kernel has been locked down")
>> Signed-off-by: Edwin Zimmerman <edwin@211mainstreet.net>
>> ---
>> arch/x86/boot/compressed/acpi.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/boot/compressed/acpi.c b/arch/x86/boot/compressed/acpi.c
>> index 25019d42ae93..5d2568066d58 100644
>> --- a/arch/x86/boot/compressed/acpi.c
>> +++ b/arch/x86/boot/compressed/acpi.c
>> @@ -313,7 +313,7 @@ static unsigned long get_acpi_srat_table(void)
>> * stash this in boot params because the kernel itself may have
>> * different ideas about whether to trust a command-line parameter.
>> */
>> - rsdp = (struct acpi_table_rsdp *)get_cmdline_acpi_rsdp();
>> + rsdp = (struct acpi_table_rsdp *)(long)get_cmdline_acpi_rsdp();
>> if (!rsdp)
>> rsdp = (struct acpi_table_rsdp *)(long)
>>
> Lots of whitespace damage. Probably your email client or some
> intermediary.
Email client, sorry. Will resend.
next prev parent reply other threads:[~2020-01-08 1:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 5:38 [PATCH] x86/boot: fix cast to pointer compiler warning Edwin Zimmerman
2020-01-08 1:18 ` Randy Dunlap
2020-01-08 6:30 ` Edwin Zimmerman [this message]
2020-01-08 6:37 Edwin Zimmerman
2020-01-09 22:24 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=049a6ca0-5f0d-0187-85d4-6d5f1e78af55@211mainstreet.net \
--to=edwin@211mainstreet.net \
--cc=bp@alien8.de \
--cc=erik.schmauss@intel.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=jwboyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mjg59@google.com \
--cc=rdunlap@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhenzhong.duan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).