From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF981C4320A for ; Wed, 1 Sep 2021 13:09:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B6AD460231 for ; Wed, 1 Sep 2021 13:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344166AbhIANKN (ORCPT ); Wed, 1 Sep 2021 09:10:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:33472 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343918AbhIANKM (ORCPT ); Wed, 1 Sep 2021 09:10:12 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AB1E961074; Wed, 1 Sep 2021 13:09:15 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mLPzN-008RSi-NI; Wed, 01 Sep 2021 14:09:13 +0100 MIME-Version: 1.0 Date: Wed, 01 Sep 2021 14:09:13 +0100 From: Marc Zyngier To: Barry Song <21cnbao@gmail.com> Cc: kernel test robot , 0day robot , Jesse Brandeburg , Tony Nguyen , Barry Song , LKML , lkp@lists.01.org, Bjorn Helgaas , Thomas Gleixner , Jonathan.Cameron@huawei.com, bilbao@vt.edu, Jonathan Corbet , Greg Kroah-Hartman , leon@kernel.org, linux-pci@vger.kernel.org, Linuxarm , luzmaximilian@gmail.com, mchehab+huawei@kernel.org, schnelle@linux.ibm.com, intel-wired-lan@lists.osuosl.org Subject: Re: [PCI/MSI] a4fc4cf388: dmesg.genirq:Flags_mismatch_irq##(mei_me)vs.#(xhci_hcd) In-Reply-To: References: <20210825102636.52757-4-21cnbao@gmail.com> <20210829145552.GA11556@xsang-OptiPlex-9020> <1132a536516f15ab6b338ab868ec3705@kernel.org> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <04a0587a5d7854494e9ccfd1fdf39951@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: 21cnbao@gmail.com, oliver.sang@intel.com, lkp@intel.com, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, song.bao.hua@hisilicon.com, linux-kernel@vger.kernel.org, lkp@lists.01.org, bhelgaas@google.com, tglx@linutronix.de, Jonathan.Cameron@huawei.com, bilbao@vt.edu, corbet@lwn.net, gregkh@linuxfoundation.org, leon@kernel.org, linux-pci@vger.kernel.org, linuxarm@huawei.com, luzmaximilian@gmail.com, mchehab+huawei@kernel.org, schnelle@linux.ibm.com, intel-wired-lan@lists.osuosl.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-08-31 22:36, Barry Song wrote: > On Tue, Aug 31, 2021 at 8:08 PM Marc Zyngier wrote: >> >> On 2021-08-31 02:21, Barry Song wrote: >> > On Mon, Aug 30, 2021 at 2:38 AM kernel test robot >> > wrote: >> >> >> >> >> >> >> >> Greeting, >> >> >> >> FYI, we noticed the following commit (built with gcc-9): >> >> >> >> commit: a4fc4cf388319ea957ffbdab5073bdd267de9082 ("[PATCH v3 3/3] >> >> PCI/MSI: remove msi_attrib.default_irq in msi_desc") >> >> url: >> >> https://github.com/0day-ci/linux/commits/Barry-Song/PCI-MSI-Clarify-the-IRQ-sysfs-ABI-for-PCI-devices/20210825-183018 >> >> base: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git >> >> 6e764bcd1cf72a2846c0e53d3975a09b242c04c9 >> >> >> >> in testcase: kernel-selftests >> >> version: kernel-selftests-x86_64-ebaa603b-1_20210825 >> >> with following parameters: >> >> >> >> group: pidfd >> >> ucode: 0xe2 >> >> >> >> test-description: The kernel contains a set of "self tests" under the >> >> tools/testing/selftests/ directory. These are intended to be small >> >> unit tests to exercise individual code paths in the kernel. >> >> test-url: https://www.kernel.org/doc/Documentation/kselftest.txt >> >> >> >> >> >> on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz >> >> with 32G memory >> >> >> >> caused below changes (please refer to attached dmesg/kmsg for entire >> >> log/backtrace): >> >> >> >> >> >> >> >> If you fix the issue, kindly add following tag >> >> Reported-by: kernel test robot >> >> >> >> >> >> >> >> [ 179.602028][ T34] genirq: Flags mismatch irq 16. 00002000 >> >> (mei_me) vs. 00000000 (xhci_hcd) >> >> [ 179.614073][ T34] CPU: 2 PID: 34 Comm: kworker/u8:2 Not tainted >> >> 5.14.0-rc7-00014-ga4fc4cf38831 #1 >> >> [ 179.623225][ T34] Hardware name: Dell Inc. OptiPlex 7040/0Y7WYT, >> >> BIOS 1.8.1 12/05/2017 >> >> [ 179.631432][ T34] Workqueue: events_unbound async_run_entry_fn >> >> [ 179.637543][ T34] Call Trace: >> >> [ 179.640789][ T34] dump_stack_lvl+0x45/0x59 >> >> [ 179.645253][ T34] __setup_irq.cold+0x50/0xd4 >> >> [ 179.649893][ T34] ? mei_me_pg_exit_sync+0x480/0x480 [mei_me] >> >> [ 179.655923][ T34] request_threaded_irq+0x10c/0x180 >> >> [ 179.661073][ T34] ? mei_me_irq_quick_handler+0x240/0x240 >> >> [mei_me] >> >> [ 179.667528][ T34] mei_me_probe+0x131/0x300 [mei_me] >> >> [ 179.672767][ T34] local_pci_probe+0x42/0x80 >> >> [ 179.677313][ T34] pci_device_probe+0x107/0x1c0 >> >> [ 179.682118][ T34] really_probe+0xb6/0x380 >> >> [ 179.687094][ T34] __driver_probe_device+0xfe/0x180 >> >> [ 179.692242][ T34] driver_probe_device+0x1e/0xc0 >> >> [ 179.697133][ T34] __driver_attach_async_helper+0x2b/0x80 >> >> [ 179.702802][ T34] async_run_entry_fn+0x30/0x140 >> >> [ 179.707693][ T34] process_one_work+0x274/0x5c0 >> >> [ 179.712503][ T34] worker_thread+0x50/0x3c0 >> >> [ 179.716959][ T34] ? process_one_work+0x5c0/0x5c0 >> >> [ 179.721936][ T34] kthread+0x14f/0x180 >> >> [ 179.725958][ T34] ? set_kthread_struct+0x40/0x40 >> >> [ 179.730935][ T34] ret_from_fork+0x22/0x30 >> >> [ 179.735699][ T34] mei_me 0000:00:16.0: request_threaded_irq >> >> failure. irq = 16 >> >> [ 179.743125][ T34] mei_me 0000:00:16.0: initialization failed. >> >> [ 179.749399][ T34] mei_me: probe of 0000:00:16.0 failed with error >> >> -16 >> >> >> >> >> > >> > it seems there is a direct reference to pdev->irq. >> > Hi Oliver, would you try if the below patch can fix the problem: >> > >> > diff --git a/drivers/misc/mei/pci-me.c b/drivers/misc/mei/pci-me.c >> > index c3393b383e59..a45a2d4257a6 100644 >> > --- a/drivers/misc/mei/pci-me.c >> > +++ b/drivers/misc/mei/pci-me.c >> > @@ -216,7 +216,7 @@ static int mei_me_probe(struct pci_dev *pdev, >> > const struct pci_device_id *ent) >> > >> > pci_enable_msi(pdev); >> > >> > - hw->irq = pdev->irq; >> > + hw->irq = pci_irq_vector(pdev, 0); >> > >> > /* request and enable interrupt */ >> > irqflags = pci_dev_msi_enabled(pdev) ? IRQF_ONESHOT : >> > IRQF_SHARED; >> > >> >> Ah! one victim, 3000 to go! :D >> > > yep. > >> That's exactly the kind of stuff I was mentioning when we >> discussed this patch. Exposing the MSI vector as the INTx >> IRQ has led to all sorts of broken drivers. > > I guess drivers should depend on int pci_irq_vector(struct pci_dev > *dev, unsigned int nr) > rather than hardcodely use pdev->irq. > > pci_irq_vector() supports all cases(intx, msi, msi-x) Yes, that'd be a sensible approach. Feels like a job for a coccinelle script! M. -- Jazz is not dead. It just smells funny...