From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499D1C433E0 for ; Tue, 7 Jul 2020 15:49:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 278942065D for ; Tue, 7 Jul 2020 15:49:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="MobMyrjR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729015AbgGGPtR (ORCPT ); Tue, 7 Jul 2020 11:49:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728288AbgGGPtO (ORCPT ); Tue, 7 Jul 2020 11:49:14 -0400 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5940CC061755 for ; Tue, 7 Jul 2020 08:49:14 -0700 (PDT) Received: by mail-wr1-x441.google.com with SMTP id o11so45740861wrv.9 for ; Tue, 07 Jul 2020 08:49:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=R/msZMHFZFhx7FtV1U4x6F/0CAVdjvMvgRT/NC78y40=; b=MobMyrjR9AJycEk2mi5Sq3uQIiCVRztqdkLHqoXq0Xx+JZ8KAISUiDRjhN6Yn5A+22 ou+UdEg2G1508GrcMLY5tP0WR6yXgF/Lq1rO2kitGdj7AYtMvcA1bNIXOLyMqhBFvtqB v0JWLpMJC9RF9i82bU6AnAS/QMK3zeBkaPqY7ZU9E64zNYFaCnQaeKapXxSZIZpre3dp /gyo2768jJfR+LmEezi+LOQng8QSzxQrX2Qap40V9sfiOCe4fR80Ml/kxi8aF8NNT88Z FdZdZKy++pzBg8IcMLZQnXm09IApuylDTWhDXD7+BCPQFDxa9uWVJdhTlXbcc0GHiQGQ xIcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=R/msZMHFZFhx7FtV1U4x6F/0CAVdjvMvgRT/NC78y40=; b=dgxpgD6TpChSuprQeaFemy4FfY5RK8gBftu5WU3ml+herSwEGalMhJwqD0d5Hq41U7 pShCD/FYCIqmWDJUotQbnJqMeb5ihXi3XvRRKi1tV1PrC4mx/ramdiOP3MGKz06KuZPv uLJYHIAEDXkpdKMj3w8H2pnU1NIJZJeZmub4VeYre7kQo2ycqdmGeqBYCCFjphEhu8ne GAXB0tyvg8gPyIHw8nlmPlRNiRopQ3csRxBMfF7JdeI3IxH/HqnmRNh73HJVYumMtM// uwlvLUOMLi6PqXHvWIHziqcsFImChJBARcwHJfwZLulwVoEr70wjbruQ4eV7dvMWQHGb V7Hg== X-Gm-Message-State: AOAM532uwek587EzKhE+DD57DjGE9iOc7IoIDLOHYbKzctfPYS+u3SWh +1JS4azYoF4SQ751ZIlaswx06w== X-Google-Smtp-Source: ABdhPJzB2lzxg02HvDyZykAOfBzZtzV6VPnCvusD+uRECHuBlKqXlNPf6GpDDuc2YVRPuhXxaJQK6g== X-Received: by 2002:a5d:4992:: with SMTP id r18mr51805915wrq.323.1594136952944; Tue, 07 Jul 2020 08:49:12 -0700 (PDT) Received: from ?IPv6:2a01:e34:ed2f:f020:b4ff:29eb:619e:318? ([2a01:e34:ed2f:f020:b4ff:29eb:619e:318]) by smtp.googlemail.com with ESMTPSA id i67sm1721005wma.12.2020.07.07.08.49.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2020 08:49:12 -0700 (PDT) Subject: Re: [PATCH] thermal: netlink: Fix compilation error when CONFIG_NET=n To: Randy Dunlap , rui.zhang@intel.com Cc: amit.kucheria@verdurent.com, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org References: <20200707090159.1018-1-daniel.lezcano@linaro.org> <66b4c589-48e0-8975-b3b1-79168e3ea5e4@infradead.org> From: Daniel Lezcano Message-ID: <04a6904d-9220-9045-6816-12cf84781f4d@linaro.org> Date: Tue, 7 Jul 2020 17:49:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <66b4c589-48e0-8975-b3b1-79168e3ea5e4@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2020 17:47, Randy Dunlap wrote: > On 7/7/20 2:01 AM, Daniel Lezcano wrote: >> When the network is not configured, the netlink are disabled on all >> the system. The thermal framework assumed the netlink are always >> opt-in. >> >> Fix this by adding a Kconfig option for the netlink notification, >> defaulting to yes and depending on CONFIG_NET. >> >> As the change implies multiple stubs and in order to not pollute the >> internal thermal header, the thermal_nelink.h has been added and >> included in the thermal_core.h, so this one regain some kind of >> clarity. >> >> Reported-by: Randy Dunlap >> Signed-off-by: Daniel Lezcano >> --- >> drivers/thermal/Kconfig | 10 ++++ >> drivers/thermal/Makefile | 5 +- >> drivers/thermal/thermal_core.h | 20 +------ >> drivers/thermal/thermal_netlink.h | 98 +++++++++++++++++++++++++++++++ >> 4 files changed, 114 insertions(+), 19 deletions(-) >> create mode 100644 drivers/thermal/thermal_netlink.h >> > > > Hm, now I get this: > > ../drivers/thermal/thermal_helpers.c: In function ‘thermal_cdev_set_cur_state’: > ../drivers/thermal/thermal_helpers.c:182:2: error: implicit declaration of function ‘thermal_notify_cdev_update’; did you mean ‘thermal_notify_cdev_delete’? [-Werror=implicit-function-declaration] > thermal_notify_cdev_update(cdev->id, target); > > > or should that call be to thermal_notify_cdev_state_update()? Ah right, the patch applies on top of the v4 which is not yet in linux-next, I'm waiting for the kernelci loop result. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog