From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38C6C4361B for ; Thu, 17 Dec 2020 23:59:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7830B23A54 for ; Thu, 17 Dec 2020 23:59:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732172AbgLQX7A (ORCPT ); Thu, 17 Dec 2020 18:59:00 -0500 Received: from smtprelay0247.hostedemail.com ([216.40.44.247]:43314 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732037AbgLQX7A (ORCPT ); Thu, 17 Dec 2020 18:59:00 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id 6BBEA181D337B; Thu, 17 Dec 2020 23:58:19 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: limit53_2f0fb3827438 X-Filterd-Recvd-Size: 1969 Received: from XPS-9350.home (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf10.hostedemail.com (Postfix) with ESMTPA; Thu, 17 Dec 2020 23:58:17 +0000 (UTC) Message-ID: <04c331f6bfce57c253cb86208ebd28f6363e04c0.camel@perches.com> Subject: Re: [PATCH] staging: most: video: fixed a parentheses coding style issue. From: Joe Perches To: Daniel West , gregkh@linuxfoundation.org Cc: hverkuil-cisco@xs4all.nl, mchehab+huawei@kernel.org, christian.gromm@microchip.com, masahiroy@kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 17 Dec 2020 15:58:16 -0800 In-Reply-To: <20201217234501.351725-1-daniel.west.dev@gmail.com> References: <20201217234501.351725-1-daniel.west.dev@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-12-17 at 15:45 -0800, Daniel West wrote: > Fixed a coding style issue. It may pass checkpatch without warning, but it's uncommon kernel coding style. > diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c [] > @@ -365,8 +365,8 @@ static const struct video_device comp_videodev_template = { >   > >  /**************************************************************************/ >   > > -static struct most_video_dev *get_comp_dev( > - struct most_interface *iface, int channel_idx) > +static struct most_video_dev *get_comp_dev > + (struct most_interface *iface, int channel_idx) This would be better using any of: (most common) static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx) or (less common) static struct most_video_dev * get_comp_dev(struct most_interface *iface, int channel_idx) or (> 80 columns) static struct most_video_dev *get_comp_dev(struct most_interface *iface, int channel_idx)