From: Tom Lendacky <thomas.lendacky@amd.com>
To: Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org
Cc: Andy Lutomirski <luto@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"H . Peter Anvin" <hpa@zytor.com>,
Tony Luck <tony.luck@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Andi Kleen <ak@linux.intel.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/4] x86/sev: Remove sev_enable_key usage in outs##bwl()/ins##bwl()
Date: Wed, 1 Dec 2021 13:32:18 -0600 [thread overview]
Message-ID: <04c63791-81f9-f938-eda8-1f03b2973b64@amd.com> (raw)
In-Reply-To: <20211116004528.2928887-2-sathyanarayanan.kuppuswamy@linux.intel.com>
On 11/15/21 6:45 PM, Kuppuswamy Sathyanarayanan wrote:
> String I/O instructions (INS/OUTS) can be used to move blocks of
> data between I/O ports and memory space. But emulation of these
> instructions is not supported in AMD SEV platform. Since these
> instructions are obsolete, hypervisors rarely emulate them. So to
> support the legacy usage, INS/OUTS are unrolled using IN/OUT
> instructions.
>
> Currently, this is implemented by adding a SEV specific static
> key check in outs##bwl()/ins##bwl() macros. Since TDX VM guests
> also need similar support, the implementation needs to be made
> generic using the cc_platform_has() call.
>
> In preparation for adding cc_platform_has() based support, as a
> first step remove the sev_enable_key usage and replace it with
> direct reference to "sev_status".
Probably makes sense to just go directly to the cc_platform_has() call
rather than introduce the usage of sev_status.
So maybe squash patches 1 and 2 into a single patch.
Thanks,
Tom
>
> Since this patch replaces the static key usage, it might lead to
> some performance gap.
>
> Suggested-by: Tom Lendacky <thomas.lendacky@amd.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> ---
> arch/x86/include/asm/io.h | 15 ++++++++-------
> arch/x86/mm/mem_encrypt.c | 11 +----------
> 2 files changed, 9 insertions(+), 17 deletions(-)
>
> diff --git a/arch/x86/include/asm/io.h b/arch/x86/include/asm/io.h
> index 5c6a4af0b911..69093a610630 100644
> --- a/arch/x86/include/asm/io.h
> +++ b/arch/x86/include/asm/io.h
> @@ -257,17 +257,18 @@ static inline void slow_down_io(void)
> #endif
>
> #ifdef CONFIG_AMD_MEM_ENCRYPT
> -#include <linux/jump_label.h>
>
> -extern struct static_key_false sev_enable_key;
> -static inline bool sev_key_active(void)
> +extern u64 sev_status;
> +
> +static inline bool is_sev_enabled(void)
> {
> - return static_branch_unlikely(&sev_enable_key);
> + return ((sev_status & MSR_AMD64_SEV_ENABLED) &&
> + !(sev_status & MSR_AMD64_SEV_ES_ENABLED));
> }
>
> #else /* !CONFIG_AMD_MEM_ENCRYPT */
>
> -static inline bool sev_key_active(void) { return false; }
> +static inline bool is_sev_enabled(void) { return false; }
>
> #endif /* CONFIG_AMD_MEM_ENCRYPT */
>
> @@ -301,7 +302,7 @@ static inline unsigned type in##bwl##_p(int port) \
> \
> static inline void outs##bwl(int port, const void *addr, unsigned long count) \
> { \
> - if (sev_key_active()) { \
> + if (is_sev_enabled()) { \
> unsigned type *value = (unsigned type *)addr; \
> while (count) { \
> out##bwl(*value, port); \
> @@ -317,7 +318,7 @@ static inline void outs##bwl(int port, const void *addr, unsigned long count) \
> \
> static inline void ins##bwl(int port, void *addr, unsigned long count) \
> { \
> - if (sev_key_active()) { \
> + if (is_sev_enabled()) { \
> unsigned type *value = (unsigned type *)addr; \
> while (count) { \
> *value = in##bwl(port); \
> diff --git a/arch/x86/mm/mem_encrypt.c b/arch/x86/mm/mem_encrypt.c
> index 35487305d8af..49e5dfc23785 100644
> --- a/arch/x86/mm/mem_encrypt.c
> +++ b/arch/x86/mm/mem_encrypt.c
> @@ -43,8 +43,7 @@ u64 sme_me_mask __section(".data") = 0;
> u64 sev_status __section(".data") = 0;
> u64 sev_check_data __section(".data") = 0;
> EXPORT_SYMBOL(sme_me_mask);
> -DEFINE_STATIC_KEY_FALSE(sev_enable_key);
> -EXPORT_SYMBOL_GPL(sev_enable_key);
> +EXPORT_SYMBOL_GPL(sev_status);
>
> /* Buffer used for early in-place encryption by BSP, no locking needed */
> static char sme_early_buffer[PAGE_SIZE] __initdata __aligned(PAGE_SIZE);
> @@ -499,14 +498,6 @@ void __init mem_encrypt_init(void)
> /* Call into SWIOTLB to update the SWIOTLB DMA buffers */
> swiotlb_update_mem_attributes();
>
> - /*
> - * With SEV, we need to unroll the rep string I/O instructions,
> - * but SEV-ES supports them through the #VC handler.
> - */
> - if (cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) &&
> - !cc_platform_has(CC_ATTR_GUEST_STATE_ENCRYPT))
> - static_branch_enable(&sev_enable_key);
> -
> print_mem_encrypt_feature_info();
> }
>
>
next prev parent reply other threads:[~2021-12-01 19:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 0:45 [PATCH v1 0/4] Share common features between AMD SEV / TDX guest Kuppuswamy Sathyanarayanan
2021-11-16 0:45 ` [PATCH v1 1/4] x86/sev: Remove sev_enable_key usage in outs##bwl()/ins##bwl() Kuppuswamy Sathyanarayanan
2021-12-01 19:32 ` Tom Lendacky [this message]
2021-11-16 0:45 ` [PATCH v1 2/4] x86/sev: Use CC_ATTR attribute to generalize string I/O unroll Kuppuswamy Sathyanarayanan
2021-11-16 0:45 ` [PATCH v1 3/4] x86/sev: Rename mem_encrypt.c to mem_encrypt_amd.c Kuppuswamy Sathyanarayanan
2021-11-16 0:45 ` [PATCH v1 4/4] x86: Move common memory encryption code to mem_encrypt.c Kuppuswamy Sathyanarayanan
2021-12-01 19:56 ` Tom Lendacky
2021-12-01 16:34 ` [PATCH v1 0/4] Share common features between AMD SEV / TDX guest Kirill A. Shutemov
2021-12-01 19:57 ` Tom Lendacky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04c63791-81f9-f938-eda8-1f03b2973b64@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=knsathya@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).