From: "Padmanabhan Rajanbabu" <p.rajanbabu@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
<lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <s.nawrocki@samsung.com>,
<perex@perex.cz>, <tiwai@suse.com>, <pankaj.dubey@samsung.com>,
<alim.akhtar@samsung.com>, <rcsekar@samsung.com>,
<aswani.reddy@samsung.com>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH v2 5/5] arm64: dts: fsd: Add sound card node for Tesla FSD
Date: Mon, 9 Jan 2023 09:35:33 +0530 [thread overview]
Message-ID: <051601d923df$a0e7b840$e2b728c0$@samsung.com> (raw)
In-Reply-To: <2c6950c9-3489-c2d4-2ca8-cb723195f75b@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 03 January 2023 04:43 PM
> To: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>;
> lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; s.nawrocki@samsung.com;
> perex@perex.cz; tiwai@suse.com; pankaj.dubey@samsung.com;
> alim.akhtar@samsung.com; rcsekar@samsung.com;
> aswani.reddy@samsung.com
> Cc: alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org
> Subject: Re: [PATCH v2 5/5] arm64: dts: fsd: Add sound card node for Tesla
> FSD
>
> On 03/01/2023 05:56, Padmanabhan Rajanbabu wrote:
> > Add device tree node support for sound card on Tesla FSD board
> >
> > Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
> > ---
> > arch/arm64/boot/dts/tesla/fsd-evb.dts | 37
> > +++++++++++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > index e2fd49774f15..ce726bddfb50 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> > @@ -29,6 +29,43 @@
> > device_type = "memory";
> > reg = <0x0 0x80000000 0x2 0x00000000>;
> > };
> > +
> > + sound {
> > + compatible = "simple-audio-card";
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + simple-audio-card,name = "FSD Audio Card";
> > + simple-audio-card,widgets =
> > + "Line", "Line Out",
>
> I don't think you need to break the line after '='.
Okay, will change the same in the next patch set.
>
> > + "Line", "Line In";
> > + simple-audio-card,routing =
> > + "Line Out", "LLOUT",
> > + "Line Out", "RLOUT",
> > + "MIC2L", "Line In",
> > + "MIC2R", "Line In";
> > +
> > + status = "okay";
>
> Why?
Okay, I understood that if there is no status entry, it is
treated as "okay". I'll update the same in the next
patch set.
>
> > +
> > + simple-audio-card,dai-link@0 {
> > + reg = <0>;
> > + format = "i2s";
> > + bitclock-master = <&tlv320aic3x>;
> > + frame-master = <&tlv320aic3x>;
> > +
> > + cpu0 {
>
> Does not look like you tested the DTS against bindings. Please run `make
> dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
> for instructions).
I did not encounter any error while running dtbs_check for fsd-evb.dts
This is the command I executed
make dtbs_check > output.txt 2>&1
dt-mk-schema --version: 2022.11
Please let me know if I'm missing anything here.
>
> > + sound-dai = <&i2s_0 0>;
> > + };
> > + cpu1 {
> > + sound-dai = <&i2s_0 1>;
> > + };
> > + codec {
> > + sound-dai = <&tlv320aic3x>;
> > + system-clock-frequency = <33000000>;
> > + };
>
> Best regards,
> Krzysztof
Thanks,
Padmanabhan R.
next prev parent reply other threads:[~2023-01-09 4:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230103045646epcas5p2a9c43bc3bd187ca69653239a0de73152@epcas5p2.samsung.com>
2023-01-03 4:56 ` [PATCH v2 0/5] ASoC: samsung: fsd: audio support for FSD SoC Padmanabhan Rajanbabu
[not found] ` <CGME20230103045651epcas5p417960d84f4aa934b0ae1a150ee5fee08@epcas5p4.samsung.com>
2023-01-03 4:56 ` [PATCH v2 1/5] ASoC: dt-bindings: Add FSD I2S controller bindings Padmanabhan Rajanbabu
2023-01-03 18:04 ` Mark Brown
2023-01-09 4:05 ` Padmanabhan Rajanbabu
[not found] ` <CGME20230103045655epcas5p1af06a83208190c471e8cd891ef4760f3@epcas5p1.samsung.com>
2023-01-03 4:56 ` [PATCH v2 2/5] ASoC: samsung: i2s: add support for FSD I2S Padmanabhan Rajanbabu
2023-01-03 8:23 ` kernel test robot
2023-01-03 10:45 ` kernel test robot
2023-01-03 11:08 ` Krzysztof Kozlowski
2023-01-09 4:04 ` Padmanabhan Rajanbabu
2023-01-03 18:09 ` Mark Brown
2023-01-09 4:05 ` Padmanabhan Rajanbabu
[not found] ` <CGME20230103045659epcas5p322e2f3ad2b43e5a22f43135dc3e46f75@epcas5p3.samsung.com>
2023-01-03 4:56 ` [PATCH v2 3/5] arm64: dts: fsd: Add I2S DAI node for Tesla FSD Padmanabhan Rajanbabu
[not found] ` <CGME20230103045703epcas5p2344520777efa3c06321732e2784e6c6c@epcas5p2.samsung.com>
2023-01-03 4:56 ` [PATCH v2 4/5] arm64: dts: fsd: Add codec " Padmanabhan Rajanbabu
2023-01-03 11:11 ` Krzysztof Kozlowski
2023-01-09 4:05 ` Padmanabhan Rajanbabu
[not found] ` <CGME20230103045706epcas5p14f2f951d162899234c7f5f7a0998ab6b@epcas5p1.samsung.com>
2023-01-03 4:56 ` [PATCH v2 5/5] arm64: dts: fsd: Add sound card " Padmanabhan Rajanbabu
2023-01-03 11:13 ` Krzysztof Kozlowski
2023-01-09 4:05 ` Padmanabhan Rajanbabu [this message]
2023-01-09 8:28 ` Krzysztof Kozlowski
2023-01-13 12:14 ` Padmanabhan Rajanbabu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='051601d923df$a0e7b840$e2b728c0$@samsung.com' \
--to=p.rajanbabu@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=aswani.reddy@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=perex@perex.cz \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).