From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756286AbcEXQo7 (ORCPT ); Tue, 24 May 2016 12:44:59 -0400 Received: from mail-bl2on0076.outbound.protection.outlook.com ([65.55.169.76]:58176 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754421AbcEXQox (ORCPT ); Tue, 24 May 2016 12:44:53 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.21) smtp.mailfrom=sandisk.com; davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c69-73fff70000000ac3-2b-574484283489 Subject: Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver To: Greg KH References: <1464097978-88457-1-git-send-email-bryantly@linux.vnet.ibm.com> <3303bc98-ade7-62f0-71c7-11e7ef42b42d@sandisk.com> <20160524163411.GA21800@kroah.com> CC: "Bryant G. Ly" , "JBottomley@odin.com" , "martin.petersen@oracle.com" , "tyreld@linux.vnet.ibm.com" , "akpm@linux-foundation.org" , "kvalo@codeaurora.org" , "davem@davemloft.net" , "mchehab@osg.samsung.com" , "jslaby@suse.com" , "joe@perches.com" , "bp@suse.de" , "linux-kernel@vger.kernel.org" , "linux-scsi@vger.kernel.org" , "target-devel@vger.kernel.org" , bgly From: Bart Van Assche Message-ID: <05554b20-46af-5298-e822-9d8bcba6b096@sandisk.com> Date: Tue, 24 May 2016 09:44:43 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160524163411.GA21800@kroah.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsWyRoxnka5mi0u4wbO7lhZz1q9hs1g+dT+j xcR+TYs9u5vZLOacb2GxaF68ns3i//rbLBaz7z9msZiy4QOTxaKVC9ksLu+aw2bRfX0HUNfx f0wWq59VWLQufctksb5pG6uDgMflvl4mjy0rbzJ5nJjxm8XjwaHNLB77565h9zj84wezx8en t1g8tvTfZff4suoas8f6LVdZPDafrvY4d62P2ePzJrkA3igum5TUnMyy1CJ9uwSujCuXljIW rOSoaO5Zx9TAeJ+ti5GTQ0LAROLe9w2MXYxcHEICc5kkOrqus0I4Oxgltp9ZzwpT9fXmfDaI xFJGiYlfnrGDJIQF3CQWLf3GCGKLCGhIvDx6iwWuqH/fTDCHWeA5q8ShazPAFrIJGEl8ew+S 4OTgFbCT6DnyBWwFi4CqxIrLEHFRgQiJT78h4rwCghInZz4Bi3MK6EvsmHEabDOzgIXEzPnn GSFseYntb+cwgyyTENjDJjFx92VmkISQgLrEySXzmSYwCs9CMmsWkv5ZSPoXMDKvYhTLzcwp zk1PLTA01StOzEvJLM7WS87P3cQIie7MHYx3n3gfYhTgYFTi4Q3Idw4XYk0sK67MPcQowcGs JMJr3+gSLsSbklhZlVqUH19UmpNafIhRmoNFSZzX7d6XMCGB9MSS1OzU1ILUIpgsEwenVAOj ttfrlEXb53tlLFy5+YvXiqCb+b/qZz65OiMtwmrZUQ91U6ePbpwrnB3fCP7m8Ax/fYhvjr66 6np29sKq28pTfx/l2VVas+nLk4f/kz0YC8QDq3lyw3aaRl3uisqpuWXy27AzrP28ss50qb1t ByqWlZg9TVGRWloY8kvh68I/uTs6V24zqD6rxFKckWioxVxUnAgAUcSM/OoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrDLMWRmVeSWpSXmKPExsXCtZEjRfdvi0u4werjohZz1q9hs1g+dT+j xcR+TYs9u5vZLOacb2GxaF68ns3i//rbLBaz7z9msZiy4QOTxaKVC9ksLu+aw2bRfX0HUNfx f0wWq59VWLQufctksb5pG6uDgMflvl4mjy0rbzJ5nJjxm8XjwaHNLB77565h9zj84wezx8en t1g8tvTfZff4suoas8f6LVdZPDafrvY4d62P2ePzJrkA3igum5TUnMyy1CJ9uwSujCuXljIW rOSoaO5Zx9TAeJ+ti5GTQ0LAROLrzflANheHkMBiRol7r+YxgiSEBdwkFi39BmaLCGhIvDx6 iwWiaCmjRP++mWAOs8BrVomdCyewglSxCRhJfHsPkuDk4BWwk+g58gUsziKgKrHiMkRcVCBC 4tNviDivgKDEyZlPwOKcAvoSO2acZgexmQXMJOZtfsgMYctLbH87h3kCI98sJC2zkJTNQlK2 gJF5FaNYbmZOcW56ZoGhoV5xYl5KZnG2XnJ+7iZGcHxxRu5gfDrR/BAjEwenVAMjy7/WXl3n zVeaD/4+YLDdTbyFx7K4e17Ans6n9WtdI7fdPPAhMfq/5r/JJq5tF26zKf1tDawSv3QudIP5 UhPlZxfE1JovrQuWqLTxyPh3KVNA9e6b/Z92vuV6/1NhAa+MJ6sAw5HJYsz819938lXYp7zr PVQtGP07OZbpw4OfLcwLZodVsJ9WYinOSDTUYi4qTgQAyAnqL18CAAA= X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.21;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(377454003)(199003)(189002)(9170700003)(54356999)(8676002)(8936002)(230700001)(33646002)(81166006)(586003)(65956001)(31696002)(5003600100002)(1220700001)(87936001)(106466001)(86362001)(2906002)(36756003)(76176999)(4326007)(50986999)(65806001)(47776003)(92566002)(2950100001)(110136002)(31686004)(83506001)(23676002)(8666003)(6806005)(5008740100001)(189998001)(11100500001)(2270400002)(64126003)(77096005)(53416004)(50466002)(4001350100001)(65826006)(7059030)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB524;H:milsmgep15.sandisk.com;FPR:;SPF:Pass;MLV:sfv;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD036;1:iajqKBVPTNnYCBDrQZG0N1OHfV+/qmjt7i0vXweaNYEJwhpqEsue9KPumsVkqgsbKEUs0eyTry85AiH/zdYWfNp5+w879gKwe4qDx10lDoK+pyaKzB46rD5GAz2LgLHuYJBt7gIDsBYNtuQGwHX2vWZQ7SKMHlGlQOltghBmnlSxtdUkwyffkIfQOnGXy9k5yfWk12/rUvFs81MvXl66AOOLwNqI6PwGFJt5PuGnBde/QJBbgSqRi1lW1+9tCa+JAt7S7SYP3ReQH7hkJ3/QsfzqdBMCGF++xzWleFJNlOBDA0ezMs/14IRzNvF7JTYoOFKe268mMuANAnBX7SAg8pOK1vrBHfNLjctf041DIMMbT0LLP+oez+eRsEuEwj15XZCGFHlg6uRTo2CYWPVP/UiO8X79A21LU1GdzGk6vHBSYXq5Dlg73Fc/ZOhk/edEjE2QeYgd00m3It3A5X5zHGnxnaWsRHFyKDZ82HAql60= X-MS-Office365-Filtering-Correlation-Id: 47463b07-5b6f-487a-de17-08d383f2b7eb X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB524;2:LkFQ7mGStsykUJvx1KPUYcbo2C9Q1E1fI8NIs/wlurmbeUNon3Bf6rQGvSXeEJVSr9UaXF8iep8O+s+bK1KJbQr+3OEgPygRmp8a7J2jQZRvRSoWBfAv1UQGE7XOz2ShOY/of1qYE+FlV+jPdD7PBtTrIE1Za0dxsTAmYvDjHXlSeowFbMjItJkQ+FVsxCGI;3:a/Iij6TlnSalzzS4m+UyUIwFsPoF7qKdrZEqHmaDqVSfs0BOicowCM7Gc6MQw1rcM+xj3B3vE0ZfXpuB+3OnXfQkDHVn4dofcN2Bs12yZ5dvMA4MNTd2AOUvQlmpfC0cIHd368qnvfJSLE2Tr9+GMsM0XN8n9QOAYA/wJf5fuPc0iakFYOjgbxDZwrncO/QlucjcFZrRVdN7hLqInEGu+Yz0Qbanpmy1xjp89QDXEhvVVWGDnZVZwb4Sc4ZKTPrKM56fBZ6RRNYJYD/Ei9vAmg== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:BY2PR02MB524; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB524;25:ySWpqoMUbezs79GAaBCtUekD26l+Ptevlv8+LP+7mE7HsIvyYwRs6MqjU/IhZiCjiMTXrG1ux96uOnd7Ecg8b+AdyF3ZrE3FOHlvjYg8rCH9U6QaZtFT3j4gNu4/LTW6e9eLAwl7QpfDcV6Zg9gEZl1KTBwVC/IhsS+EBF7PBIiNFQtg3+G/jOwRznqYyZ24h90I6aK6eGuOYYxHs4FeaVYCfVgIiORf6jFPKqDlIJlg07VZSACjspdOFCKYJjmNrffCLIIt1UHftMArPAQea5kkGLjArUrOjvJg3S5PCTIpPw4bwivBFVmT25qWv2YYBAOWJZFMluQppqK8pJQVg6Kcs0HsmlZkW3i5i+vDD9lHNIxY3CVWHV5yk8CuLqtVu+HFhjB7QmsULbj44ORtXzYqYY/5kcYptv4eHT1w7+LWumuSdAkZjsZCYQvX3virwFL6HegrRyFlYuObGl0zwdy7wo+5FW1xG852KDwyK/37GmBMokx+KeBCdhE5fgE54BpxpvZmjq5LJeZWp1KhtVE8sV5v3Dzoz3OaYt6XK6ZHrVEZqCXyXsX2I0ua76AkXEaYlD4xvoInoBrfivwtW6MBB6pdPrtHZ9ZK5YGpXhzsm8pQ4pwd/PyLPJa8LVt9SzNHlnHWtalxS63t+C4sUesUyRbpysxVKQFbm7IvSOtrVA6nsOJvGBxFOflbwljYTBaBWkaTSxsHj4Bir5ViZfSkWfWGpcm/lkBiGUL9YrfZ8e1OBPfRKbWHw5ubuEL/BVzlZ9l813w9q3Etm7ekpzCZyG8uWEem4Fc+di5dqgQ= X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB524;20:isifx74UhKmJThM2zyp20LbRG+uIYFVe8DF+nypj5ItvJ29x3ltWAX1QBGk4nBLoN02WkDPH1XfJCmCLEPsOClTFVJuexFeRSr4Q6Mz1Mq/4lh+QW+v+T9isvdfLV58ROjbr3K9MueJnSkA0846ULE6M6kdlSRLfPv4eNLVLcGt4z/SKn4IqSebtBmpHuHm20z8fwz+HPMGprokaJARN9NHS74zwk1utU9ZP64FPQLZIIDy0ClntvvPHD3/FZlsqplZD2h1nuEuG4xl+IL1FiXDK1JChKffHFqrqKNID9RqIgVb9hIl6K4AJPk8jfxHwzxOGDP18HT5Mg5ZMom6eX3Ch7BXQVl3CKo/LcX4V7S34ETSosUXSfz5Zg0xrRHKpVLzueMoY9cE+hAvqwvKpCrxqGm4sfWc9G1xE+bLbLcJuGXQVti/DVqc/OAa+IzWw6SvGuVr/oRF/Eu206ykOVeKJtKIR83Rs701BS3cKrzqobxYODTBZ+Hlvf5IA2Llj;4:ZmQBPF0lKMblJiPxF9NiCht1CuU+syExCxgEGEuidmxBpQEkIklK3EQ2i63Q/F3NlCwDxTgyIXc+EhnUlQk0PiDO54vwdOb/hMPynxSL6olFCdI0o0khYUGkFU4vTQZczRPvdkCHifHAU1CZNSXDwLLuaMNOZE8/a9L8Vck0Yb7OJJd7Cayx16UEjlSU9qfpHS4C1A+IMUdcQOCIdOV9tv3NVGIl24rU3yyDjVHPik1wvxBz9pV6TUxf0+6v1NQo/p5xKb8eIzZmHU+l+nNaq8smlWx7V6ew5YEdkKPnnF6JrLQvN+AmtUTrqjMOVeNvxdw+yyC8k5OYAFTcgFjcCpozh+2Hz7niV5kAQICz8VaasVrFX47OmAAuzw+VMDtoBI9uHs/8wEh23v+ziBFWxsejeWkVlBzqLL6O1OiR7mM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13018025)(8121501046)(5005006)(13016025)(3002001)(10201501046)(6055026);SRVR:BY2PR02MB524;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB524; X-Forefront-PRVS: 09525C61DB X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAyTUI1MjQ7MjM6QitnQXJjYitWa09QYndOWER4RnAxVytvZERS?= =?utf-8?B?WG5EeUYrUVFxN1dSaXNpNGU2N1ZIdnBNMWwrcE5LTWFHdzZnaVY4TFliWWxn?= =?utf-8?B?MG5nd0VQNGk5TW96aVFwd3RGN21XSHJSS0hMTjJ3ZTFlS0QvQXNhaE5kd3hp?= =?utf-8?B?UWgwZ2VPOWtZejk2ZVRMY0h1ZzN0Y0JZSU5KNy91V1pnYkxlRmJ0RHRtSjkr?= =?utf-8?B?Qm85cDM1OGJraVE0S1ozMG5kVHp0NHZnZXoxaEcxeGZDY2JUTG9wbFlQU0Jy?= =?utf-8?B?OXZiV1FZMWJSSE9vS2t3clZZRHhKWVlYU3QrbThDZzlMRkdYeWNRUUVicklr?= =?utf-8?B?Nk9qS05yVGZOVnJNK3IwWmpJTkloNnorRnZDcy9IRDFSWXpvSDF1SjQ3NENM?= =?utf-8?B?YThXWFd1T3kweE94NTYyWUJpamwrWTV3UklOT0MrUWU0QStmZ1dVQXFSdnZt?= =?utf-8?B?Uk1qWGZYdWpXTEQycExJNUpQNnk0OFcxc2dZV0VtMjVJT0RHTDBVRVRabEE2?= =?utf-8?B?T2pCMitnRWs5R0hCZ0NEb1FpakVuRExUMFllL1piMnBTaVN3NktrQ2s4YTRY?= =?utf-8?B?UUtRODJVY3RndnN3VnBLV0NsY2tBakN4UWFHb2tQYkxXbVRXUWdJOVN1a1Bj?= =?utf-8?B?S0FRaUZwMUlHSXY2WlQxbEhtSENENS94ZDlzL2xiSUtuV3F3cTAySkhyTDR6?= =?utf-8?B?TlRSQjZZa2lWS2NpZ3JxNlBscFZrZHRkbDB4Y2w2RHNHK2VGNkJ4cEN3Z004?= =?utf-8?B?ZkphQktHejV1OFRDb3QzTE1hdFpHSEVhMGY5emxpZnVZMHdQU3NLUEsrNk0w?= =?utf-8?B?QWpyblZnWlBKT2p3OTN4dlRkVEVMRVVwRkRaeG9Zc01IQ2xoYm1IR0lsYVc2?= =?utf-8?B?SXRoVmpMcy8xRTRGVEdXSEdFQTFzSWs2STBsQkhJRTBvWFZOcDJzU285Wkx2?= =?utf-8?B?L0NkWEZNS1pvSGduaEtZYkVJc1ByVVFPWUZ2aWxYMFU1cFgvQnc5dXBJbkdj?= =?utf-8?B?TU5XTHAzTW5LWHgvU2ZFUjBxRmkxRDcyZG1EZ3k3SjBPVmRZQUJvUmo1bnN6?= =?utf-8?B?a2xZMTNDaGIxZHgwTjdtN1lTdUdJalV6dkNwSjIxOXIyRmpzQ2NOVERpK0h5?= =?utf-8?B?cWxlTkZjLzFkV0lYRXozNW9NRFh6b01paVNVZDNWWFgwTGNXUGVRWGx4Rmdk?= =?utf-8?B?Y1Z5MklENDVoQXR2UmpMQk1veHJYZzc5M0JUcnM0QW0yZGtkaXRGVkNuTmVX?= =?utf-8?B?S0NMTUlqNVZmSjQ4dWJFeFlldStlNUQya01RdG95VFJLaEh6T1o4V1g5N3ZW?= =?utf-8?B?bzI3VzArc3psekFvbWZCU2xYVUhhK1hLN2t2dy8raXFzRU9MTk1rQlhnc2g4?= =?utf-8?B?eTZyNXozQVJ4TkwwMEQ5dmZwTmVFTzA1OTNXRHJiMjljWllVZW81WTdIbWtM?= =?utf-8?B?cTNvcFRZQjI3S05SWkxSVnp2Z1VKWXZzY24yUEdlMzNzaHVBdFViejQyV2s2?= =?utf-8?B?bnZoWXhCUzBRUXArSDQyVHp2a2J4M1VhRWRyeTJ5MFhmSUlsOVNRNEtQeHZr?= =?utf-8?B?R3B2ZWs1US81S05EeXRqblBITFZzb0xLV3FURVhuM0UyU3FPOUVYcDBNTlY4?= =?utf-8?B?OFVwMWx3UUxLWXVZcHRyeHVITWxuK1ZoeGd6eERDTDlaa2F2Q1FONG4wR09x?= =?utf-8?Q?MNYhvUa1tyuQOobAE=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB524;5:00IMtY96i2y2b0LRrGvz3CIoSTMoz1M8F+QyZLSukNb6yxeLC0KuQfOUsLdn1QSnvrQfaO0iHXabxnjQGQtzSwK25axsK67K0CXYq142JAmJlpDMKhduEs3LowO2bmDA7p7oZmwpN2/LTRTgzedFEw==;24:L+Xa0vwaJ8he04YDx5++74Ba2pTpyF66ypAglMX5LgaAjIn4RwO68DNmYFjszWvIa6dVhq7xhvlpHx4+uCjKQXEdQSlYtarponYmSkNny5Y=;7:VEmFsRFbnxlezK7KgIuN/TOpb7cYtg2e/JVnAC9iCs3RMEcVBiWixnutou4ACnuvbZrg1d5/ylnfelLLGcaT4cavwVlKsY4BcchSAi70DUN3ASeU8gsyLOU2U8oVcprBBjaSJDgvRkuCs9gk+UG+Vgbo5p58SSVRVVOgp8mQgg7W+OJtyFxyEjbSFTR9MDdN;20:oM96Mwvxnlz60qzJlhSIH8H7L/5zLT2B0MdsI556vZG+8ZQctOX4nVlbOhL/x/s9BhoiUgD2ZDnP8/Ha2tM13Awaku/heWCO8pqdyECKD5E8Lf0naoCJja8h9dI8v6zXyApURAgu6X74j9L2C3CnaJVCoStotwQv8JiHhWVFC7Ko66TcuB4HEynaKJIJ+E0cQqjukh4jEkYFXriIUxixO6vqT7g5/B425vNk7+JoUxpEf/TnLehI/JImG3352b8c SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2016 16:44:47.8980 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.21];Helo=[milsmgep15.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB524 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/24/2016 09:34 AM, Greg KH wrote: > On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: >>> +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, >>> + u64 word1, u64 word2) >>> +{ >>> + long rc; >>> + struct vio_dev *vdev = adapter->dma_dev; >>> + >>> + pr_debug("ibmvscsis: ibmvscsis_send_crq(0x%x, 0x%016llx, 0x%016llx)\n", >>> + vdev->unit_address, word1, word2); >>> + >> >> As Joe Perches already asked, please define pr_fmt() instead of including >> the kernel module name in every pr_debug() statement. > > Even better, as this is a driver, it should be using dev_*() calls > instead of pr_*() calls to properly identify the device and driver that > is making the message. No driver should be using pr_*() except in > _very_ limited usages. Hi Greg, The reason I recommended pr_debug() is because ibmvscsis is a LIO target driver and I don't think a struct device is associated with a LIO target driver. See e.g. target_register_template() in drivers/target/target_core_configfs.c. Bart.