From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Yicong Yang <yangyicong@hisilicon.com>,
wsa@kernel.org, andriy.shevchenko@linux.intel.com,
linux-i2c@vger.kernel.org, Sergey.Semin@baikalelectronics.ru,
linux-kernel@vger.kernel.org
Cc: digetx@gmail.com, treding@nvidia.com, rmk+kernel@armlinux.org.uk,
song.bao.hua@hisilicon.com, john.garry@huawei.com,
mika.westerberg@linux.intel.com, prime.zeng@huawei.com,
linuxarm@huawei.com
Subject: Re: [PATCH v5 2/5] i2c: core: add api to provide frequency mode strings
Date: Wed, 31 Mar 2021 11:35:23 +0300 [thread overview]
Message-ID: <0561a225-3dbb-97b1-a0a8-223520885c05@linux.intel.com> (raw)
In-Reply-To: <1617113966-40498-3-git-send-email-yangyicong@hisilicon.com>
Hi
On 3/30/21 5:19 PM, Yicong Yang wrote:
> Some I2C drivers like Designware and HiSilicon will print the
> bus frequency mode information, so add a public one that everyone
> can make use of.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
> ---
> include/linux/i2c.h | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 10bd0b0..6837e64 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -47,6 +47,26 @@ typedef int (*i2c_slave_cb_t)(struct i2c_client *client,
> #define I2C_MAX_HIGH_SPEED_MODE_FREQ 3400000
> #define I2C_MAX_ULTRA_FAST_MODE_FREQ 5000000
>
> +static inline const char *i2c_freq_mode_string(u32 bus_freq_hz)
> +{
> + switch (bus_freq_hz) {
> + case I2C_MAX_STANDARD_MODE_FREQ:
> + return "Standard Mode(100KHz)";
> + case I2C_MAX_FAST_MODE_FREQ:
> + return "Fast Mode(400KHz)";
> + case I2C_MAX_FAST_MODE_PLUS_FREQ:
> + return "Fast Mode Plus(1.0MHz)";
> + case I2C_MAX_TURBO_MODE_FREQ:
> + return "Turbo Mode(1.4MHz)";
> + case I2C_MAX_HIGH_SPEED_MODE_FREQ:
> + return "High Speed Mode(3.4MHz)";
> + case I2C_MAX_ULTRA_FAST_MODE_FREQ:
> + return "Ultra Fast Mode(5.0MHz)";
> + default:
> + return "Unknown Mode";
> + }
A few minor nits here:
- KHz -> kHz
- Space between text and opening parenthesis: "Mode(" -> "Mode ("
- Space between number and unit: (1.0MHz) -> (1.0 MHz)
With those changes you may add my
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2021-03-31 8:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 14:19 [PATCH v5 0/5] Add support for HiSilicon I2C controller Yicong Yang
2021-03-30 14:19 ` [PATCH v5 1/5] i2c: core: add managed function for adding i2c adapters Yicong Yang
2021-03-30 16:28 ` Dmitry Osipenko
2021-03-30 14:19 ` [PATCH v5 2/5] i2c: core: add api to provide frequency mode strings Yicong Yang
2021-03-31 8:35 ` Jarkko Nikula [this message]
2021-03-31 13:03 ` Yicong Yang
2021-03-30 14:19 ` [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller Yicong Yang
2021-03-30 16:24 ` Dmitry Osipenko
2021-03-30 16:32 ` Dmitry Osipenko
2021-03-30 16:33 ` Dmitry Osipenko
2021-03-30 14:19 ` [PATCH v5 4/5] MAINTAINERS: Add maintainer for HiSilicon I2C driver Yicong Yang
2021-03-30 14:19 ` [PATCH 5/5] i2c: designware: Switch over to i2c_freq_mode_string() Yicong Yang
2021-03-30 21:36 ` Song Bao Hua (Barry Song)
[not found] ` <CAHp75VdY58Tm0FDcoVDWuw0LBKUFWC_hBCb5t=4WX_MPzsLvZw@mail.gmail.com>
2021-03-30 22:01 ` Song Bao Hua (Barry Song)
2021-03-30 22:06 ` Song Bao Hua (Barry Song)
[not found] ` <CAHp75VeTj-wk3WP2-Unoti0+Cajx33b8NOUbBiSBQLmJHn=YAg@mail.gmail.com>
2021-03-31 8:53 ` Song Bao Hua (Barry Song)
2021-03-31 10:19 ` Andy Shevchenko
2021-03-31 10:37 ` Andy Shevchenko
2021-03-31 13:02 ` Yicong Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0561a225-3dbb-97b1-a0a8-223520885c05@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=john.garry@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=prime.zeng@huawei.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=song.bao.hua@hisilicon.com \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).