From: Hanjun Guo <guohanjun@huawei.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ACPI <linux-acpi@vger.kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Erik Kaneda <erik.kaneda@intel.com>,
"Joe Perches" <joe@perches.com>
Subject: Re: [PATCH v3 2/5] ACPI: battery: Clean up printing messages
Date: Thu, 4 Feb 2021 09:18:29 +0800 [thread overview]
Message-ID: <056c6a20-4957-e112-6a8f-62fe39247e56@huawei.com> (raw)
In-Reply-To: <1731128.lCOlkKr4QW@kreacher>
On 2021/2/4 2:44, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki<rafael.j.wysocki@intel.com>
>
> Replace the ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() instances
> in battery.c with acpi_handle_debug() and acpi_handle_info() calls,
> respectively, which among other things causes the excessive log
> level of the messages previously printed via ACPI_EXCEPTION() to
> be increased.
>
> Drop the _COMPONENT and ACPI_MODULE_NAME() definitions that are not
> used any more, drop the no longer needed ACPI_BATTERY_COMPONENT
> definition from the headers and update the documentation accordingly.
>
> While at it, update the pr_fmt() definition and drop the unneeded
> PREFIX sybmbol definition from battery.c. Also adapt the existing
> pr_info() calls to the new pr_fmt() definition.
>
> Signed-off-by: Rafael J. Wysocki<rafael.j.wysocki@intel.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Thanks
Hanjun
next prev parent reply other threads:[~2021-02-04 1:19 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 18:14 [PATCH v1 0/5] ACPI: More cleanups related to printing messages Rafael J. Wysocki
2021-02-01 18:15 ` [PATCH v1 1/5] ACPI: AC: Clean up " Rafael J. Wysocki
2021-02-01 18:16 ` [PATCH v1 2/5] ACPI: battery: " Rafael J. Wysocki
2021-02-01 18:35 ` Joe Perches
2021-02-01 18:44 ` Rafael J. Wysocki
2021-02-02 13:38 ` Joe Perches
2021-02-02 14:09 ` Rafael J. Wysocki
2021-02-01 18:17 ` [PATCH v1 3/5] ACPI: button: " Rafael J. Wysocki
2021-02-01 18:18 ` [PATCH v1 4/5] ACPI: video: " Rafael J. Wysocki
2021-02-01 18:19 ` [PATCH v1 5/5] ACPI: thermal: " Rafael J. Wysocki
2021-02-02 18:11 ` [PATCH v2 0/5] ACPI: More cleanups related to " Rafael J. Wysocki
2021-02-02 18:14 ` [PATCH v2 1/5] ACPI: AC: Clean up " Rafael J. Wysocki
2021-02-03 1:31 ` Hanjun Guo
2021-02-03 18:27 ` Rafael J. Wysocki
2021-02-02 18:15 ` [PATCH v2 2/5] ACPI: battery: " Rafael J. Wysocki
2021-02-03 1:44 ` Hanjun Guo
2021-02-02 18:17 ` [PATCH v2 3/5] ACPI: button: " Rafael J. Wysocki
2021-02-03 1:56 ` Hanjun Guo
2021-02-02 18:18 ` [PATCH v2 4/5] ACPI: video: " Rafael J. Wysocki
2021-02-03 2:16 ` Hanjun Guo
2021-02-02 18:19 ` [PATCH v2 5/5] ACPI: thermal: " Rafael J. Wysocki
2021-02-03 2:23 ` Hanjun Guo
2021-02-03 18:40 ` [PATCH v3 0/5] ACPI: More cleanups related to " Rafael J. Wysocki
2021-02-03 18:43 ` [PATCH v3 1/5] ACPI: AC: Clean up " Rafael J. Wysocki
2021-02-04 1:12 ` Hanjun Guo
2021-02-04 18:25 ` Hans de Goede
2021-02-03 18:44 ` [PATCH v3 2/5] ACPI: battery: " Rafael J. Wysocki
2021-02-04 1:18 ` Hanjun Guo [this message]
2021-02-04 18:27 ` Hans de Goede
2021-02-04 18:31 ` Hans de Goede
2021-02-03 18:46 ` [PATCH v3 3/5] ACPI: button: " Rafael J. Wysocki
2021-02-04 18:28 ` Hans de Goede
2021-02-03 18:48 ` [PATCH v3 4/5] ACPI: video: " Rafael J. Wysocki
2021-02-04 1:42 ` Hanjun Guo
2021-02-04 18:33 ` Hans de Goede
2021-02-03 18:49 ` [PATCH v3 5/5] ACPI: thermal: " Rafael J. Wysocki
2021-02-04 18:36 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=056c6a20-4957-e112-6a8f-62fe39247e56@huawei.com \
--to=guohanjun@huawei.com \
--cc=erik.kaneda@intel.com \
--cc=hdegoede@redhat.com \
--cc=joe@perches.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).