From: "Van De Ven, Arjan" <arjan.van.de.ven@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>, Andi Kleen <andi@firstfloor.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
Andi Kleen <ak@linux.intel.com>,
"jeyu@kernel.org" <jeyu@kernel.org>
Subject: RE: [PATCH] retpoline/module: Taint kernel for missing retpoline in module
Date: Sat, 13 Jan 2018 14:38:51 +0000 [thread overview]
Message-ID: <0575AF4FD06DD142AD198903C74E1CC87A5C9013@FMSMSX151.amr.corp.intel.com> (raw)
In-Reply-To: <20180113141209.GA13015@kroah.com>
> > When the a module hasn't been compiled with a retpoline
> > aware compiler, print a warning and set a taint flag.
>
> Isn't that caught by the "build with a different compiler/version" check
> that we have? Or used to have? If not, can't we just make it into that
> type of check to catch this type of problem no matter what type of
> feature/option it is trying to catch?
making retpoline part of the modversion hash thingy could make sense.
but I kinda feel this is a bit overkill; it's not a function issue if you get this wrong, and if you run an ancient or weird out of tree module there's a real chance you have
other security fun as well ;-)
next prev parent reply other threads:[~2018-01-13 14:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 17:55 [PATCH] retpoline/module: Taint kernel for missing retpoline in module Andi Kleen
2018-01-12 19:01 ` David Woodhouse
2018-01-12 19:17 ` Andi Kleen
2018-01-13 14:12 ` Greg KH
2018-01-13 14:38 ` Van De Ven, Arjan [this message]
2018-01-13 15:37 ` Greg KH
2018-01-13 14:53 ` Andi Kleen
2018-01-13 15:36 ` Greg KH
2018-01-13 18:20 ` Andi Kleen
2018-01-16 20:08 ` Andi Kleen
2018-01-15 12:47 ` David Laight
2018-01-15 12:53 ` Van De Ven, Arjan
2018-01-15 13:01 ` David Woodhouse
2018-01-15 14:08 ` David Laight
2018-01-15 16:48 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0575AF4FD06DD142AD198903C74E1CC87A5C9013@FMSMSX151.amr.corp.intel.com \
--to=arjan.van.de.ven@intel.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).