From: "Jin, Yao" <yao.jin@linux.intel.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
mingo@redhat.com, alexander.shishkin@linux.intel.com,
Linux-kernel@vger.kernel.org, ak@linux.intel.com,
kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v3 00/11] perf stat: Enable '--per-thread' on all thread
Date: Thu, 30 Nov 2017 08:20:18 +0800 [thread overview]
Message-ID: <05809a8a-76f1-8777-d83b-e2d285964d82@linux.intel.com> (raw)
In-Reply-To: <20171129151637.GA15069@krava>
On 11/29/2017 11:16 PM, Jiri Olsa wrote:
> On Wed, Nov 29, 2017 at 08:05:47PM +0800, Jin Yao wrote:
>> v3:
>> ---
>> Update according to Jiri's comments. The major modifications are:
>>
>> 1. Fix the crash issue when performing the git bisect.
>> Move the removing of runtime_saved_values to the switching point
>> (perf util: Remove a set of shadow stats static variables).
>>
>> 2. Still add struct perf_stat_config::*stats|stats_num in earlier
>> patch because 'stats' will be used in
>> 'perf util: Update and print per-thread shadow stats'.
>> If it's moved to 'perf stat: Allocate shadow stats buffer for threads',
>> the compilation would be failed.
>
> sure, that's why also that hunk from 'perf util: Update and print per-thread shadow stats'
> needs to be moved to 'perf stat: Allocate shadow stats buffer for threads'
>
> this one:
>
> + if (stat_config.stats)
> + stat = &stat_config.stats[thread];
> + else
> + stat = &rt_stat;
> +
> + printout(thread, 0, counter, uval, prefix, run, ena, 1.0,
> + stat);
>
> you already did that in 'perf stat: Allocate shadow stats buffer for threads' for:
>
> + if (config->aggr_mode == AGGR_THREAD) {
> + if (config->stats)
> + perf_stat__update_shadow_stats(evsel,
> + count->val, 0, &config->stats[thread]);
> + else
> + perf_stat__update_shadow_stats(evsel,
> + count->val, 0, &rt_stat);
> + }
>
>
> thanks,
> jirka
>
OK, I will move this code from 'perf util: Update and print per-thread
shadow stats' to 'perf stat: Allocate shadow stats buffer for threads'.
And I will also add struct perf_stat_config::*stats|stats_num in 'perf
stat: Allocate shadow stats buffer for threads'.
I will send v4 soon.
Thanks
Jin Yao
prev parent reply other threads:[~2017-11-30 0:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 12:05 [PATCH v3 00/11] perf stat: Enable '--per-thread' on all thread Jin Yao
2017-11-29 12:05 ` [PATCH v3 01/11] perf util: Create rblist__reset() function Jin Yao
2017-11-29 12:05 ` [PATCH v3 02/11] perf util: Define a structure for runtime shadow stats Jin Yao
2017-11-29 12:05 ` [PATCH v3 03/11] perf util: Extend rbtree to support " Jin Yao
2017-11-29 12:05 ` [PATCH v3 04/11] perf util: Add rbtree node_delete ops Jin Yao
2017-11-29 12:05 ` [PATCH v3 05/11] perf util: Create the runtime_stat init/free function Jin Yao
2017-11-29 12:05 ` [PATCH v3 06/11] perf util: Update and print per-thread shadow stats Jin Yao
2017-11-29 12:05 ` [PATCH v3 07/11] perf util: Remove a set of shadow stats static variables Jin Yao
2017-11-29 12:05 ` [PATCH v3 08/11] perf stat: Allocate shadow stats buffer for threads Jin Yao
2017-11-29 12:05 ` [PATCH v3 09/11] perf util: Reuse thread_map__new_by_uid to enumerate threads from /proc Jin Yao
2017-11-29 12:05 ` [PATCH v3 10/11] perf stat: Remove --per-thread pid/tid limitation Jin Yao
2017-11-29 12:05 ` [PATCH v3 11/11] perf stat: Resort '--per-thread' result Jin Yao
2017-11-29 15:16 ` [PATCH v3 00/11] perf stat: Enable '--per-thread' on all thread Jiri Olsa
2017-11-30 0:20 ` Jin, Yao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05809a8a-76f1-8777-d83b-e2d285964d82@linux.intel.com \
--to=yao.jin@linux.intel.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).